Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 6469046: devserver: better handling of archive directory (Closed)

Created:
9 years, 10 months ago by zbehan
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis
Visibility:
Public.

Description

devserver: better handling of archive directory Fixes relative references to static directory in archive dir handling. Originally, the archive dir was linked into static/archive. But the location of static was hardcoded to be in ./, which is untrue for chroot installed devserver. This also works around for odd uses of archive directory to keep cros_au_test_harness working, before it can be fixed - see inlined code comments. BUG=5246 TEST=run cros_au_test_harness Change-Id: Ia3eb04fdb9e85d94e2e9e65bd8b89ce5ca930bf8 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=608f46c

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : omg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M devserver.py View 1 2 3 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zbehan
9 years, 10 months ago (2011-02-18 05:17:36 UTC) #1
sosa
nits http://codereview.chromium.org/6469046/diff/1/devserver.py File devserver.py (right): http://codereview.chromium.org/6469046/diff/1/devserver.py#newcode167 devserver.py:167: # FIXME(zbehan) Legacy support: TODO(zbehan): Remove legacy support ...
9 years, 10 months ago (2011-02-18 22:24:42 UTC) #2
zbehan
9 years, 10 months ago (2011-02-18 23:13:38 UTC) #3
sosa
LGTM, thanks for the change!
9 years, 10 months ago (2011-02-18 23:16:44 UTC) #4
sosa
LGTM, thanks for the change!
9 years, 10 months ago (2011-02-18 23:16:45 UTC) #5
zbehan
9 years, 10 months ago (2011-02-18 23:35:55 UTC) #6
zbehan
9 years, 10 months ago (2011-02-18 23:39:00 UTC) #7
Should've waited for harness to pass before uploading :/ Now it does work.

On Sat, Feb 19, 2011 at 12:35 AM, <zbehan@chromium.org> wrote:

> http://codereview.chromium.org/6469046/
>

Powered by Google App Engine
This is Rietveld 408576698