Issue 6469038: Quick fix for problems with editable text field accessibility by not sending...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6469038: Quick fix for problems with editable text field accessibility by not sending... (Closed)

Created:
9 years, 10 months ago by dmazzoni

Modified:
9 years, 7 months ago

Reviewers:
Chris Guillory

CC:
chromium-reviews, darin-cc_chromium.org, David Tseng

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Quick fix for problems with editable text field accessibility by not sending children of text fields from the renderer to the browser. The child containing the text appeared to be redundant anyway. BUG=none TEST=updated unit test, manual testing with screen readers Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75416

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/accessibility/accessibility_win_browsertest.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	webkit/glue/webaccessibility.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

9 years, 10 months ago (2011-02-18 01:43:17 UTC) #2

LGTM. I think this might break some accessibility tests. Looks like the child
node could specify different text than its parent text field. Perhaps we should
prune the child nodes of the editable text fields for the Chrome accessibility
tree?

http://codereview.chromium.org/6469038/diff/1/webkit/glue/webaccessibility.cc
File webkit/glue/webaccessibility.cc (right):

http://codereview.chromium.org/6469038/diff/1/webkit/glue/webaccessibility.cc...
webkit/glue/webaccessibility.cc:383: if (role ==
WebAccessibility::ROLE_EDITABLE_TEXT ||
Nit: Add comment explaining why we shouldn't include children.

Expand Messages | Collapse Messages