Issue 6469037: Implement support for special offset constants in IAccessibleText methods....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6469037: Implement support for special offset constants in IAccessibleText methods.... (Closed)

Created:
9 years, 10 months ago by dmazzoni

Modified:
9 years, 7 months ago

Reviewers:
Chris Guillory

CC:
chromium-reviews, David Tseng

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement support for special offset constants in IAccessibleText methods. This allows JAWS to fully support text editing. BUG=none TEST=manual testing with JAWS screenreader Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75418

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	chrome/browser/accessibility/browser_accessibility_win.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

LGTM one optional nit. http://codereview.chromium.org/6469037/diff/1/chrome/browser/accessibility/browser_accessibility_win.cc File chrome/browser/accessibility/browser_accessibility_win.cc (right): http://codereview.chromium.org/6469037/diff/1/chrome/browser/accessibility/browser_accessibility_win.cc#newcode1226 chrome/browser/accessibility/browser_accessibility_win.cc:1226: DCHECK(direction == 1 || direction ...

9 years, 10 months ago (2011-02-18 01:37:11 UTC) #2

dmazzoni

9 years, 10 months ago (2011-02-18 17:52:37 UTC) #3

http://codereview.chromium.org/6469037/diff/1/chrome/browser/accessibility/br...
File chrome/browser/accessibility/browser_accessibility_win.cc (right):

http://codereview.chromium.org/6469037/diff/1/chrome/browser/accessibility/br...
chrome/browser/accessibility/browser_accessibility_win.cc:1226: DCHECK(direction
== 1 || direction == -1);
On 2011/02/18 01:37:11, Chris Guillory wrote:
> Nit: Can we keep these DCHECKs next to each other.

Sure. I moved the start_offset DCHECK back up to the top and  tested that its
value is either bounded by the string length OR one of the special values.

Expand Messages | Collapse Messages