Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 78113) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,3 +1,3463 @@ |
+2011-02-08 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget |
+ https://bugs.webkit.org/show_bug.cgi?id=52065 |
+ |
+ * dom/Node.cpp: |
+ (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost |
+ boundary of shadow DOM. |
+ (WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow. |
+ |
+2011-02-09 Yael Aharon <yael.aharon@nokia.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Add convenience method toHTMLElement(Node*) |
+ https://bugs.webkit.org/show_bug.cgi?id=54105 |
+ |
+ No new tests since no new functionality introduced. |
+ |
+ * html/HTMLElement.h: |
+ (WebCore::toHTMLElement): |
+ |
+2011-02-09 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Fixed positioned elements at very top or bottom of page remain fixed but clip during rubber-banding |
+ <rdar://problem/7615997> |
+ https://bugs.webkit.org/show_bug.cgi?id=54054 |
+ |
+ Take the overhang into account when calculating position for elements with position: fixed. |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::scrollXForFixedPosition): |
+ (WebCore::ScrollView::scrollYForFixedPosition): |
+ (WebCore::ScrollView::scrollOffsetForFixedPosition): |
+ * platform/ScrollView.h: |
+ * rendering/RenderView.cpp: |
+ (WebCore::RenderView::mapLocalToContainer): |
+ (WebCore::RenderView::mapAbsoluteToLocalPoint): |
+ (WebCore::RenderView::computeRectForRepaint): |
+ |
+2011-02-09 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ Enhance ShadowBlur to tile inset box shadows |
+ https://bugs.webkit.org/show_bug.cgi?id=51567 |
+ |
+ Add a tiling code path to ShadowBlur for rendering inset |
+ box-shadows. |
+ |
+ Test: fast/box-shadow/inset-box-shadows.html |
+ |
+ * platform/graphics/ShadowBlur.cpp: |
+ (WebCore::computeSliceSizesFromRadii): Compute the slice sizes |
+ for the eight-piece shadow template. |
+ (WebCore::ShadowBlur::templateSize): Compute the size of the template, |
+ given the slice sizes. |
+ (WebCore::ShadowBlur::drawRectShadow): Bail early if layerRect is empty |
+ (which probably means we're clipped out). Call templateSize() and use |
+ the result to decide whether to tile. |
+ (WebCore::ShadowBlur::drawInsetShadow): New method for inset shadows. |
+ (WebCore::ShadowBlur::drawRectShadowWithoutTiling): Code moved. |
+ (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): The non-tiling code |
+ path for inset shadows. |
+ (WebCore::ShadowBlur::drawInsetShadowWithTiling): Fill the shadow template |
+ buffer, paint the non-blurred area of the destination, and then call drawLayerPieces() |
+ to paint the eight-piece template image. |
+ (WebCore::ShadowBlur::drawRectShadowWithTiling): Refactored code, now |
+ shares the blurring code via blurAndColorShadowBuffer(), and the tiled template |
+ drawing via drawLayerPieces(). |
+ (WebCore::ShadowBlur::drawLayerPieces): Draw an eight-piece image from the |
+ shadow template to the destination. |
+ (WebCore::ShadowBlur::blurAndColorShadowBuffer): Blur the pixels in the image |
+ buffer, and colorize them using the CompositeSourceIn operation. |
+ * platform/graphics/ShadowBlur.h: |
+ |
+2011-02-09 Jochen Eisinger <jochen@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Disable script elements when a CSP header is present |
+ https://bugs.webkit.org/show_bug.cgi?id=53867 |
+ |
+ Tests: http/tests/security/contentSecurityPolicy/no-policy.html |
+ http/tests/security/contentSecurityPolicy/script-src-in-iframe.html |
+ http/tests/security/contentSecurityPolicy/script-src-none.html |
+ http/tests/security/contentSecurityPolicy/script-src-redirect.html |
+ |
+ * html/parser/HTMLDocumentParser.cpp: |
+ (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc): |
+ * html/parser/HTMLScriptRunner.cpp: |
+ (WebCore::HTMLScriptRunner::requestPendingScript): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::didBeginDocument): |
+ * loader/MainResourceLoader.cpp: |
+ (WebCore::MainResourceLoader::didReceiveResponse): |
+ * page/ContentSecurityPolicy.cpp: |
+ (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): |
+ (WebCore::ContentSecurityPolicy::didReceiveHeader): |
+ (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc): |
+ * page/ContentSecurityPolicy.h: |
+ |
+2011-02-09 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Unreviewed WinCE build fix for r78047. |
+ |
+ ContextMenu.cpp and ContextMenuItem.cpp have a USE(CROSS_PLATFORM_CONTEXT_MENUS), |
+ so they shouldn't cause problems with correct preprocessor defines. |
+ |
+ * CMakeLists.txt: |
+ |
+2011-02-09 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: InspectorAgent should know nothing about InspectorController instance. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=54100 |
+ |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ (WebCore::InspectorAgent::restoreInspectorStateFromCookie): |
+ (WebCore::InspectorAgent::disconnectFrontend): |
+ * inspector/InspectorAgent.h: |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::InspectorController): |
+ (WebCore::InspectorController::disconnectFrontend): |
+ (WebCore::InspectorController::restoreInspectorStateFromCookie): |
+ |
+2011-02-09 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: source frame scroll position is not restored. |
+ https://bugs.webkit.org/show_bug.cgi?id=54101 |
+ |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrame.prototype.show): |
+ (WebInspector.SourceFrame.prototype.hide): |
+ (WebInspector.SourceFrame.prototype.get scrollTop): |
+ (WebInspector.SourceFrame.prototype.set scrollTop): |
+ * inspector/front-end/TextViewer.js: |
+ (WebInspector.TextViewer.prototype.get scrollTop): |
+ (WebInspector.TextViewer.prototype.set scrollTop): |
+ (WebInspector.TextViewer.prototype.get scrollLeft): |
+ (WebInspector.TextViewer.prototype.set scrollLeft): |
+ |
+2011-02-09 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: follow up on InspectorAgent split - |
+ removing unnecessary methods from InspectorController. |
+ https://bugs.webkit.org/show_bug.cgi?id=54093 |
+ |
+ * WebCore.exp.in: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::stopUserInitiatedProfiling): |
+ (WebCore::InspectorAgent::showAndEnableDebugger): |
+ (WebCore::InspectorAgent::enabled): |
+ (WebCore::InspectorAgent::showConsole): |
+ * inspector/InspectorAgent.h: |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::InspectorController): |
+ (WebCore::InspectorController::didClearWindowObjectInWorld): |
+ (WebCore::InspectorController::showConsole): |
+ (WebCore::InspectorController::enabled): |
+ (WebCore::InspectorController::inspectedPage): |
+ * inspector/InspectorController.h: |
+ * inspector/InspectorFrontendClientLocal.cpp: |
+ |
+2011-02-07 Chris Marrin <cmarrin@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing |
+ https://bugs.webkit.org/show_bug.cgi?id=53513 |
+ |
+ The PlatformCAAnimation::create() function which took a pointer to another |
+ PlatformCAAnimation was supposed to make a copy of that passed object. |
+ But it was doing completely the wrong thing on Mac and was leaking an object |
+ to boot. And the notion of copying an object using a static creation function |
+ is wrong in the first place. So I changed it to a member copy() function |
+ which would create a new PlatformCAAnimation which was a copy of 'this' and |
+ return it. I changed the implementation on both Mac and Win to match. |
+ |
+ This problem was not caught by DRT, even there is a specific test for it. |
+ That test just verifies that the higher level logic is working |
+ properly, which it is. There's no practical way to find out if the |
+ layer is currently animating. There is no logic which probes that |
+ deeply into the layer mechanics. |
+ |
+ * platform/graphics/ca/GraphicsLayerCA.cpp: |
+ * platform/graphics/ca/PlatformCAAnimation.h: |
+ * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: |
+ * platform/graphics/ca/win/PlatformCAAnimationWin.cpp: |
+ |
+2011-02-09 Lucas De Marchi <lucas.demarchi@profusion.mobi> |
+ |
+ Unreviewed build fix. |
+ |
+ [EFL] Remove double definition of ContextMenu. |
+ https://bugs.webkit.org/show_bug.cgi?id=50762 |
+ |
+ When building with SHARED_CORE enabled, the symbols of ContextMenu |
+ were both in webkit and webcore. This removes them from webcore and |
+ shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented |
+ in EFL port. |
+ |
+ No new tests because no new functionality. |
+ |
+ * CMakeLists.txt: |
+ |
+2011-02-09 Adam Roben <aroben@apple.com> |
+ |
+ Windows Production build fix |
+ |
+ * WebCore.vcproj/QTMovieWinCommon.vsprops: Link against |
+ WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we |
+ pick up the _debug variant when appropriate. |
+ |
+2011-02-09 Eric Seidel <eric@webkit.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Hostnames should cannonicalize to lowercase (to match every other browser) |
+ https://bugs.webkit.org/show_bug.cgi?id=54084 |
+ |
+ * platform/KURL.cpp: |
+ (WebCore::KURL::parse): |
+ |
+2011-02-09 Peter Varga <pvarga@webkit.org> |
+ |
+ |
+ Reviewed by Gavin Barraclough. |
+ |
+ Replace PCRE with Yarr in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=53496 |
+ |
+ No new tests needed. |
+ |
+ * Android.jscbindings.mk: |
+ * CMakeLists.txt: |
+ * ForwardingHeaders/pcre/pcre.h: Removed. |
+ * ForwardingHeaders/yarr/Yarr.h: Added. |
+ * ForwardingHeaders/yarr/YarrInterpreter.h: Added. |
+ * ForwardingHeaders/yarr/YarrPattern.h: Added. |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.vcproj/copyForwardingHeaders.cmd: |
+ * platform/text/RegularExpression.cpp: |
+ (WebCore::RegularExpression::Private::create): |
+ (WebCore::RegularExpression::Private::Private): |
+ (WebCore::RegularExpression::Private::compile): |
+ (WebCore::RegularExpression::match): |
+ |
+2011-02-09 Gyuyoung Kim <gyuyoung.kim@samsung.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ [EFL] Add dummy functions for HTML5 Video's control UI |
+ https://bugs.webkit.org/show_bug.cgi?id=53906 |
+ |
+ In WebKit EFL, there are no implementations for HTML5 control UI. |
+ First, dummy functions are added. |
+ |
+ * platform/efl/RenderThemeEfl.cpp: |
+ (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): |
+ (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): |
+ (WebCore::RenderThemeEfl::paintMediaFullscreenButton): |
+ (WebCore::RenderThemeEfl::paintMediaMuteButton): |
+ (WebCore::RenderThemeEfl::paintMediaPlayButton): |
+ (WebCore::RenderThemeEfl::paintMediaSeekBackButton): |
+ (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): |
+ (WebCore::RenderThemeEfl::paintMediaSliderTrack): |
+ (WebCore::RenderThemeEfl::paintMediaSliderThumb): |
+ (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): |
+ (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): |
+ (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): |
+ (WebCore::RenderThemeEfl::paintMediaCurrentTime): |
+ * platform/efl/RenderThemeEfl.h: |
+ |
+2011-02-09 Eric Seidel <eric@webkit.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Make WebKit's fragment cannonicalization match other browsers |
+ https://bugs.webkit.org/show_bug.cgi?id=53850 |
+ |
+ This doesn't make us match perfectly, but it brings us closer. |
+ |
+ * platform/KURL.cpp: |
+ (WebCore::appendEscapingBadChars): |
+ (WebCore::escapeAndAppendFragment): |
+ (WebCore::KURL::parse): |
+ |
+2011-02-09 Hans Wennborg <hans@chromium.org> |
+ |
+ Reviewed by Jeremy Orlow. |
+ |
+ IndexedDB: Cursors should skip deleted entries |
+ https://bugs.webkit.org/show_bug.cgi?id=53690 |
+ |
+ Add test to check that the cursor skips deleted entries. |
+ |
+ Test: storage/indexeddb/cursor-skip-deleted.html |
+ |
+ * storage/IDBCursorBackendImpl.cpp: |
+ (WebCore::IDBCursorBackendImpl::currentRowExists): |
+ (WebCore::IDBCursorBackendImpl::continueFunctionInternal): |
+ * storage/IDBCursorBackendImpl.h: |
+ |
+2011-02-08 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: script formatter should not create a worker for each script. |
+ https://bugs.webkit.org/show_bug.cgi?id=54010 |
+ |
+ * inspector/front-end/ScriptFormatter.js: |
+ (WebInspector.ScriptFormatter): |
+ (WebInspector.ScriptFormatter.prototype._formatScript): |
+ (WebInspector.ScriptFormatter.prototype._handleMessage): |
+ (WebInspector.ScriptFormatter.prototype._handleError): |
+ |
+2011-02-08 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: sync uglifyjs parser files. |
+ https://bugs.webkit.org/show_bug.cgi?id=54003 |
+ |
+ * inspector/front-end/UglifyJS/parse-js.js: |
+ * inspector/front-end/UglifyJS/process.js: |
+ |
+2011-02-08 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor |
+ https://bugs.webkit.org/show_bug.cgi?id=53196 |
+ |
+ The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy, |
+ and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy |
+ before making the modification and not removing non-inheritable properties. |
+ |
+ Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large |
+ by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles |
+ and selectionStartCSSPropertyValue. |
+ |
+ Test: editing/style/query-typing-style.html |
+ |
+ * editing/ApplyStyleCommand.cpp: |
+ (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles. |
+ (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that |
+ CSS values from xx-small through -webkit-xxx-large are not accounted. |
+ * editing/ApplyStyleCommand.h: |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue. |
+ (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style. |
+ No longer calls removeNonEditingProperties on the copied typing style so that background-color property |
+ is included when merged into the style. |
+ |
+2011-02-08 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ REGRESSION (r76831): Subframes are printed blank |
+ <rdar://problem/8945867> |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::paintOverhangAreas): |
+ Don't paint overhangs when printing. |
+ |
+2011-02-07 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction) |
+ https://bugs.webkit.org/show_bug.cgi?id=53975 |
+ |
+ The third change in the series of overhauling IndexedDB's event model to match |
+ the spec (at least the version in our heads and bugs). |
+ |
+ Test: storage/indexeddb/transaction-event-propagation.html |
+ |
+ * bindings/v8/V8DOMWrapper.cpp: |
+ (WebCore::V8DOMWrapper::convertEventTargetToV8Object): |
+ * dom/Event.cpp: |
+ (WebCore::Event::isIDBAbortEvent): |
+ (WebCore::Event::isIDBCompleteEvent): |
+ * dom/Event.h: |
+ * dom/EventTarget.cpp: |
+ (WebCore::EventTarget::toIDBDatabase): |
+ * dom/EventTarget.h: |
+ * storage/IDBDatabase.cpp: |
+ (WebCore::IDBDatabase::create): |
+ (WebCore::IDBDatabase::IDBDatabase): |
+ (WebCore::IDBDatabase::scriptExecutionContext): |
+ (WebCore::IDBDatabase::eventTargetData): |
+ (WebCore::IDBDatabase::ensureEventTargetData): |
+ * storage/IDBDatabase.h: |
+ (WebCore::IDBDatabase::toIDBDatabase): |
+ (WebCore::IDBDatabase::refEventTarget): |
+ (WebCore::IDBDatabase::derefEventTarget): |
+ * storage/IDBDatabase.idl: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::onSuccess): |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::backend): |
+ (WebCore::IDBTransaction::db): |
+ (WebCore::IDBTransaction::objectStore): |
+ (WebCore::IDBTransaction::scriptExecutionContext): |
+ (WebCore::IDBTransaction::dispatchEvent): |
+ (WebCore::IDBTransaction::enqueueEvent): |
+ * storage/IDBTransaction.h: |
+ (WebCore::IDBTransaction::dispatchEvent): |
+ |
+2011-02-08 Kenneth Russell <kbr@google.com> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Add cache for GPU-accelerated path processing results |
+ https://bugs.webkit.org/show_bug.cgi?id=45519 |
+ |
+ Adding a cache which holds the results of processing a path into |
+ interior and exterior triangle meshes, according to the path |
+ rendering algorithm from GPU Gems 3. No tests yet; will be tested |
+ in conjunction with later code. |
+ |
+ * platform/graphics/gpu/LoopBlinnPathCache.cpp: Added. |
+ (WebCore::LoopBlinnPathCache::LoopBlinnPathCache): |
+ (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache): |
+ (WebCore::LoopBlinnPathCache::addVertex): |
+ (WebCore::LoopBlinnPathCache::clear): |
+ (WebCore::LoopBlinnPathCache::addInteriorVertex): |
+ (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices): |
+ (WebCore::LoopBlinnPathCache::interiorEdgeVertices): |
+ (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex): |
+ * platform/graphics/gpu/LoopBlinnPathCache.h: Added. |
+ (WebCore::LoopBlinnPathCache::numberOfVertices): |
+ (WebCore::LoopBlinnPathCache::vertices): |
+ (WebCore::LoopBlinnPathCache::texcoords): |
+ (WebCore::LoopBlinnPathCache::numberOfInteriorVertices): |
+ (WebCore::LoopBlinnPathCache::interiorVertices): |
+ |
+2011-02-08 Zhenyao Mo <zmo@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Rename GraphicsContext3D::WebGLEnumType |
+ https://bugs.webkit.org/show_bug.cgi?id=45708 |
+ |
+ * html/canvas/WebGLProgram.cpp: |
+ (WebCore::WebGLProgram::getAttachedShader): |
+ * html/canvas/WebGLProgram.h: |
+ * platform/graphics/GraphicsContext3D.h: |
+ |
+2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r77980. |
+ http://trac.webkit.org/changeset/77980 |
+ https://bugs.webkit.org/show_bug.cgi?id=54043 |
+ |
+ "Crashes on Windows and Linux..." (Requested by leviw on |
+ #webkit). |
+ |
+ * WebCore.exp.in: |
+ * accessibility/AXObjectCache.cpp: |
+ (WebCore::AXObjectCache::visiblePositionForTextMarkerData): |
+ * accessibility/AccessibilityObject.cpp: |
+ (WebCore::startOfStyleRange): |
+ (WebCore::endOfStyleRange): |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::visiblePositionForIndex): |
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
+ (objectAndOffsetUnignored): |
+ * dom/Position.cpp: |
+ (WebCore::Position::upstream): |
+ (WebCore::Position::downstream): |
+ * dom/Range.cpp: |
+ (WebCore::Range::editingStartPosition): |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::canDeleteRange): |
+ * editing/ReplaceSelectionCommand.cpp: |
+ (WebCore::ReplaceSelectionCommand::doApply): |
+ * editing/SelectionController.cpp: |
+ (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): |
+ (WebCore::SelectionController::setSelectedRange): |
+ * editing/TextIterator.cpp: |
+ (WebCore::TextIterator::shouldRepresentNodeOffsetZero): |
+ * editing/TypingCommand.cpp: |
+ (WebCore::TypingCommand::deleteKeyPressed): |
+ * editing/VisiblePosition.cpp: |
+ (WebCore::VisiblePosition::VisiblePosition): |
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): |
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): |
+ (WebCore::VisiblePosition::canonicalPosition): |
+ (WebCore::VisiblePosition::characterAfter): |
+ (WebCore::VisiblePosition::localCaretRect): |
+ (WebCore::makeRange): |
+ (WebCore::startVisiblePosition): |
+ (WebCore::endVisiblePosition): |
+ (WebCore::setStart): |
+ (WebCore::setEnd): |
+ (WebCore::isFirstVisiblePositionInNode): |
+ (WebCore::isLastVisiblePositionInNode): |
+ * editing/VisiblePosition.h: |
+ * editing/htmlediting.cpp: |
+ (WebCore::firstInSpecialElement): |
+ (WebCore::lastInSpecialElement): |
+ (WebCore::visiblePositionBeforeNode): |
+ (WebCore::visiblePositionAfterNode): |
+ * editing/visible_units.cpp: |
+ (WebCore::startPositionForLine): |
+ (WebCore::endPositionForLine): |
+ (WebCore::previousLinePosition): |
+ (WebCore::nextLinePosition): |
+ (WebCore::startOfParagraph): |
+ (WebCore::endOfParagraph): |
+ (WebCore::endOfBlock): |
+ (WebCore::startOfDocument): |
+ (WebCore::endOfDocument): |
+ (WebCore::logicalStartPositionForLine): |
+ (WebCore::logicalEndPositionForLine): |
+ * page/DOMSelection.cpp: |
+ (WebCore::DOMSelection::collapse): |
+ (WebCore::DOMSelection::setBaseAndExtent): |
+ (WebCore::DOMSelection::setPosition): |
+ (WebCore::DOMSelection::extend): |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::handleMousePressEventSingleClick): |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::createVisiblePosition): |
+ * rendering/RenderTextControl.cpp: |
+ (WebCore::RenderTextControl::visiblePositionForIndex): |
+ * svg/SVGTextContentElement.cpp: |
+ (WebCore::SVGTextContentElement::selectSubString): |
+ |
+2011-02-08 Jia Pu <jpu@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ VisibleSelection::setWithoutValidation() should allow caret selection. |
+ https://bugs.webkit.org/show_bug.cgi?id=53943 |
+ |
+ Test: editing/undo/undo-paste-when-caret-is-not-in-range.html |
+ |
+ * editing/VisibleSelection.cpp: |
+ (WebCore::VisibleSelection::setWithoutValidation): |
+ |
+2011-02-08 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [GTK] Remove the last remnants of the Mozilla theme drawing code |
+ https://bugs.webkit.org/show_bug.cgi?id=54035 |
+ |
+ Remove all Mozilla theme drawing code. |
+ |
+ No new tests. This change only removes dead code. |
+ |
+ * GNUmakefile.am: Remove Mozilla files from the source list. |
+ * platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods |
+ and add m_colormap to hold the current colormap of the widgets. |
+ * platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code. |
+ (WebCore::RenderThemeGtk::platformInit): Ditto. |
+ (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. |
+ (WebCore::RenderThemeGtk::gtkContainer): Ditto. |
+ * platform/gtk/ScrollbarThemeGtk2.cpp: Ditto. |
+ * platform/gtk/WidgetRenderingContext.cpp: Ditto. |
+ (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto. |
+ * platform/gtk/WidgetRenderingContext.h: Ditto. |
+ * platform/gtk/gtk2drawing.c: Removed. |
+ * platform/gtk/gtkdrawing.h: Removed. |
+ |
+2011-02-08 Yael Aharon <yael.aharon@nokia.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Crash when logging into gmail.com with frame flattening turned on. |
+ https://bugs.webkit.org/show_bug.cgi?id=52449 |
+ |
+ Frame flattening algorithm requires that layout always starts from the main frame, since layout of |
+ subframes impacts the layout of their parents. |
+ There are places in the code that call view->layout() not on the main frame. |
+ Instead of changing all the callsites, I changed FrameView::layout() |
+ to force layout from the main frame if frame flattening is enabled. |
+ In addition, postLayoutTasks can trigger relayout, so make it use the timer even more. |
+ Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(), |
+ because calling the from layout() leads to a crash in pages that have a selection in an iframe. |
+ |
+ Tests: fast/frames/flattening/iframe-flattening-crash.html |
+ fast/frames/flattening/iframe-flattening-selection-crash.html |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::layout): |
+ (WebCore::FrameView::performPostLayoutTasks): |
+ |
+2011-02-08 Andy Estes <aestes@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ <rdar://problem/8913952> REGRESSION (r76301): 'plaintext-only' must be |
+ a supported contentEditable mode. |
+ https://bugs.webkit.org/show_bug.cgi?id=54041 |
+ |
+ * html/HTMLElement.cpp: |
+ (WebCore::HTMLElement::setContentEditable): Setting the contentEditable |
+ attribute to 'plaintext-only' should not throw an exception. |
+ |
+2011-02-08 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Simon Fraser. |
+ |
+ RenderRubyRun::m_beingDestroyed is redundant |
+ https://bugs.webkit.org/show_bug.cgi?id=54042 |
+ |
+ * rendering/RenderRubyRun.cpp: |
+ (WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed. |
+ (WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed(). |
+ * rendering/RenderRubyRun.h: |
+ |
+2011-02-08 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Stop instantiating legacy editing Positions in VisiblePosition |
+ https://bugs.webkit.org/show_bug.cgi?id=52919 |
+ |
+ Changing VisiblePosition completely away from legacy positions. |
+ |
+ No new tests since this is functionaly equivalent. |
+ |
+ * WebCore.exp.in: Removing the legacy VisiblePosition constructor and |
+ adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions |
+ outside of WebCore, they should be parent anchored. |
+ * accessibility/AXObjectCache.cpp: |
+ (WebCore::AXObjectCache::visiblePositionForTextMarkerData): |
+ * accessibility/AccessibilityObject.cpp: |
+ (WebCore::startOfStyleRange): |
+ (WebCore::endOfStyleRange): |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::visiblePositionForIndex): |
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
+ (objectAndOffsetUnignored): |
+ * dom/Position.cpp: |
+ (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor |
+ (WebCore::Position::downstream): ditto |
+ * dom/Range.cpp: |
+ (WebCore::Range::editingStartPosition): |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::canDeleteRange): |
+ * editing/ReplaceSelectionCommand.cpp: |
+ (WebCore::ReplaceSelectionCommand::doApply): |
+ * editing/SelectionController.cpp: |
+ (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): |
+ (WebCore::SelectionController::setSelectedRange): |
+ * editing/TextIterator.cpp: |
+ (WebCore::TextIterator::shouldRepresentNodeOffsetZero): |
+ * editing/TypingCommand.cpp: |
+ (WebCore::TypingCommand::deleteKeyPressed): |
+ * editing/VisiblePosition.cpp: |
+ (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): |
+ (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): |
+ (WebCore::VisiblePosition::canonicalPosition): |
+ (WebCore::VisiblePosition::characterAfter): |
+ (WebCore::VisiblePosition::localCaretRect): |
+ (WebCore::makeRange): |
+ (WebCore::startVisiblePosition): |
+ (WebCore::endVisiblePosition): |
+ (WebCore::setStart): |
+ (WebCore::setEnd): |
+ (WebCore::isFirstVisiblePositionInNode): |
+ (WebCore::isLastVisiblePositionInNode): |
+ * editing/VisiblePosition.h: |
+ (WebCore::VisiblePosition::VisiblePosition): |
+ * editing/htmlediting.cpp: |
+ (WebCore::firstInSpecialElement): |
+ (WebCore::lastInSpecialElement): |
+ (WebCore::visiblePositionBeforeNode): |
+ (WebCore::visiblePositionAfterNode): |
+ * editing/visible_units.cpp: |
+ (WebCore::startPositionForLine): |
+ (WebCore::endPositionForLine): |
+ (WebCore::previousLinePosition): |
+ (WebCore::nextLinePosition): |
+ (WebCore::startOfParagraph): |
+ (WebCore::endOfParagraph): |
+ (WebCore::endOfBlock): |
+ (WebCore::startOfDocument): |
+ (WebCore::endOfDocument): |
+ (WebCore::logicalStartPositionForLine): |
+ (WebCore::logicalEndPositionForLine): |
+ * page/DOMSelection.cpp: |
+ (WebCore::DOMSelection::collapse): |
+ (WebCore::DOMSelection::setBaseAndExtent): |
+ (WebCore::DOMSelection::setPosition): |
+ (WebCore::DOMSelection::extend): |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::handleMousePressEventSingleClick): |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::createVisiblePosition): |
+ * rendering/RenderTextControl.cpp: |
+ (WebCore::RenderTextControl::visiblePositionForIndex): |
+ * svg/SVGTextContentElement.cpp: |
+ (WebCore::SVGTextContentElement::selectSubString): |
+ |
+2011-02-08 Michael Saboff <msaboff@apple.com> |
+ |
+ JSC::Bindings m_rootObject->isValid() assert fails when running layout tests |
+ https://bugs.webkit.org/show_bug.cgi?id=53716 |
+ |
+ Changed ASSERT to be an if for the case where the RuntimeObject was |
+ GC'ed before RootObject::invalidate is called. In that case there is |
+ no need to remove the RuntimeObject from the RootObject. The isValid() |
+ call will be false in this case, but the RuntimeObject has already |
+ been removed from the RootObject. Added similar defensive code |
+ in RootObject::removeRuntimeObject(). |
+ |
+ * bridge/jsc/BridgeJSC.cpp: |
+ (JSC::Bindings::Instance::willDestroyRuntimeObject): |
+ * bridge/runtime_root.cpp: |
+ (JSC::Bindings::RootObject::removeRuntimeObject): |
+ |
+2011-02-08 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Fix for <rdar://problem/8953365> CrashTracer: 14 |
+ crashes in WebProcess at com.apple.WebCore: |
+ -[ScrollKnobAnimation setCurrentProgress:] + 258 |
+ |
+ This crash seems to happen when the animation is running |
+ and a window is closed. If the ScrollAnimator is destroyed, |
+ delegate calls for the animation can still run, so we have |
+ to make sure we inform the delegates when the ScrollAnimator |
+ is gone, and then we have to null-check it before we do |
+ anything with it. |
+ |
+ Remove scrollbarPainterDelegate() since it's not used anymore. |
+ * platform/mac/ScrollAnimatorMac.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ |
+ Add null-checks for _animator |
+ (-[ScrollbarPartAnimation setCurrentProgress:]): |
+ (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): |
+ (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): |
+ |
+ New function to inform the delegates that the ScrollAnimator |
+ is being destroyed. |
+ (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]): |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ |
+2011-02-08 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Remove orphan code from old parser |
+ https://bugs.webkit.org/show_bug.cgi?id=53984 |
+ |
+ This code appears to be unused. |
+ |
+ * html/HTMLParserErrorCodes.cpp: |
+ * html/HTMLParserErrorCodes.h: |
+ * html/HTMLParserQuirks.h: |
+ * loader/EmptyClients.h: |
+ * page/ChromeClient.h: |
+ |
+2011-02-08 Martin Robinson <mrobinson@igalia.com> |
+ |
+ Reviewed by Gustavo Noronha Silva. |
+ |
+ [GTK] Move scrollbar rendering out of gtk2drawing.c |
+ https://bugs.webkit.org/show_bug.cgi?id=52836 |
+ |
+ Replace gtk2drawing.c scrollbar rendering with our own version. This |
+ is the last use of the Mozilla theme drawing code. |
+ |
+ No new tests. This should not change the rendering of the default |
+ theme. |
+ |
+ * platform/gtk/GtkVersioning.h: Add some more backported allocation setters. |
+ * platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets. |
+ * platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets. |
+ (WebCore::RenderThemeGtk::platformInit): Ditto. |
+ (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto. |
+ (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto. |
+ * platform/gtk/ScrollbarThemeGtk.cpp: |
+ (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled |
+ window background if we are repainting a button or the thumb. In that |
+ case also repaint the track rect. |
+ * platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext. |
+ (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto. |
+ (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. |
+ (WebCore::getWidgetForScrollbar): Ditto. |
+ (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. |
+ (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. |
+ (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. |
+ (WebCore::ScrollbarThemeGtk::paintButton): Ditto. |
+ * platform/gtk/WidgetRenderingContext.cpp: Ditto. |
+ (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which |
+ also adjusts a widget allocation according to the paint rect. This is |
+ necessary to properly draw scrollbar buttons. |
+ * platform/gtk/WidgetRenderingContext.h: Ditto. |
+ |
+2011-02-08 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Inset shadow with large offset renders incorrectly |
+ https://bugs.webkit.org/show_bug.cgi?id=53882 |
+ |
+ Fix an issue with inset shadows, when the shadow offset |
+ was larger than the box size. In this case we'd fail to |
+ fill the box with the shadow color. |
+ |
+ Test: fast/box-shadow/inset-shadow-large-offset.html |
+ |
+ * rendering/RenderBoxModelObject.cpp: |
+ (WebCore::areaCastingShadowInHole): Return a rect that covers the area |
+ which contributes to the inset shadow. |
+ |
+ (WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole() |
+ to compute the outerRect. |
+ |
+2011-02-08 Zhenyao Mo <zmo@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER |
+ https://bugs.webkit.org/show_bug.cgi?id=54017 |
+ |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::drawElements): |
+ |
+2011-01-28 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId. |
+ https://bugs.webkit.org/show_bug.cgi?id=53190 |
+ |
+ This is the second part of refactoring the HTMLMediaElement to use new |
+ shadow DOM. The changes are mainly mechanical, except for needing to |
+ add a new method to RenderTheme, which indicates whether or not status |
+ display is being used by it. Previously, we relied on existence of a cached |
+ pseudo style. |
+ |
+ Refactoring, covered by existing tests. |
+ |
+ * css/CSSSelector.cpp: |
+ (WebCore::CSSSelector::pseudoId): Removed now-unused enum values. |
+ (WebCore::nameToPseudoTypeMap): Ditto. |
+ (WebCore::CSSSelector::extractPseudoType): Ditto. |
+ * css/CSSSelector.h: Ditto. |
+ * html/shadow/MediaControls.cpp: |
+ (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement. |
+ (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added |
+ MediaControlCurrentTimeDisplayElement. |
+ (WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added |
+ MediaControlTimeRemainingDisplayElement. |
+ * rendering/MediaControlElements.cpp: |
+ (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the |
+ standard style resolution. |
+ (WebCore::MediaControlShadowRootElement::shadowPseudoId): Added. |
+ (WebCore::MediaControlElement::MediaControlElement): Removed the switch statement |
+ that is no longer necessary. |
+ (WebCore::MediaControlElement::styleForElement): Changed to use the standard |
+ style resolution. |
+ (WebCore::MediaControlPanelElement::MediaControlPanelElement): Added. |
+ (WebCore::MediaControlPanelElement::create): Added. |
+ (WebCore::MediaControlPanelElement::displayType): Added. |
+ (WebCore::MediaControlPanelElement::shadowPseudoId): Added. |
+ (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): |
+ Removed PseudoId constructor arg. |
+ (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): |
+ Changed to use the newly-plumbed usesMediaControlStatusDisplay helper. |
+ (WebCore::MediaControlTimelineContainerElement::displayType): Added. |
+ (WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added. |
+ (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): |
+ Removed PseudoId constructor arg. |
+ (WebCore::MediaControlVolumeSliderContainerElement::displayType): Added. |
+ (WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added. |
+ (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): |
+ Removed PseudoId constructor arg. |
+ (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to |
+ use the newly-plumbed usesMediaControlStatusDisplay helper. |
+ (WebCore::MediaControlStatusDisplayElement::displayType): Added. |
+ (WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added. |
+ (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): |
+ Removed PseudoId constructor arg. |
+ (WebCore::MediaControlTimeRemainingDisplayElement::create): Added. |
+ (WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added. |
+ (WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added. |
+ (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added. |
+ (WebCore::MediaControlCurrentTimeDisplayElement::create): Added. |
+ (WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added. |
+ (WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added. |
+ (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added. |
+ * rendering/MediaControlElements.h: Added/changed defs accordingly. |
+ * rendering/RenderTheme.h: |
+ (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added. |
+ * rendering/RenderThemeMac.h: Added def. |
+ * rendering/RenderThemeMac.mm: |
+ (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added. |
+ * rendering/style/RenderStyleConstants.h: Removed now-unused enum values. |
+ |
+2011-02-08 Xiaomei Ji <xji@chromium.org> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Fix pop-up button text not rendered correctly according to its direction |
+ in <option>. |
+ https://bugs.webkit.org/show_bug.cgi?id=53642 |
+ |
+ In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi |
+ changes, set it needs layout. |
+ |
+ Test: fast/text/international/pop-up-button-text-alignment-and-direction.html |
+ |
+ * rendering/RenderMenuList.cpp: |
+ (WebCore::RenderMenuList::adjustInnerStyle): |
+ |
+2011-02-08 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Unreviewed build fix for Qt-minimal. |
+ |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::hasFrontend): |
+ |
+2011-02-02 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53169 |
+ |
+ All the Inspector API for WebCore has two parts. |
+ The first one is InspectorInstrumentation for WebCore. |
+ The second is InspectorController for WebKit. |
+ InspectorAgent was produced by renaming original InspectorController. |
+ This patch extracts WebKit related methods from InspectorAgent to InspectorController. |
+ |
+ * WebCore.exp.in: |
+ * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: |
+ * html/HTMLDocument.cpp: |
+ (WebCore::HTMLDocument::createParser): |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::InspectorAgent): |
+ (WebCore::InspectorAgent::~InspectorAgent): |
+ (WebCore::InspectorAgent::restoreInspectorStateFromCookie): |
+ (WebCore::InspectorAgent::inspect): |
+ (WebCore::InspectorAgent::handleMousePress): |
+ (WebCore::InspectorAgent::didClearWindowObjectInWorld): |
+ (WebCore::InspectorAgent::setFrontend): |
+ (WebCore::InspectorAgent::disconnectFrontend): |
+ (WebCore::InspectorAgent::resourceAgent): |
+ (WebCore::InspectorAgent::createFrontendLifetimeAgents): |
+ (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): |
+ (WebCore::InspectorAgent::populateScriptObjects): |
+ (WebCore::InspectorAgent::pushDataCollectedOffline): |
+ (WebCore::InspectorAgent::restoreProfiler): |
+ (WebCore::InspectorAgent::startTimelineProfiler): |
+ (WebCore::PostWorkerNotificationToFrontendTask::performTask): |
+ (WebCore::InspectorAgent::didOpenDatabase): |
+ (WebCore::InspectorAgent::didUseDOMStorage): |
+ (WebCore::InspectorAgent::showAndEnableDebugger): |
+ (WebCore::InspectorAgent::enableDebugger): |
+ (WebCore::InspectorAgent::enabled): |
+ * inspector/InspectorAgent.h: |
+ (WebCore::InspectorAgent::frontend): |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::InspectorController): |
+ (WebCore::InspectorController::~InspectorController): |
+ (WebCore::InspectorController::setInspectorFrontendClient): |
+ (WebCore::InspectorController::hasInspectorFrontendClient): |
+ (WebCore::InspectorController::didClearWindowObjectInWorld): |
+ (WebCore::InspectorController::startTimelineProfiler): |
+ (WebCore::InspectorController::stopTimelineProfiler): |
+ (WebCore::InspectorController::connectFrontend): |
+ (WebCore::InspectorController::disconnectFrontend): |
+ (WebCore::InspectorController::disconnectFrontendImpl): |
+ (WebCore::InspectorController::show): |
+ (WebCore::InspectorController::close): |
+ (WebCore::InspectorController::restoreInspectorStateFromCookie): |
+ (WebCore::InspectorController::evaluateForTestInFrontend): |
+ (WebCore::InspectorController::drawNodeHighlight): |
+ (WebCore::InspectorController::inspect): |
+ (WebCore::InspectorController::enabled): |
+ (WebCore::InspectorController::showPanel): |
+ (WebCore::InspectorController::frontendLoaded): |
+ (WebCore::InspectorController::timelineProfilerEnabled): |
+ (WebCore::InspectorController::enableProfiler): |
+ (WebCore::InspectorController::disableProfiler): |
+ (WebCore::InspectorController::profilerEnabled): |
+ (WebCore::InspectorController::debuggerEnabled): |
+ (WebCore::InspectorController::showAndEnableDebugger): |
+ (WebCore::InspectorController::disableDebugger): |
+ (WebCore::InspectorController::startUserInitiatedProfiling): |
+ (WebCore::InspectorController::stopUserInitiatedProfiling): |
+ (WebCore::InspectorController::isRecordingUserInitiatedProfile): |
+ (WebCore::InspectorController::setInspectorExtensionAPI): |
+ (WebCore::InspectorController::resume): |
+ (WebCore::InspectorController::hideHighlight): |
+ (WebCore::InspectorController::dispatchMessageFromFrontend): |
+ * inspector/InspectorController.h: |
+ (WebCore::InspectorController::inspectorClient): |
+ (WebCore::InspectorController::inspectedPage): |
+ (WebCore::InspectorController::hasFrontend): |
+ * inspector/InspectorFrontendClientLocal.cpp: |
+ (WebCore::InspectorFrontendClientLocal::sendMessageToBackend): |
+ * inspector/InspectorFrontendHost.cpp: |
+ (WebCore::InspectorFrontendHost::setExtensionAPI): |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): |
+ (WebCore::InspectorInstrumentation::profilerEnabledImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::hasFrontend): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): |
+ |
+2011-02-08 George Wright <gwright@rim.com> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53949 |
+ |
+ Ensure that we pack the colour byte order correctly for Skia using |
+ Skia's SkPackARGB32 function. |
+ |
+ * platform/image-decoders/ImageDecoder.h: |
+ (WebCore::ImageFrame::setRGBA): |
+ |
+2011-02-08 George Wright <gwright@rim.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53951 |
+ |
+ Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead |
+ pass the full image dimensions. |
+ |
+ * platform/graphics/GraphicsContext.cpp: |
+ (WebCore::GraphicsContext::drawImageBuffer): |
+ |
+2011-02-08 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ [WIN] Add missing includes and forward declarations for DownloadBundle |
+ https://bugs.webkit.org/show_bug.cgi?id=53881 |
+ |
+ * platform/network/cf/DownloadBundle.h: |
+ * platform/network/win/DownloadBundleWin.cpp: |
+ (WebCore::DownloadBundle::appendResumeData): |
+ |
+2011-02-08 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ [WIN] Add missing include in WKCAImageQueue |
+ https://bugs.webkit.org/show_bug.cgi?id=53890 |
+ |
+ * platform/graphics/win/WKCAImageQueue.cpp: |
+ |
+2011-02-08 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ [WIN] Add missing includes and forward declarations for CFNetwork |
+ https://bugs.webkit.org/show_bug.cgi?id=53883 |
+ |
+ * platform/network/cf/DNSCFNet.cpp: |
+ * platform/network/cf/LoaderRunLoopCF.cpp: |
+ * platform/network/cf/LoaderRunLoopCF.h: |
+ * platform/network/cf/ProxyServerCFNet.cpp: |
+ * platform/network/cf/SocketStreamHandle.h: |
+ * platform/network/cf/SocketStreamHandleCFNet.cpp: |
+ |
+2011-02-08 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Unreviewed WinCE build fix for r77870. |
+ |
+ * platform/DragImage.cpp: Enable createDragImageForLink for WinCE. |
+ |
+2011-02-08 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: open network resource url in new tab upon double click. |
+ https://bugs.webkit.org/show_bug.cgi?id=53930 |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkDataGridNode.prototype.createCells): |
+ (WebInspector.NetworkDataGridNode.prototype._openInNewTab): |
+ |
+2011-02-08 Yonathan Randolph <yonathan@gmail.com> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: $x: any node should work in optional context parameter. |
+ https://bugs.webkit.org/show_bug.cgi?id=50138 |
+ |
+ * inspector/InjectedScriptSource.js: |
+ |
+2011-02-08 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Unreviewed WinCE build fix for r77870. |
+ |
+ Remove the global namespace prefix from GlobalLock/GlobalUnlock. |
+ |
+ * platform/win/ClipboardUtilitiesWin.cpp: |
+ |
+2011-02-08 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Not reviewed: re-apply r77924. |
+ |
+ Test: inspector/console-api-on-call-frame.html |
+ |
+ * inspector/InjectedScriptSource.js: |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): |
+ |
+2011-02-08 Andreas Kling <kling@webkit.org> |
+ |
+ Reviewed by Tor Arne Vestbø. |
+ |
+ REGRESSION(r77312): Unbreak TiledBackingStore. |
+ |
+ Due to an off-by-one error, we were no longer rendering the |
+ rightmost column and bottom row of tiles. |
+ |
+ Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache(). |
+ |
+ * platform/graphics/TiledBackingStore.cpp: |
+ (WebCore::TiledBackingStore::invalidate): |
+ (WebCore::TiledBackingStore::updateTileBuffers): |
+ (WebCore::TiledBackingStore::paint): |
+ (WebCore::TiledBackingStore::createTiles): |
+ |
+2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r77924. |
+ http://trac.webkit.org/changeset/77924 |
+ https://bugs.webkit.org/show_bug.cgi?id=53997 |
+ |
+ Breaks inspector tests. (Requested by pfeldman on #webkit). |
+ |
+ * inspector/InjectedScriptSource.js: |
+ (.): |
+ (): |
+ |
+2011-02-08 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent |
+ https://bugs.webkit.org/show_bug.cgi?id=53789 |
+ - perform UserAgent override via InspectorInstrumentation |
+ - move adding extra request headers to InspectorResourceAgent |
+ - simplified things in InspectorState |
+ |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::disconnectFrontend): |
+ (WebCore::InspectorAgent::applyUserAgentOverride): |
+ * inspector/InspectorAgent.h: |
+ * inspector/InspectorInstrumentation.cpp: |
+ (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): |
+ (WebCore::InspectorInstrumentation::willSendRequestImpl): |
+ * inspector/InspectorInstrumentation.h: |
+ (WebCore::InspectorInstrumentation::applyUserAgentOverride): |
+ * inspector/InspectorResourceAgent.cpp: |
+ (WebCore::InspectorResourceAgent::setExtraHeaders): |
+ (WebCore::InspectorResourceAgent::willSendRequest): |
+ * inspector/InspectorResourceAgent.h: |
+ * inspector/InspectorState.cpp: |
+ (WebCore::InspectorState::InspectorState): |
+ (WebCore::InspectorState::restoreFromInspectorCookie): |
+ (WebCore::InspectorState::updateCookie): |
+ (WebCore::InspectorState::setValue): |
+ (WebCore::InspectorState::getBoolean): |
+ (WebCore::InspectorState::getString): |
+ (WebCore::InspectorState::getLong): |
+ (WebCore::InspectorState::getObject): |
+ * inspector/InspectorState.h: |
+ (WebCore::InspectorState::setObject): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::userAgent): |
+ |
+2011-02-08 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: do not hide scope variables with command line api. |
+ https://bugs.webkit.org/show_bug.cgi?id=53497 |
+ |
+ Test: inspector/console-api-on-call-frame.html |
+ |
+ * inspector/InjectedScriptSource.js: |
+ |
+2011-02-08 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R. |
+ https://bugs.webkit.org/show_bug.cgi?id=53914 |
+ |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorAgent.cpp: |
+ (WebCore::InspectorAgent::reloadPage): |
+ * inspector/InspectorAgent.h: |
+ * inspector/front-end/AuditsPanel.js: |
+ (WebInspector.AuditsPanel.prototype._reloadResources): |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._onReload): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.documentKeyDown): |
+ |
+2011-02-08 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Cameron Zwarich. |
+ |
+ Skip over sibling selectors when collecting descendant selector hashes |
+ https://bugs.webkit.org/show_bug.cgi?id=53987 |
+ |
+ Skip instead of bailing out. This will allow optimizing some sibling selector cases. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::RuleData::RuleData): |
+ (WebCore::RuleData::collectIdentifierHashes): |
+ (WebCore::RuleData::collectDescendantSelectorIdentifierHashes): |
+ * css/CSSStyleSelector.h: |
+ |
+2011-02-07 Cris Neckar <cdn@chromium.org> |
+ |
+ Reviewed by Jian Li. |
+ |
+ Fix null deref in DOMURL |
+ https://bugs.webkit.org/show_bug.cgi?id=53811 |
+ |
+ Test: fast/files/domurl-script-execution-context-crash.html |
+ |
+ * html/DOMURL.cpp: |
+ (WebCore::DOMURL::DOMURL): |
+ |
+2011-02-07 Mark Rowe <mrowe@apple.com> |
+ |
+ Fix the 32-bit build. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters. |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto. |
+ |
+2011-02-07 Xiyuan Xia <xiyuan@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [Chromium] Select popup box does not align with select button when appearance is not "menulist". |
+ https://bugs.webkit.org/show_bug.cgi?id=53942 |
+ |
+ Added manual test select_webkit_appearance_off_popup_alignment.html. |
+ |
+ * manual-tests/select_webkit_appearance_off_popup_alignment.html: Added. |
+ * platform/chromium/PopupMenuChromium.cpp: |
+ (WebCore::PopupListBox::layout): |
+ |
+2011-02-07 Aparna Nandyal <aparna.nand@wipro.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] - Context menu needs "Copy" as well when the selected text is a link. |
+ https://bugs.webkit.org/show_bug.cgi?id=40983 |
+ |
+ Added copy option for Qt platform if selection is a link. |
+ Added a test in tst_qwebpage.cpp. |
+ |
+ * page/ContextMenuController.cpp: |
+ (WebCore::ContextMenuController::populate): |
+ |
+2011-02-07 Mike Reed <reed@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend |
+ when drawing <canvas>. Disabled by default. |
+ |
+ No new tests. existing canvas layouttests apply |
+ |
+ * platform/graphics/chromium/DrawingBufferChromium.cpp: |
+ (WebCore::DrawingBuffer::publishToPlatformLayer): |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::GetGlobalGrContext): |
+ (WebCore::PlatformContextSkia::isPrinting): |
+ (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): |
+ (WebCore::PlatformContextSkia::syncSoftwareCanvas): |
+ |
+2011-02-07 Jay Civelli <jcivelli@chromium.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ Removing unused code from PopupMenuChromium. |
+ https://bugs.webkit.org/show_bug.cgi?id=53866 |
+ |
+ * platform/chromium/PopupMenuChromium.cpp: |
+ (WebCore::PopupListBox::layout): |
+ (WebCore::PopupMenuChromium::show): |
+ * platform/chromium/PopupMenuChromium.h: |
+ |
+2011-02-07 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ HTMLOutputElement::childrenChanged() should call its base class childrenChanged() |
+ https://bugs.webkit.org/show_bug.cgi?id=53791 |
+ |
+ Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged(). |
+ |
+ Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html |
+ |
+ * html/HTMLOutputElement.cpp: |
+ (WebCore::HTMLOutputElement::childrenChanged): Calls super class's |
+ childrenChanged(). |
+ |
+2011-02-07 Benjamin Poulain <ikipou@gmail.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] cookiesEnabled could create the cookieJar on the wrong thread. |
+ https://bugs.webkit.org/show_bug.cgi?id=52289 |
+ |
+ Use the QtNAMThreadSafeProxy to make sure the cookie jar is created |
+ in the same thread as the QNetworkAccessManager. |
+ |
+ * platform/network/qt/QtNAMThreadSafeProxy.cpp: |
+ (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): |
+ (WebCore::QtNAMThreadSafeProxy::hasCookieJar): |
+ * platform/network/qt/QtNAMThreadSafeProxy.h: |
+ * platform/qt/CookieJarQt.cpp: |
+ (WebCore::cookiesEnabled): |
+ |
+2011-02-07 Alexey Marinichev <amarinichev@chromium.org> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Hook up WebGraphicsContext3D::setContextLostCallback. |
+ https://bugs.webkit.org/show_bug.cgi?id=53722 |
+ |
+ Test: fast/canvas/webgl/context-lost.html, comment out the line with |
+ extension.loseContext() and kill the GPU process "Lose context" |
+ message shows up. |
+ |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): |
+ (WebCore::WebGLRenderingContextLostCallback::onContextLost): |
+ (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback): |
+ (WebCore::WebGLRenderingContext::initializeNewContext): |
+ (WebCore::WebGLRenderingContext::~WebGLRenderingContext): |
+ * platform/graphics/GraphicsContext3D.h: |
+ (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback): |
+ * platform/graphics/mac/GraphicsContext3DMac.mm: |
+ (WebCore::GraphicsContext3D::setContextLostCallback): stub |
+ * platform/graphics/qt/GraphicsContext3DQt.cpp: |
+ (WebCore::GraphicsContext3D::setContextLostCallback): stub |
+ |
+2011-02-07 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Add missing PaintInfo include in RenderThemeWin.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=53885 |
+ |
+ * rendering/RenderThemeWin.cpp: |
+ |
+2011-02-07 Qi Zhang <qi.2.zhang@nokia.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl |
+ https://bugs.webkit.org/show_bug.cgi?id=52974 |
+ |
+ Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific. |
+ |
+ * page/ContextMenuController.cpp: |
+ (WebCore::ContextMenuController::contextMenuItemSelected): |
+ (WebCore::ContextMenuController::populate): |
+ (WebCore::ContextMenuController::checkOrEnableIfNeeded): |
+ * platform/ContextMenuItem.h: |
+ * platform/LocalizationStrategy.h: |
+ * platform/LocalizedStrings.cpp: |
+ (WebCore::contextMenuItemTagCopyImageUrlToClipboard): |
+ * platform/LocalizedStrings.h: |
+ |
+2011-02-07 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements |
+ https://bugs.webkit.org/show_bug.cgi?id=53970 |
+ |
+ Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form() |
+ return the right value. |
+ |
+ Test: fast/dom/HTMLObjectElement/form/nested-form-element.html |
+ |
+ * html/HTMLObjectElement.cpp: |
+ (WebCore::HTMLObjectElement::virtualForm): Added. |
+ * html/HTMLObjectElement.h: Added virtualForm(). |
+ |
+2011-02-07 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Unreviewed Leopard build fix. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion. |
+ * platform/mac/DragImageMac.mm: |
+ (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat. |
+ |
+2011-02-07 Enrica Casucci <enrica@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874 |
+ |
+ When moving code from WebKit to WebCore we needed to move some additional |
+ functions previously in NSStringExtras. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/mac/DragImageMac.mm: |
+ (WebCore::fontFromNSFont): |
+ (WebCore::canUseFastRenderer): |
+ (WebCore::widthWithFont): |
+ (WebCore::webkit_CGCeiling): |
+ (WebCore::drawAtPoint): |
+ (WebCore::drawDoubledAtPoint): |
+ (WebCore::createDragImageForLink): |
+ |
+2011-02-07 Lucas Forschler <lforschler@apple.com> |
+ |
+ Reviewed by Geoff Garen. |
+ |
+ Tr #2, Fix the Leopard 32bit debug build. |
+ |
+ No new tests required. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * accessibility/AccessibilityAllInOne.cpp: |
+ |
+2011-02-07 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Fix for <rdar://problem/8946961> Fix repaint problems |
+ with WKScrollbarPainter scrollers while resizing the window |
+ |
+ Remove setPainterForPainterController() and |
+ removePainterFromPainterController() since they aren't |
+ used anymore. |
+ * platform/mac/ScrollAnimatorMac.h: |
+ |
+ Return early if they alpha hasn't changed. |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ |
+ If we're in a live resize, restore alpha to 1. |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ |
+2011-02-07 Beth Dakin <bdakin@apple.com> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=53950 |
+ USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in |
+ Platform.h instead |
+ |
+ Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather |
+ than the silly, old in-file #define. |
+ |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (+[ScrollbarPrefsObserver appearancePrefsChanged:]): |
+ (WebCore::updateArrowPlacement): |
+ (WebCore::ScrollbarThemeMac::registerScrollbar): |
+ (WebCore::ScrollbarThemeMac::scrollbarThickness): |
+ (WebCore::ScrollbarThemeMac::usesOverlayScrollbars): |
+ (WebCore::ScrollbarThemeMac::hasThumb): |
+ (WebCore::ScrollbarThemeMac::minimumThumbLength): |
+ (WebCore::ScrollbarThemeMac::paint): |
+ |
+2011-02-07 Enrica Casucci <enrica@apple.com> |
+ |
+ Reviewed Adam Roben and Darin Adler. |
+ |
+ WebKit2: drag and drop support on Windows. |
+ https://bugs.webkit.org/show_bug.cgi?id=52775 |
+ <rdar://problem/8514409> |
+ |
+ * loader/EmptyClients.h: Removed createDragImageFromLink. |
+ * page/DragClient.h: Ditto. |
+ * page/DragController.cpp: |
+ (WebCore::DragController::startDrag): changed call to createDragImageFromLink. |
+ * platform/DragImage.h: |
+ * platform/mac/DragImageMac.mm: |
+ (WebCore::createDragImageForLink): Moved from DragClient. |
+ * platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions |
+ to de-serialize the drag data from the map into an IDataObject. |
+ (WebCore::getWebLocData): |
+ (WebCore::texthtmlFormat): |
+ (WebCore::createGlobalData): |
+ (WebCore::getFullCFHTML): |
+ (WebCore::urlWFormat): |
+ (WebCore::urlFormat): |
+ (WebCore::filenameWFormat): |
+ (WebCore::filenameFormat): |
+ (WebCore::htmlFormat): |
+ (WebCore::smartPasteFormat): |
+ (WebCore::getURL): |
+ (WebCore::getPlainText): |
+ (WebCore::getTextHTML): |
+ (WebCore::ClipboardDataItem::ClipboardDataItem): |
+ (WebCore::getStringData): |
+ (WebCore::getUtf8Data): |
+ (WebCore::getCFData): |
+ (WebCore::setUCharData): |
+ (WebCore::setCharData): |
+ (WebCore::setCFData): |
+ (WebCore::getClipboardMap): |
+ (WebCore::getClipboardData): |
+ (WebCore::setClipboardData): |
+ * platform/win/ClipboardUtilitiesWin.h: |
+ * platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient |
+ to a platform specific file in WebCore. It makes a lot more sense here, since |
+ the drag image is always created in WebCore for all the other content types |
+ except for links. |
+ (WebCore::dragLabelFont): |
+ (WebCore::createDragImageForLink): |
+ * platform/win/WCDataObject.cpp: Added new way to |
+ construct a WCDataObject from a DragDataMap. |
+ (WebCore::WCDataObject::createInstance): |
+ (WebCore::WCDataObject::clearData): |
+ * platform/win/WCDataObject.h: |
+ |
+2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r77848. |
+ http://trac.webkit.org/changeset/77848 |
+ https://bugs.webkit.org/show_bug.cgi?id=53963 |
+ |
+ caused 6 test failures (Requested by othermaciej on #webkit). |
+ |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): |
+ |
+2011-02-04 Kenneth Russell <kbr@google.com> |
+ |
+ Reviewed by James Robinson. |
+ |
+ Add shaders for GPU accelerated path rendering |
+ https://bugs.webkit.org/show_bug.cgi?id=45520 |
+ |
+ Refactored SolidFillShader and TexShader to call new |
+ generateVertex() and generateFragment() methods on base Shader |
+ class, and added support for the Loop/Blinn shaders. Refactored |
+ Loop/Blinn shader classes to derive from Shader. |
+ |
+ Tested these changes with several of the IE9 Testdrive demos with |
+ accelerated 2D canvas enabled, as well as a full layout test run |
+ with --platform chromium-gpu. |
+ |
+ * platform/graphics/gpu/LoopBlinnShader.cpp: Added. |
+ (WebCore::LoopBlinnShader::LoopBlinnShader): |
+ (WebCore::LoopBlinnShader::use): |
+ * platform/graphics/gpu/LoopBlinnShader.h: Added. |
+ * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added. |
+ (WebCore::LoopBlinnSolidFillShader::create): |
+ (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader): |
+ (WebCore::LoopBlinnSolidFillShader::use): |
+ * platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added. |
+ * platform/graphics/gpu/Shader.cpp: |
+ (WebCore::Shader::affineTo4x4): |
+ (WebCore::Shader::loadShader): |
+ (WebCore::Shader::loadProgram): |
+ (WebCore::Shader::generateVertex): |
+ (WebCore::Shader::generateFragment): |
+ * platform/graphics/gpu/Shader.h: |
+ * platform/graphics/gpu/SolidFillShader.cpp: |
+ (WebCore::SolidFillShader::create): |
+ * platform/graphics/gpu/TexShader.cpp: |
+ (WebCore::TexShader::TexShader): |
+ (WebCore::TexShader::create): |
+ |
+2011-02-07 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ <rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg) |
+ https://bugs.webkit.org/show_bug.cgi?id=53480 |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/graphics/mac/ComplexTextController.cpp: |
+ (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an |
+ offset into m_characters, not into the run’s characters. |
+ * platform/graphics/mac/ComplexTextControllerATSUI.cpp: |
+ (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto. |
+ |
+2011-02-07 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Add bundle API to get the background color of a frame |
+ <rdar://problem/8962670> |
+ https://bugs.webkit.org/show_bug.cgi?id=53952 |
+ |
+ * WebCore.exp.in: Add export. |
+ |
+2011-02-07 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Assertion failure in ~JSGlobalObject when loading apple.com HTML5 |
+ transitions demo page |
+ https://bugs.webkit.org/show_bug.cgi?id=53853 |
+ |
+ This was a long-standing bookkeeping bug uncovered by some heap refactoring. |
+ |
+ * html/HTMLCanvasElement.cpp: |
+ (WebCore::HTMLCanvasElement::createImageBuffer): |
+ * html/HTMLImageLoader.cpp: |
+ (WebCore::HTMLImageLoader::notifyFinished): |
+ * xml/XMLHttpRequest.cpp: |
+ (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before |
+ reporting extra cost to the JavaScriptCore heap, since all use of |
+ JavaScriptCore is supposed to be guarded by JSLock. |
+ |
+2011-02-07 Jian Li <jianli@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug |
+ bots |
+ https://bugs.webkit.org/show_bug.cgi?id=53104 |
+ |
+ Covered by the existing tests. |
+ |
+ * fileapi/FileStreamProxy.cpp: |
+ (WebCore::FileStreamProxy::startOnFileThread): |
+ * platform/network/BlobRegistryImpl.cpp: |
+ (WebCore::BlobRegistryImpl::createResourceHandle): |
+ * platform/network/BlobResourceHandle.cpp: |
+ (WebCore::BlobResourceHandle::BlobResourceHandle): |
+ (WebCore::BlobResourceHandle::cancel): |
+ (WebCore::delayedStartBlobResourceHandle): |
+ (WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive |
+ till the delay function is called. |
+ (WebCore::BlobResourceHandle::doStart): |
+ (WebCore::doNotifyFinish): |
+ (WebCore::BlobResourceHandle::notifyFinish): Notify the client via the |
+ standalone function to prevent the handle from being disposed immediately |
+ by the client which will make the calls in the stack that're still bound |
+ to the handle suffer. |
+ * platform/network/BlobResourceHandle.h: |
+ * platform/network/ResourceHandle.h: Change cancel() to virtual so that |
+ BlobResourceHandle::cancel will be called when we abort a FileReader. |
+ |
+2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r77845. |
+ http://trac.webkit.org/changeset/77845 |
+ https://bugs.webkit.org/show_bug.cgi?id=53946 |
+ |
+ build failure (Requested by lforschler_ on #webkit). |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * accessibility/AccessibilityAllInOne.cpp: |
+ |
+2011-02-07 Darin Adler <darin@apple.com> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53939 |
+ fast/css/text-overflow-ellipsis.html failure after r77818/77819 |
+ |
+ * platform/text/TextCodecICU.cpp: |
+ (WebCore::TextCodecICU::registerExtendedEncodingNames): |
+ Add back the "utf8" synonym for "UTF-8". |
+ |
+2011-02-07 David Hyatt <hyatt@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Remove an unnecessary extra computeLogicalWidth() from line layout. |
+ |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): |
+ |
+2011-02-07 Lucas Forschler <lforschler@apple.com> |
+ |
+ Reviewed by Geoffrey Garen. |
+ |
+ Fix Leopard Intel Debug Build. |
+ <rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681) |
+ This could potentially break windows, since I had to change #include <filename> to #include "filename" |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * accessibility/AccessibilityAllInOne.cpp: |
+ |
+2011-02-07 Sam Weinig <sam@webkit.org> |
+ |
+ Fix build. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar): |
+ |
+2011-02-07 Sam Weinig <sam@webkit.org> |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ Add mechanism to inform the ScrollAnimator when Scrollbars are added |
+ and removed. |
+ |
+ * platform/ScrollAnimator.h: |
+ (WebCore::ScrollAnimator::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimator::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimator::didAddHorizontalScrollbar): |
+ (WebCore::ScrollAnimator::willRemoveHorizontalScrollbar): |
+ Make virtual to allow platform specific overrides. |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::setHasHorizontalScrollbar): |
+ (WebCore::ScrollView::setHasVerticalScrollbar): |
+ Call new ScrollableArea functions. |
+ |
+ * platform/ScrollableArea.cpp: |
+ (WebCore::ScrollableArea::didAddVerticalScrollbar): |
+ (WebCore::ScrollableArea::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollableArea::didAddHorizontalScrollbar): |
+ (WebCore::ScrollableArea::willRemoveHorizontalScrollbar): |
+ * platform/ScrollableArea.h: |
+ Pipe to ScrollAnimator. |
+ |
+ * platform/mac/ScrollAnimatorMac.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar): |
+ * platform/mac/ScrollbarThemeMac.h: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::registerScrollbar): |
+ (WebCore::ScrollbarThemeMac::unregisterScrollbar): |
+ (WebCore::ScrollbarThemeMac::painterForScrollbar): |
+ Move painter delegate registration to the new didAdd/willRemove functions. |
+ |
+2011-02-07 Anders Carlsson <andersca@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Missing text match markers with accelerated content |
+ https://bugs.webkit.org/show_bug.cgi?id=53934 |
+ |
+ When doing the fake paint that recomputes the text match rects, we need to |
+ flatten compositing layers, otherwise the rects won't be updated until the next paint call. |
+ |
+ (This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing |
+ window before asking for the text match rects). |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::countMatchesForText): |
+ |
+2011-02-07 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg |
+ https://bugs.webkit.org/show_bug.cgi?id=53900 |
+ |
+ Ignore link elements in shadow trees. |
+ |
+ * dom/Element.cpp: |
+ (WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher): |
+ (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher): |
+ |
+ Some asserts to catch cases like this. |
+ |
+ (WebCore::Element::attach): |
+ (WebCore::Element::recalcStyle): |
+ * html/HTMLLinkElement.cpp: |
+ (WebCore::HTMLLinkElement::HTMLLinkElement): |
+ (WebCore::HTMLLinkElement::process): |
+ (WebCore::HTMLLinkElement::insertedIntoDocument): |
+ (WebCore::HTMLLinkElement::removedFromDocument): |
+ * html/HTMLLinkElement.h: |
+ |
+2011-02-07 Darin Adler <darin@apple.com> |
+ |
+ Turn UTF-8 decoder off for now so we can look into failing tests |
+ without leaving the tree red. |
+ |
+ * platform/text/TextCodecICU.cpp: |
+ (WebCore::TextCodecICU::registerBaseEncodingNames): Reverting |
+ earlier change so this can handle UTF-8. |
+ (WebCore::TextCodecICU::registerBaseCodecs): Ditto. |
+ (WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto. |
+ (WebCore::TextCodecICU::registerExtendedCodecs): Ditto. |
+ * platform/text/TextCodecICU.h: Ditto. |
+ * platform/text/TextEncodingRegistry.cpp: |
+ (WebCore::buildBaseTextCodecMaps): Ditto. |
+ (WebCore::extendTextCodecMaps): Ditto. |
+ * platform/text/brew/TextCodecBrew.cpp: |
+ (WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto. |
+ (WebCore::TextCodecBrew::registerBaseCodecs): Ditto. |
+ (WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto. |
+ (WebCore::TextCodecBrew::registerExtendedCodecs): Ditto. |
+ * platform/text/brew/TextCodecBrew.h: Ditto. |
+ * platform/text/gtk/TextCodecGtk.cpp: |
+ (WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto. |
+ (WebCore::TextCodecGtk::registerBaseCodecs): Ditto. |
+ * platform/text/wince/TextCodecWinCE.cpp: |
+ (WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto. |
+ (WebCore::TextCodecWinCE::registerBaseCodecs): Ditto. |
+ (WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto. |
+ (WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto. |
+ * platform/text/wince/TextCodecWinCE.h: Ditto. |
+ |
+2011-02-07 Anders Carlsson <andersca@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Don't exclude overlay scrollers from the page overlay bounds |
+ https://bugs.webkit.org/show_bug.cgi?id=53924 |
+ |
+ Export ScrollbarTheme::nativeTheme. |
+ |
+ * WebCore.exp.in: |
+ |
+2011-02-07 Zhenyao Mo <zmo@google.com> |
+ |
+ Reviewed by Kenneth Russell. |
+ |
+ Crash in glDrawArrays with NaCl crystal model |
+ https://bugs.webkit.org/show_bug.cgi?id=52831 |
+ |
+ * html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used. |
+ (WebCore::WebGLRenderingContext::initVertexAttrib0): |
+ (WebCore::WebGLRenderingContext::simulateVertexAttrib0): |
+ * html/canvas/WebGLRenderingContext.h: |
+ |
+2011-02-07 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles. |
+ https://bugs.webkit.org/show_bug.cgi?id=53842 |
+ |
+ Test: platform/mac/accessibility/aria-sort.html |
+ |
+ * accessibility/AccessibilityObject.cpp: |
+ (WebCore::AccessibilityObject::sortDirection): |
+ * accessibility/AccessibilityObject.h: |
+ * accessibility/mac/AccessibilityObjectWrapper.mm: |
+ (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): |
+ (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): |
+ * html/HTMLAttributeNames.in: |
+ |
+2011-02-07 Darin Adler <darin@apple.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Add built-in decoder for UTF-8 for improved performance |
+ https://bugs.webkit.org/show_bug.cgi?id=53898 |
+ |
+ Correct behavior is covered by existing tests. |
+ |
+ * Android.mk: Added TextCodecUTF8. |
+ * CMakeLists.txt: Ditto. |
+ * GNUmakefile.am: Ditto. |
+ * WebCore.gypi: Ditto. |
+ * WebCore.pro: Ditto. |
+ * WebCore.vcproj/WebCore.vcproj: Ditto. |
+ * WebCore.xcodeproj/project.pbxproj: Ditto. |
+ |
+ * platform/text/TextCodecICU.cpp: Removed registration of UTF-8 |
+ since that's now handled by the built-in UTF-8 codec. |
+ (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove |
+ the word "extended" since all codecs from ICU are now extended. |
+ (WebCore::TextCodecICU::registerCodecs): Ditto. |
+ * platform/text/TextCodecICU.h: Ditto. |
+ |
+ * platform/text/TextCodecUTF16.cpp: |
+ (WebCore::TextCodecUTF16::decode): Added a FIXME about missing |
+ error handling. |
+ |
+ * platform/text/TextCodecUTF8.cpp: Added. |
+ * platform/text/TextCodecUTF8.h: Added. |
+ |
+ * platform/text/TextEncodingRegistry.cpp: |
+ (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and |
+ removed TextCodecICU, TextCodecBrew, and TextCodecWinCE. |
+ (WebCore::extendTextCodecMaps): Updated names for |
+ TextCodecICU and TextCodecWinCE. |
+ |
+ * platform/text/brew/TextCodecBrew.cpp: |
+ (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove |
+ the word "extended" since all codecs from Brew are now extended. |
+ (WebCore::TextCodecBrew::registerCodecs): Ditto. |
+ * platform/text/brew/TextCodecBrew.h: Ditto. |
+ |
+ * platform/text/gtk/TextCodecGtk.cpp: |
+ (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed |
+ registration of UTF-8. It's questionable whether the other codecs |
+ here are really basic. If we think they qualify, then we should |
+ register them on other platforms, not just GTK. |
+ (WebCore::TextCodecGtk::registerBaseCodecs): Ditto. |
+ |
+ * platform/text/wince/TextCodecWinCE.cpp: |
+ (WebCore::getCodePage): Removed special case for UTF-8 since we |
+ no longer use this codec for UTF-8. |
+ (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove |
+ the word "extended" since all codecs from WinCE are now extended. |
+ (WebCore::TextCodecWinCE::registerCodecs): Ditto. |
+ * platform/text/wince/TextCodecWinCE.h: Ditto. |
+ |
+2011-02-07 Mario Sanchez Prada <msanchez@igalia.com> |
+ |
+ Reviewed by Xan Lopez. |
+ |
+ [Gtk] atk_text_get_caret_offset fails for list items |
+ https://bugs.webkit.org/show_bug.cgi?id=53436 |
+ |
+ Consider list item markers when calculating the offset. |
+ |
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: |
+ (webkit_accessible_text_get_caret_offset): Adjust the offset |
+ with the item marker's length for list items. |
+ (webkit_accessible_text_set_caret_offset): Replace usage of |
+ g_utf8_strlen() by calling to markerText.length(). |
+ |
+2011-02-07 Yi Shen <yi.4.shen@nokia.com> |
+ |
+ Reviewed by Tor Arne Vestbø. |
+ |
+ [Qt] Fix LayoutTests/media/restore-from-page-cache.html |
+ https://bugs.webkit.org/show_bug.cgi?id=53621 |
+ |
+ Changed the networkState to MediaPlayer::Loaded when |
+ MediaPlayerPrivateQt has enough data. |
+ |
+ Test: media/restore-from-page-cache.html |
+ |
+ * platform/graphics/qt/MediaPlayerPrivateQt.cpp: |
+ (WebCore::MediaPlayerPrivateQt::updateStates): |
+ |
+2011-01-31 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: implement beautification of scripts inlined in html documents. |
+ https://bugs.webkit.org/show_bug.cgi?id=52706 |
+ |
+ To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and |
+ finally paste them back to html. |
+ |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * inspector/front-end/ScriptFormatter.js: |
+ (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html. |
+ (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): |
+ (WebInspector.ScriptFormatter.prototype.formatContent): |
+ (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): |
+ (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat): |
+ (WebInspector.ScriptFormatter.prototype._formatChunks): |
+ (WebInspector.ScriptFormatter.prototype._buildContentFromChunks): |
+ (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler): |
+ (WebInspector.ScriptFormatter.prototype._formatScript): |
+ * inspector/front-end/ScriptFormatterWorker.js: |
+ (onmessage): |
+ (buildMapping): |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers. |
+ * inspector/front-end/SourceFrameContent.js: Added. |
+ (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout |
+ (WebInspector.SourceFrameContent.prototype.get scriptRanges): |
+ (WebInspector.SourceFrameContent.prototype.locationToPosition): |
+ (WebInspector.SourceFrameContent.prototype.positionToLocation): |
+ (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber): |
+ (WebInspector.SourceFrameContent.prototype.scriptLocationForRange): |
+ (WebInspector.SourceFrameContent.prototype.lineNumberToRange): |
+ (WebInspector.SourceFrameContent.prototype._intersectingScriptRange): |
+ (WebInspector): |
+ (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them. |
+ (WebInspector.FormattedSourceFrameContent.prototype.get text): |
+ (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation): |
+ (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber): |
+ (WebInspector.FormattedSourceFrameContent.prototype._convertPosition): |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/inspector.html: |
+ |
+2011-02-07 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: "Reveal in elements panel" does not always work. |
+ https://bugs.webkit.org/show_bug.cgi?id=53775 |
+ |
+ * inspector/front-end/ConsoleView.js: |
+ (WebInspector.ConsoleView): |
+ * inspector/front-end/ContextMenu.js: |
+ (WebInspector.ContextMenu.prototype.show): |
+ * inspector/front-end/ElementsPanel.js: |
+ (WebInspector.ElementsPanel.prototype.switchToAndFocus): |
+ * inspector/front-end/ElementsTreeOutline.js: |
+ (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): |
+ (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): |
+ * inspector/front-end/ObjectPropertiesSection.js: |
+ (WebInspector.ObjectPropertyTreeElement.prototype.update): |
+ (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired): |
+ * inspector/front-end/inspector.js: |
+ (WebInspector.cancelSearch): |
+ |
+2011-02-07 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Relative .. in URL paths shouldn't skip adjacent / characters |
+ https://bugs.webkit.org/show_bug.cgi?id=53907 |
+ |
+ Our new behavior matches Firefox, Chrome, and IE. |
+ |
+ * platform/KURL.cpp: |
+ (WebCore::copyPathRemovingDots): |
+ |
+2011-02-07 Maciej Stachowiak <mjs@apple.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ WebKitTestRunner does not block remote resources or complain about them |
+ https://bugs.webkit.org/show_bug.cgi?id=42139 |
+ <rdar://problem/8183942> |
+ |
+ * Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link |
+ WebCore. |
+ * WebCore.exp.in: Export a handful of KURL symbols. |
+ |
+2011-02-06 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h |
+ https://bugs.webkit.org/show_bug.cgi?id=52867 |
+ |
+ * ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed. |
+ * bindings/v8/NPV8Object.cpp: |
+ (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of |
+ v8::Handle<v8::Value>*. |
+ (_NPN_Invoke): Calls createValueListFromVariantArgs. |
+ (_NPN_InvokeDefault): createValueListFromVariantArgs. |
+ (_NPN_Construct): createValueListFromVariantArgs. |
+ * bindings/v8/ScriptFunctionCall.cpp: |
+ (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr. |
+ (WebCore::ScriptFunctionCall::construct): Ditto. |
+ (WebCore::ScriptCallback::call): |
+ * bindings/v8/V8DOMWindowShell.cpp: |
+ (WebCore::V8DOMWindowShell::createNewContext): Ditto. |
+ * bindings/v8/V8NPObject.cpp: |
+ (WebCore::npObjectInvokeImpl): Ditto |
+ * bindings/v8/V8NodeFilterCondition.cpp: |
+ (WebCore::V8NodeFilterCondition::acceptNode): Ditto, |
+ * html/HTMLAreaElement.cpp: |
+ (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray. |
+ * html/HTMLFrameSetElement.cpp: |
+ (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray. |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr. |
+ (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto. |
+ (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito. |
+ * platform/Length.cpp: |
+ (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*. |
+ (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*. |
+ * platform/Length.h: Prototype changes. |
+ * platform/graphics/ANGLEWebKitBridge.cpp: |
+ (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr. |
+ * platform/graphics/ca/win/CACFLayerTreeHost.cpp: |
+ (WebCore::getDirtyRects): Ditto. |
+ * platform/graphics/chromium/ComplexTextControllerLinux.cpp: |
+ (WebCore::ComplexTextController::getNormalizedTextRun): Ditto. |
+ * platform/graphics/chromium/HarfbuzzSkia.cpp: |
+ (WebCore::glyphsToAdvances): Ditto. |
+ (WebCore::canRender): Ditto. |
+ * platform/graphics/gpu/Texture.cpp: |
+ (WebCore::Texture::updateSubRect): Ditto. |
+ * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: |
+ (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto. |
+ * platform/graphics/skia/PlatformContextSkia.cpp: |
+ (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto. |
+ * platform/graphics/wince/SharedBitmap.cpp: |
+ (WebCore::SharedBitmap::to16bit): Ditto. |
+ * platform/win/ContextMenuWin.cpp: |
+ (WebCore::ContextMenu::getContextMenuItems): Ditto. |
+ * platform/win/LoggingWin.cpp: |
+ (WebCore::initializeWithUserDefault): Ditto. |
+ * plugins/win/PluginPackageWin.cpp: |
+ (WebCore::PluginPackage::fetchInfo): Ditto. |
+ |
+2011-02-06 Kent Tamura <tkent@chromium.org> |
+ |
+ Unreviewed. |
+ |
+ * WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file. |
+ |
+2011-02-03 Dominic Cooney <dominicc@google.com> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Convert <keygen> option elements to a shadow DOM |
+ https://bugs.webkit.org/show_bug.cgi?id=51379 |
+ |
+ Covered by existing tests e.g. fast/html/keygen.html, |
+ html5lib/runner.html, etc. |
+ |
+ * css/html.css: |
+ (form): Cleanup. |
+ (keygen, select): Border radii should match so focus ring looks good. |
+ (keygen::-webkit-keygen-select): No margin on the shadow element. |
+ (select): Hoisting border radius to keygen, select rule. |
+ * dom/SelectElement.cpp: |
+ (WebCore::toSelectElement): keygen is no longer a select element. |
+ * html/HTMLKeygenElement.cpp: Implements keygen shadow. |
+ (WebCore::KeygenSelectElement::create): |
+ (WebCore::KeygenSelectElement::shadowPseudoId): |
+ (WebCore::KeygenSelectElement::KeygenSelectElement): |
+ (WebCore::HTMLKeygenElement::HTMLKeygenElement): |
+ (WebCore::HTMLKeygenElement::parseMappedAttribute): |
+ (WebCore::HTMLKeygenElement::appendFormData): |
+ (WebCore::HTMLKeygenElement::formControlType): |
+ (WebCore::HTMLKeygenElement::reset): |
+ (WebCore::HTMLKeygenElement::selectShadow): |
+ * html/HTMLKeygenElement.h: keygen is no longer a select on C++ side. |
+ (WebCore::HTMLKeygenElement::canStartSelection): |
+ (WebCore::HTMLKeygenElement::isEnumeratable): |
+ (WebCore::HTMLKeygenElement::isResettable): |
+ * html/HTMLOptionElement.cpp: |
+ (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects. |
+ * html/HTMLSelectElement.cpp: |
+ (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name. |
+ |
+2011-02-06 Benjamin Poulain <ikipou@gmail.com> |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ [Qt] Fix coding style errors in ClipboardQt.h |
+ https://bugs.webkit.org/show_bug.cgi?id=43520 |
+ |
+ Fix coding style: order of header and indentation. |
+ |
+ * platform/qt/ClipboardQt.h: |
+ (WebCore::ClipboardQt::create): |
+ (WebCore::ClipboardQt::clipboardData): |
+ (WebCore::ClipboardQt::invalidateWritableData): |
+ |
+2011-02-06 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Use bloom filter for descendant selector filtering |
+ https://bugs.webkit.org/show_bug.cgi?id=53880 |
+ |
+ Bloom filter is faster than a hash set in this kind of use. |
+ |
+ Shark thinks this speeds up style matching by ~30% on sites |
+ with lots of descendant selectors. |
+ |
+ * ForwardingHeaders/wtf/BloomFilter.h: Added. |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::collectElementIdentifierHashes): |
+ (WebCore::CSSStyleSelector::pushParent): |
+ (WebCore::CSSStyleSelector::popParent): |
+ (WebCore::CSSStyleSelector::fastRejectSelector): |
+ (WebCore::RuleData::collectDescendantSelectorIdentifierHashes): |
+ * css/CSSStyleSelector.h: |
+ |
+2011-02-06 Maciej Stachowiak <mjs@apple.com> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ media/video-document-types.html sometimes crashes the WebProcess |
+ https://bugs.webkit.org/show_bug.cgi?id=53884 |
+ |
+ No new tests. Already covered by media/video-document-types.html |
+ |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer |
+ when cancelling the load. |
+ |
+2011-02-06 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Adam Roben. |
+ |
+ [WIN] Use WCHAR instead of TCHAR |
+ https://bugs.webkit.org/show_bug.cgi?id=53863 |
+ |
+ We always use the UNICODE versions of windows functions, so |
+ the usage of TCHAR makes no sense and mixing them is bad style. |
+ |
+ * platform/graphics/win/IconWin.cpp: |
+ (WebCore::Icon::createIconForFiles): |
+ * platform/graphics/win/QTMovie.cpp: |
+ * platform/graphics/win/QTMovieGWorld.cpp: |
+ (QTMovieGWorld::fullscreenWndProc): |
+ (QTMovieGWorld::enterFullscreen): |
+ * platform/graphics/win/SimpleFontDataCGWin.cpp: |
+ (WebCore::SimpleFontData::platformInit): |
+ * platform/graphics/win/SimpleFontDataCairoWin.cpp: |
+ * platform/graphics/win/SimpleFontDataWin.cpp: |
+ * platform/graphics/wince/SimpleFontDataWinCE.cpp: |
+ * platform/win/BString.cpp: |
+ * platform/win/ClipboardWin.cpp: |
+ (WebCore::filesystemPathFromUrlOrTitle): |
+ (WebCore::createGlobalHDropContent): |
+ (WebCore::createGlobalImageFileDescriptor): |
+ * platform/win/ContextMenuWin.cpp: |
+ * platform/win/CursorWin.cpp: |
+ (WebCore::loadSharedCursor): |
+ * platform/win/FileChooserWin.cpp: |
+ (WebCore::FileChooser::basenameForWidth): |
+ * platform/win/PopupMenuWin.cpp: |
+ (WebCore::PopupMenuWin::popupClassName): |
+ (WebCore::PopupMenuWin::show): |
+ * platform/win/PopupMenuWin.h: |
+ |
+2011-02-06 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Replace FLT_MAX with std::numeric_limits |
+ https://bugs.webkit.org/show_bug.cgi?id=53861 |
+ |
+ Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl. |
+ |
+ * html/NumberInputType.cpp: |
+ * html/parser/HTMLParserIdioms.cpp: |
+ (WebCore::parseToDoubleForNumberType): |
+ * platform/brew/SystemTimeBrew.cpp: |
+ (WebCore::userIdleTime): |
+ * platform/efl/SystemTimeEfl.cpp: |
+ (WebCore::userIdleTime): |
+ * platform/efl/TemporaryLinkStubs.cpp: |
+ * platform/graphics/ca/GraphicsLayerCA.cpp: |
+ (WebCore::GraphicsLayerCA::setupAnimation): |
+ * platform/win/SystemTimeWin.cpp: |
+ (WebCore::userIdleTime): |
+ * platform/wx/SystemTimeWx.cpp: |
+ (WebCore::userIdleTime): |
+ |
+2011-02-06 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [CMake] Add dependencies for Visual Studio projects |
+ https://bugs.webkit.org/show_bug.cgi?id=53773 |
+ |
+ Add a JavaScriptCore dependecy to WebCore, so CMake can |
+ generate the correct build order for the solution. |
+ |
+ * CMakeLists.txt: |
+ |
+2011-02-06 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ [CMake] Unify ENABLE_SVG sections |
+ https://bugs.webkit.org/show_bug.cgi?id=53778 |
+ |
+ * CMakeLists.txt: |
+ |
+2011-02-06 Andreas Kling <kling@webkit.org> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ Refactor Font::normalizeSpaces() to avoid an extra String copy. |
+ https://bugs.webkit.org/show_bug.cgi?id=53871 |
+ |
+ Have normalizeSpaces() take UChar*,length arguments instead of a |
+ String, since all call sites were creating temporaries from these |
+ components anyway. |
+ |
+ Font::normalizeSpaces() now always makes 1 String copy, |
+ instead of 1 in the best case and 2 in the worst case. |
+ |
+ * platform/graphics/Font.cpp: |
+ (WebCore::Font::normalizeSpaces): |
+ * platform/graphics/Font.h: |
+ * platform/graphics/qt/FontQt.cpp: |
+ (WebCore::drawTextCommon): |
+ (WebCore::Font::floatWidthForSimpleText): |
+ (WebCore::Font::floatWidthForComplexText): |
+ (WebCore::Font::offsetForPositionForSimpleText): |
+ (WebCore::Font::offsetForPositionForComplexText): |
+ (WebCore::Font::selectionRectForSimpleText): |
+ (WebCore::Font::selectionRectForComplexText): |
+ * svg/SVGFont.cpp: |
+ (WebCore::SVGTextRunWalker::walk): |
+ |
+2011-02-06 Andreas Kling <kling@webkit.org> |
+ |
+ Reviewed by Dirk Schulze. |
+ |
+ Fix potential buffer overrun in SVGTextRunWalker::walk() |
+ https://bugs.webkit.org/show_bug.cgi?id=53870 |
+ |
+ A new String was created from a UChar* with a 'length' argument |
+ that could be greater than the number of UChars available. |
+ |
+ * svg/SVGFont.cpp: |
+ (WebCore::SVGTextRunWalker::walk): |
+ |
+2011-02-05 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Remove unused parameter related to XSSAuditor |
+ https://bugs.webkit.org/show_bug.cgi?id=53862 |
+ |
+ * WebCore.exp.in: |
+ * bindings/ScriptControllerBase.cpp: |
+ (WebCore::ScriptController::executeScript): |
+ (WebCore::ScriptController::executeIfJavaScriptURL): |
+ * bindings/ScriptControllerBase.h: |
+ * bindings/js/ScriptController.cpp: |
+ (WebCore::ScriptController::evaluateInWorld): |
+ (WebCore::ScriptController::evaluate): |
+ (WebCore::ScriptController::executeScriptInWorld): |
+ * bindings/js/ScriptController.h: |
+ * bindings/v8/ScriptController.cpp: |
+ (WebCore::ScriptController::evaluate): |
+ * bindings/v8/ScriptController.h: |
+ |
+2011-02-05 Adam Barth <abarth@webkit.org> |
+ |
+ Fix Qt build. |
+ |
+ * WebCore.pro: |
+ |
+2011-02-05 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Delete XSSAuditor |
+ https://bugs.webkit.org/show_bug.cgi?id=53859 |
+ |
+ The job of the XSSAuditor is now done by the XSSFilter. In the future, |
+ we might rename XSSFilter to XSSAuditor. |
+ |
+ * Android.mk: |
+ * CMakeLists.txt: |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/ScriptControllerBase.cpp: |
+ (WebCore::ScriptController::executeIfJavaScriptURL): |
+ * bindings/ScriptControllerBase.h: |
+ * bindings/js/ScriptController.cpp: |
+ (WebCore::ScriptController::ScriptController): |
+ (WebCore::ScriptController::evaluateInWorld): |
+ * bindings/js/ScriptController.h: |
+ * bindings/js/ScriptEventListener.cpp: |
+ (WebCore::createAttributeEventListener): |
+ * bindings/v8/ScriptController.cpp: |
+ (WebCore::ScriptController::ScriptController): |
+ (WebCore::ScriptController::evaluate): |
+ * bindings/v8/ScriptController.h: |
+ * bindings/v8/ScriptEventListener.cpp: |
+ (WebCore::createAttributeEventListener): |
+ * dom/Document.cpp: |
+ (WebCore::Document::implicitOpen): |
+ (WebCore::Document::processBaseElement): |
+ * dom/ScriptableDocumentParser.cpp: |
+ (WebCore::ScriptableDocumentParser::ScriptableDocumentParser): |
+ * dom/ScriptableDocumentParser.h: |
+ * html/parser/HTMLDocumentParser.cpp: |
+ (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc): |
+ * loader/SubframeLoader.cpp: |
+ (WebCore::SubframeLoader::requestObject): |
+ (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): |
+ * page/XSSAuditor.cpp: Removed. |
+ * page/XSSAuditor.h: Removed. |
+ |
+2011-02-05 Anders Carlsson <andersca@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Need a way to resize and scroll the page at the same time |
+ https://bugs.webkit.org/show_bug.cgi?id=53814 |
+ <rdar://problem/8498008> |
+ |
+ Export a function needed by WebKit2. |
+ |
+ * WebCore.exp.in: |
+ |
+2011-02-05 Patrick Gansterer <paroga@webkit.org> |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ Use Document::encoding() instead of DocumentWriter::encoding() |
+ https://bugs.webkit.org/show_bug.cgi?id=53398 |
+ |
+ This change makes the code more readable, when a subresource |
+ inherits the character encoding of the document. |
+ |
+ * dom/ProcessingInstruction.cpp: |
+ (WebCore::ProcessingInstruction::checkStyleSheet): |
+ * dom/ScriptElement.cpp: |
+ (WebCore::ScriptElement::scriptCharset): |
+ * html/HTMLLinkElement.cpp: |
+ (WebCore::HTMLLinkElement::process): |
+ * loader/cache/CachedResourceLoader.cpp: |
+ (WebCore::CachedResourceLoader::requestPreload): |
+ * platform/network/FormDataBuilder.cpp: |
+ (WebCore::FormDataBuilder::encodingFromAcceptCharset): |
+ |
+2011-02-05 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ Introduce URLString to represent a canonicalized URL represented by a string |
+ https://bugs.webkit.org/show_bug.cgi?id=53847 |
+ |
+ Instead of using String all over the codebase to represent a URL, |
+ instead we should have a type to represent a canonicalized URL in the |
+ form of a string. This patch introduces that type. |
+ |
+ * GNUmakefile.am: |
+ * WebCore.gypi: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/KURL.cpp: |
+ (WebCore::KURL::KURL): |
+ * platform/KURL.h: |
+ (WebCore::KURL::urlString): |
+ |
+2011-02-05 Robert Hogan <robert@webkit.org> |
+ |
+ Reviewed by Antonio Gomes. |
+ |
+ [Qt] Style widgets not rendering |
+ https://bugs.webkit.org/show_bug.cgi?id=53849 |
+ |
+ * html/HTMLObjectElement.cpp: |
+ (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too |
+ |
+2011-02-05 Jochen Eisinger <jochen@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader. |
+ https://bugs.webkit.org/show_bug.cgi?id=53685 |
+ |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * dom/Document.h: |
+ (WebCore::Document::contentSecurityPolicy): |
+ * loader/MainResourceLoader.cpp: |
+ (WebCore::MainResourceLoader::didReceiveResponse): |
+ * page/ContentSecurityPolicy.cpp: |
+ (WebCore::ContentSecurityPolicy::didReceiveHeader): |
+ * page/ContentSecurityPolicy.h: |
+ |
+2011-02-05 Eric Seidel <eric@webkit.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Safari should lowercase schemes in cannonicalized urls to match every other browser |
+ https://bugs.webkit.org/show_bug.cgi?id=53848 |
+ |
+ We're clearly the odd man out here. See results from every browser at: |
+ https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt |
+ |
+ * platform/KURL.cpp: |
+ (WebCore::KURL::parse): |
+ - Just lowercase the scheme when copying. |
+ |
+2011-02-05 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Dave Hyatt. |
+ |
+ Optimize matching of descendant selectors |
+ https://bugs.webkit.org/show_bug.cgi?id=49876 |
+ <rdar://problem/8772822> |
+ |
+ During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements. |
+ Use the filter to quickly reject descendant and child selectors when doing style matching. |
+ |
+ This speeds up style recalculations 3-6x on many major web sites. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::RuleData::RuleData): |
+ (WebCore::RuleData::descendantSelectorIdentifierHashes): |
+ (WebCore::collectElementIdentifiers): |
+ (WebCore::CSSStyleSelector::pushParent): |
+ (WebCore::CSSStyleSelector::popParent): |
+ (WebCore::CSSStyleSelector::fastRejectSelector): |
+ (WebCore::CSSStyleSelector::matchRulesForList): |
+ (WebCore::RuleData::collectDescendantSelectorIdentifierHashes): |
+ * css/CSSStyleSelector.h: |
+ (WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame): |
+ * dom/Element.cpp: |
+ (WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher): |
+ (WebCore::StyleSelectorParentPusher::push): |
+ (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher): |
+ (WebCore::Element::attach): |
+ (WebCore::Element::recalcStyle): |
+ |
+2011-02-05 Nate Chapin <japhet@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext* |
+ when it inherits one from ActiveDOMObject. |
+ https://bugs.webkit.org/show_bug.cgi?id=53815 |
+ |
+ * bindings/js/JSDesktopNotificationsCustom.cpp: |
+ (WebCore::JSNotificationCenter::requestPermission): |
+ * bindings/v8/custom/V8NotificationCenterCustom.cpp: |
+ (WebCore::V8NotificationCenter::requestPermissionCallback): |
+ * notifications/NotificationCenter.cpp: |
+ (WebCore::NotificationCenter::NotificationCenter): |
+ (WebCore::NotificationCenter::checkPermission): |
+ (WebCore::NotificationCenter::requestPermission): |
+ (WebCore::NotificationCenter::disconnectFrame): |
+ * notifications/NotificationCenter.h: |
+ (WebCore::NotificationCenter::createHTMLNotification): |
+ (WebCore::NotificationCenter::createNotification): |
+ |
+2011-02-04 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Maciej Stachowiak. |
+ |
+ Crash in WebCore::TextEncoding::decode below XSSFilter::init |
+ https://bugs.webkit.org/show_bug.cgi?id=53837 |
+ |
+ Add missing null check. |
+ |
+ Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::XSSFilter::init): |
+ |
+2011-02-04 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Crashes in ShadowBlur via WebKit2 FindController |
+ https://bugs.webkit.org/show_bug.cgi?id=53830 |
+ |
+ Fix a crash cause by re-entering ShadowBlur, and add assertions to |
+ detect when it happens. |
+ |
+ The re-entrancy occurred when drawRectShadowWithTiling() filled |
+ the interior of the shadow with fillRect() on the context |
+ which still had the shadow state set. This would make another ShadowBlur |
+ on the stack and call into the code again, potentially blowing away |
+ the image buffer. |
+ |
+ Fix by turning off shadows in the destination context while we're |
+ drawing the tiled shadow. The non-tiled code path already did this. |
+ |
+ Not testable because CSS shadows clip out the inside of the rect |
+ being shadowed, and SVG uses fillPath, even for rects. |
+ |
+ * platform/graphics/ShadowBlur.cpp: |
+ (WebCore::ScratchBuffer::ScratchBuffer): |
+ (WebCore::ScratchBuffer::getScratchBuffer): |
+ (WebCore::ScratchBuffer::scheduleScratchBufferPurge): |
+ (WebCore::ShadowBlur::ShadowBlur): |
+ (WebCore::ShadowBlur::drawRectShadowWithTiling): |
+ |
+2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com> |
+ |
+ Reviewed by Martin Robinson. |
+ |
+ [GTK] Don't use a fixed size for search field icons |
+ https://bugs.webkit.org/show_bug.cgi?id=50624 |
+ |
+ Use the parent input content box to make sure the icon fits in the |
+ search field, scaling it down when needed. |
+ |
+ * platform/gtk/RenderThemeGtk.cpp: |
+ (WebCore::paintGdkPixbuf): |
+ (WebCore::getIconSizeForPixelSize): |
+ (WebCore::adjustSearchFieldIconStyle): |
+ (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): |
+ (WebCore::centerRectVerticallyInParentInputElement): |
+ (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): |
+ (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): |
+ (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): |
+ (WebCore::RenderThemeGtk::paintCapsLockIndicator): |
+ (WebCore::RenderThemeGtk::paintMediaButton): |
+ |
+2011-02-04 Hironori Bono <hbono@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ [chromium] JPEG corruption |
+ https://bugs.webkit.org/show_bug.cgi?id=53250 |
+ |
+ Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color |
+ profiles from CMYK to RGB twice and it causes color corruption. This |
+ change suppresses the color profiles for CMYK JPEGs same as gray-scale |
+ ones. |
+ |
+ Test: fast/images/cmyk-jpeg-with-color-profile.html |
+ |
+ * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: |
+ (WebCore::JPEGImageReader::decode): |
+ |
+2011-02-04 Xiyuan Xia <xiyuan@chromium.org> |
+ |
+ Reviewed by Tony Chang. |
+ |
+ [Chromium] Option text in select popup does not align with menulist button text |
+ https://bugs.webkit.org/show_bug.cgi?id=53632 |
+ |
+ This makes clientPaddingLeft and clientPaddingRight return |
+ the additional m_innerBlock's padding so that the popup item text |
+ aligns with the menulist button text. |
+ |
+ * rendering/RenderMenuList.cpp: |
+ (WebCore::RenderMenuList::clientPaddingLeft): |
+ (WebCore::RenderMenuList::clientPaddingRight): |
+ |
+2011-02-04 Anders Carlsson <andersca@apple.com> |
+ |
+ Reviewed by Sam Weinig and Beth Dakin. |
+ |
+ REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically |
+ <rdar://problem/8962457> |
+ |
+ * platform/ScrollView.cpp: |
+ (WebCore::ScrollView::scrollContents): |
+ Subtract scrollbars from the scroll view rect if overlay scrollers are enabled. |
+ |
+ * platform/ScrollableArea.cpp: |
+ (WebCore::ScrollableArea::setScrollOffsetFromAnimation): |
+ Make sure to invalidate both scrollbars if overlay scrollers are enabled. |
+ |
+2011-02-04 Adam Barth <abarth@webkit.org> |
+ |
+ Reviewed by Eric Seidel. |
+ |
+ PluginDocuments don't create widgets for plugins on back/forward |
+ https://bugs.webkit.org/show_bug.cgi?id=53474 |
+ |
+ Long ago, PluginDocument always caused the HTMLEmbedElement to create |
+ its widget synchronously during a post-layout task. Recently, however, |
+ some changes to the HistroyController caused layout on back/forward to |
+ become slightly more complicated (and added an extra level of recursion |
+ to layout). This extra level of recursion triggered the "I've recursed |
+ too many times" condition in the post-layout task queue, causing the |
+ FrameView to run the remainder of the tasks asynchronously. |
+ Unfortunately, that broke PluginDocument because it needs its the |
+ HTMLEmbedElement's updateWidget task to run synchronously. |
+ |
+ This patch adds a mechanism for "kicking off" the pending post-layout |
+ tasks synchronously (instead of waiting for the timer to fire). |
+ PluginDocument then uses that facility to ensure that the |
+ HTMLEmbedElement's updateWidget task happens. |
+ |
+ Test: plugins/plugin-document-back-forward.html |
+ |
+ * html/PluginDocument.cpp: |
+ (WebCore::PluginDocumentParser::appendBytes): |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::flushAnyPendingPostLayoutTasks): |
+ * page/FrameView.h: |
+ |
+2011-02-04 Charlie Reis <creis@chromium.org> |
+ |
+ Reviewed by Mihai Parparita. |
+ |
+ Crash in WebCore::HistoryController::itemsAreClones |
+ https://bugs.webkit.org/show_bug.cgi?id=52819 |
+ |
+ Avoids deleting the current HistoryItem while it is still in use. |
+ Ensures that provisional items are committed for same document navigations. |
+ Ensures that error pages are committed on back/forward navigations. |
+ Also removes unneeded sanity checks used for diagnosing the problem. |
+ |
+ * loader/HistoryController.cpp: |
+ * loader/HistoryController.h: |
+ |
+2011-02-04 Carol Szabo <carol.szabo@nokia.com> |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Code Changes. |
+ |
+ CSS 2.1 failure: content-* |
+ https://bugs.webkit.org/show_bug.cgi?id=52126 |
+ |
+ Test: fast/css/counters/content-021.html |
+ |
+ * rendering/CounterNode.cpp: |
+ (showCounterTree): |
+ Made parameter const because it is supposed to be so. |
+ * rendering/RenderCounter.cpp: |
+ (WebCore::previousInPreOrder): |
+ (WebCore::previousSiblingOrParent): |
+ (WebCore::parentElement): |
+ (WebCore::areRenderersElementsSiblings): |
+ (WebCore::nextInPreOrder): |
+ Added these local helper functions to help navigate the DOM tree |
+ enriched with :before and :after pseudo elements. |
+ (WebCore::planCounter): |
+ Fixed bug that would create a repeat counter for second and |
+ subsequent renderers associated with the same DOM element. |
+ (WebCore::findPlaceForCounter): |
+ (WebCore::makeCounterNode): |
+ Changed to use the new tree navigation functions described above |
+ instead of the Renderer Tree navigation functions. |
+ (WebCore::RenderCounter::rendererSubtreeAttached): |
+ (WebCore::RenderCounter::rendererStyleChanged): |
+ Optimized to not bother about counters until the renderers are |
+ finally attached. |
+ (showRendererTree): |
+ (showNodeTree): |
+ Debug helper functions used to debug Counter bugs. |
+ |
+2011-02-04 Dan Bernstein <mitz@apple.com> |
+ |
+ Typo fix. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::HTMLNames::containsJavaScriptURL): |
+ |
+2011-02-04 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Make an infinite loop introduced in r77454 finite. |
+ |
+ * html/parser/XSSFilter.cpp: |
+ (WebCore::HTMLNames::containsJavaScriptURL): |
+ |
+2011-02-04 Jer Noble <jer.noble@apple.com> |
+ |
+ Reviewed by Eric Carlson. |
+ |
+ Frame accurate seeking isn't always accurate |
+ https://bugs.webkit.org/show_bug.cgi?id=52697 |
+ |
+ Test: media/video-frame-accurate-seek.html |
+ |
+ Make seeking slightly more accurate by rounding instead of truncating |
+ when converting from seconds-in-float to time/timeScale. |
+ |
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: |
+ (WebCore::MediaPlayerPrivateQTKit::createQTTime): |
+ * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: |
+ (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): |
+ * platform/graphics/win/QTMovie.cpp: |
+ (QTMovie::setCurrentTime): |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Second IndexedDB events overhaul patch |
+ https://bugs.webkit.org/show_bug.cgi?id=53813 |
+ |
+ If an IDBRequest has a IDBTransaction, it should propogate |
+ events through it. In order to do this, IDBRequest needs to |
+ hold a transaction frontend object rather than a backend one. |
+ |
+ Test: storage/indexeddb/request-event-propagation.html |
+ |
+ * storage/IDBCursor.cpp: |
+ (WebCore::IDBCursor::IDBCursor): |
+ * storage/IDBCursor.h: |
+ (WebCore::IDBCursor::create): |
+ * storage/IDBDatabase.cpp: |
+ (WebCore::IDBDatabase::setSetVersionTransaction): |
+ (WebCore::IDBDatabase::createObjectStore): |
+ (WebCore::IDBDatabase::deleteObjectStore): |
+ * storage/IDBDatabase.h: |
+ * storage/IDBIndex.cpp: |
+ (WebCore::IDBIndex::IDBIndex): |
+ (WebCore::IDBIndex::openCursor): |
+ (WebCore::IDBIndex::openKeyCursor): |
+ (WebCore::IDBIndex::get): |
+ (WebCore::IDBIndex::getKey): |
+ * storage/IDBIndex.h: |
+ (WebCore::IDBIndex::create): |
+ * storage/IDBObjectStore.cpp: |
+ (WebCore::IDBObjectStore::IDBObjectStore): |
+ (WebCore::IDBObjectStore::get): |
+ (WebCore::IDBObjectStore::add): |
+ (WebCore::IDBObjectStore::put): |
+ (WebCore::IDBObjectStore::deleteFunction): |
+ (WebCore::IDBObjectStore::createIndex): |
+ (WebCore::IDBObjectStore::deleteIndex): |
+ (WebCore::IDBObjectStore::openCursor): |
+ * storage/IDBObjectStore.h: |
+ (WebCore::IDBObjectStore::create): |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::create): |
+ (WebCore::IDBRequest::IDBRequest): |
+ (WebCore::IDBRequest::resetReadyState): |
+ (WebCore::IDBRequest::onSuccess): |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::IDBTransaction): |
+ (WebCore::IDBTransaction::objectStore): |
+ (WebCore::IDBTransaction::contextDestroyed): |
+ (WebCore::IDBTransaction::enqueueEvent): |
+ * storage/IDBTransaction.h: |
+ * storage/IDBTransaction.idl: |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ First step towards event propogation within IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=53795 |
+ |
+ This is the first step towards implementing |
+ http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348 |
+ within IndexedDB. I've created a method that knows how |
+ to capture and bubble (based on Node's dispatchGenericEvent). |
+ I've then changed IDBRequest to use it. |
+ |
+ The only functional change is that preventDefault now must |
+ be called in error events to prevent the transaction from |
+ being aborted. The tests reflect this change and there's one |
+ specific test to look at this behavior. |
+ |
+ Test: storage/indexeddb/error-causes-abort-by-default.html |
+ |
+ * storage/IDBAbortEvent.cpp: |
+ (WebCore::IDBAbortEvent::create): |
+ (WebCore::IDBAbortEvent::IDBAbortEvent): |
+ * storage/IDBAbortEvent.h: |
+ * storage/IDBCompleteEvent.cpp: |
+ (WebCore::IDBCompleteEvent::create): |
+ (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
+ * storage/IDBCompleteEvent.h: |
+ * storage/IDBErrorEvent.cpp: |
+ (WebCore::IDBErrorEvent::IDBErrorEvent): |
+ * storage/IDBEvent.cpp: |
+ (WebCore::IDBEvent::IDBEvent): |
+ (WebCore::IDBEvent::dispatch): |
+ * storage/IDBEvent.h: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBSuccessEvent.cpp: |
+ (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ (WebCore::IDBTransaction::backend): |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
+ |
+2011-02-04 Daniel Cheng <dcheng@chromium.org> |
+ |
+ Reviewed by Dmitry Titov. |
+ |
+ Clone WebClipboard to be frame-specific. |
+ https://bugs.webkit.org/show_bug.cgi?id=53727 |
+ |
+ For drop operations, Chrome currently snapshots the data and copies it |
+ into the renderer process. As we add more supported drag data types, the |
+ copy will become increasingly expensive. Instead, we'd like to snapshot |
+ data in the browser to reduce the amount of data copied and to support |
+ Blob in DataTransferItem. In order to allow this, we associated |
+ WebClipboard with a frame so it can correctly route its IPCs to the |
+ corresponding Chromium host. |
+ |
+ No new tests because no new functionality. |
+ |
+ * platform/chromium/ChromiumDataObject.cpp: |
+ (WebCore::ChromiumDataObject::createReadable): |
+ * platform/chromium/ChromiumDataObject.h: |
+ * platform/chromium/ClipboardChromium.cpp: |
+ (WebCore::ClipboardChromium::create): |
+ * platform/chromium/PlatformBridge.h: |
+ * platform/chromium/ReadableDataObject.cpp: |
+ (WebCore::ReadableDataObject::create): |
+ (WebCore::ReadableDataObject::ReadableDataObject): |
+ (WebCore::ReadableDataObject::getData): |
+ (WebCore::ReadableDataObject::urlTitle): |
+ (WebCore::ReadableDataObject::htmlBaseUrl): |
+ (WebCore::ReadableDataObject::filenames): |
+ (WebCore::ReadableDataObject::ensureTypeCacheInitialized): |
+ * platform/chromium/ReadableDataObject.h: |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Revert https://bugs.webkit.org/show_bug.cgi?id=53795 |
+ |
+ * storage/IDBAbortEvent.cpp: |
+ (WebCore::IDBAbortEvent::create): |
+ (WebCore::IDBAbortEvent::IDBAbortEvent): |
+ * storage/IDBAbortEvent.h: |
+ * storage/IDBCompleteEvent.cpp: |
+ (WebCore::IDBCompleteEvent::create): |
+ (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
+ * storage/IDBCompleteEvent.h: |
+ * storage/IDBErrorEvent.cpp: |
+ (WebCore::IDBErrorEvent::IDBErrorEvent): |
+ * storage/IDBEvent.cpp: |
+ (WebCore::IDBEvent::IDBEvent): |
+ * storage/IDBEvent.h: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBSuccessEvent.cpp: |
+ (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
+ |
+2011-02-04 Martin Galpin <martin@66laps.com> |
+ |
+ Reviewed by David Levin. |
+ |
+ CORS origin header not set on GET when a preflight request is required. |
+ https://bugs.webkit.org/show_bug.cgi?id=50773 |
+ |
+ Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html |
+ |
+ * loader/DocumentThreadableLoader.cpp: |
+ (WebCore::DocumentThreadableLoader::preflightSuccess): |
+ Explicitly set the request origin after a preflight request succeeds. |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ First step towards event propogation within IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=53795 |
+ |
+ This is the first step towards implementing |
+ http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348 |
+ within IndexedDB. I've created a method that knows how |
+ to capture and bubble (based on Node's dispatchGenericEvent). |
+ I've then changed IDBRequest to use it. |
+ |
+ The only functional change is that preventDefault now must |
+ be called in error events to prevent the transaction from |
+ being aborted. The tests reflect this change and there's one |
+ specific test to look at this behavior. |
+ |
+ Test: storage/indexeddb/error-causes-abort-by-default.html |
+ |
+ * storage/IDBAbortEvent.cpp: |
+ (WebCore::IDBAbortEvent::create): |
+ (WebCore::IDBAbortEvent::IDBAbortEvent): |
+ * storage/IDBAbortEvent.h: |
+ * storage/IDBCompleteEvent.cpp: |
+ (WebCore::IDBCompleteEvent::create): |
+ (WebCore::IDBCompleteEvent::IDBCompleteEvent): |
+ * storage/IDBCompleteEvent.h: |
+ * storage/IDBErrorEvent.cpp: |
+ (WebCore::IDBErrorEvent::IDBErrorEvent): |
+ * storage/IDBEvent.cpp: |
+ (WebCore::IDBEvent::IDBEvent): |
+ (WebCore::IDBEvent::dispatch): |
+ * storage/IDBEvent.h: |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBRequest.h: |
+ * storage/IDBSuccessEvent.cpp: |
+ (WebCore::IDBSuccessEvent::IDBSuccessEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ (WebCore::IDBTransaction::backend): |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::taskTimerFired): |
+ |
+2011-02-04 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Csaba Osztrogonác. |
+ |
+ [Qt]REGRESSION(r76951): media/controls-without-preload.html fails |
+ https://bugs.webkit.org/show_bug.cgi?id=53674 |
+ |
+ * css/mediaControlsQt.css: |
+ |
+2011-02-04 Dan Bernstein <mitz@apple.com> |
+ |
+ Reviewed by Darin Adler and Dave Hyatt. |
+ |
+ <rdar://problem/8902704> Make ruby text size 50% by default |
+ https://bugs.webkit.org/show_bug.cgi?id=53723 |
+ |
+ * css/html.css: |
+ (ruby > rt): Changed the font-size from 60% to 50%. |
+ |
+2011-02-04 Antti Koivisto <antti@apple.com> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53610 |
+ Regression: adjacent sibling selector not working as expected |
+ <rdar://problem/8960033> |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53574 |
+ REGRESSION (r76012): :last-child:after not working as expected |
+ <rdar://problem/8948643> |
+ |
+ Test for additional conditions in parent style that prevent sharing. |
+ |
+ Tests: fast/selectors/style-sharing-adjacent-selector.html |
+ fast/selectors/style-sharing-last-child.html |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::parentStylePreventsSharing): |
+ (WebCore::CSSStyleSelector::locateSharedStyle): |
+ |
+2011-02-04 Mark Mentovai <mark@chromium.org> |
+ |
+ Reviewed by Dimitri Glazkov. |
+ |
+ Chromium GYP build fix. |
+ |
+ When various settings were moved to webcore_prerequisites in r66364, |
+ things that should have been direct_dependent_settings were not marked |
+ as such. GYP 'defines', for example, make no sense on a 'none'-type |
+ target such as webcore_prerequisites. It appears that it was intended |
+ for these settings to be pushed to direct dependents, which would make |
+ direct_dependent_settings correct. |
+ |
+ Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused |
+ http://crbug.com/71537, which at best causes Mac console log spew, and |
+ at worst may result in Chromium's copy of WebCore using system |
+ definitions of certain Objective-C classes at runtime, or vice-versa. |
+ |
+ The build now includes a postbuild step to prevent |
+ http://crbug.com/71537 from regressing again. The build will fail upon |
+ regression. |
+ |
+ https://bugs.webkit.org/show_bug.cgi?id=53630 |
+ |
+ * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into |
+ direct_dependent_settings as needed, add the check_objc_rename |
+ postbuild step. |
+ * WebCore.gyp/mac/check_objc_rename.sh: Added. |
+ |
+2011-02-04 Robert Hogan <robert@webkit.org> |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ Move chromium iframe shim code to cross-platform file |
+ https://bugs.webkit.org/show_bug.cgi?id=52594 |
+ |
+ Move Chromium code for identifying and cutting out |
+ iframe shims from plugins to cross-platform utility file |
+ IFrameShimSupport.cpp. |
+ Amend PluginViewQt to use this code to handle shims correctly. |
+ |
+ * WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp |
+ * WebCore.pro: Add Qt support for IFrameShimSupport.cpp |
+ * plugins/IFrameShimSupport.cpp: Added. |
+ (WebCore::getObjectStack): |
+ (WebCore::iframeIsAbovePlugin): |
+ (WebCore::getPluginOcclusions): |
+ * plugins/IFframeShimSupport.h: Added. |
+ * plugins/qt/PluginViewQt.cpp: |
+ (WebCore::PluginView::setNPWindowIfNeeded): |
+ |
+2011-02-04 Xiaomei Ji <xji@chromium.org> |
+ |
+ Reviewed by David Levin. |
+ |
+ Implement "<option> should implement the dir attribute" for chromium port after r76983. |
+ https://bugs.webkit.org/show_bug.cgi?id=50969 |
+ |
+ Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html |
+ added in r76983. |
+ |
+ * platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from |
+ <select> drop-down setting. |
+ (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint |
+ items in drop-down and pass-in bidi override flag when creating text run. |
+ * platform/chromium/PopupMenuChromium.h: Remove directionalityHint from |
+ PopupContainerSettings. |
+ |
+2011-02-04 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Build fix from merge mistake. |
+ |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::ensureEventTargetData): |
+ |
+2011-02-04 Levi Weintraub <leviw@chromium.org> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Remove unneeded function declarations in comments in EditorClient.h |
+ https://bugs.webkit.org/show_bug.cgi?id=53745 |
+ |
+ Removing unused commented out function declarations. No tests since this is just cleanup. |
+ |
+ * page/EditorClient.h: |
+ |
+2011-02-03 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Refactor IDBRequest and IDBTransaction a bit |
+ https://bugs.webkit.org/show_bug.cgi?id=53565 |
+ |
+ There were a lot of subtle issues with the way IDBTransaction |
+ and IDBRequest used to be written. This cleans a lot of them up |
+ and largely simplifies the logic. Using EventQueue rather than |
+ timers is one example of the simplification. |
+ |
+ * bindings/scripts/CodeGeneratorV8.pm: |
+ * dom/EventQueue.cpp: |
+ (WebCore::EventQueue::enqueueEvent): |
+ (WebCore::EventQueue::dispatchEvent): |
+ * storage/IDBCursor.cpp: |
+ (WebCore::IDBCursor::continueFunction): |
+ * storage/IDBRequest.cpp: |
+ (WebCore::IDBRequest::create): |
+ (WebCore::IDBRequest::IDBRequest): |
+ (WebCore::IDBRequest::resetReadyState): |
+ (WebCore::IDBRequest::onError): |
+ (WebCore::IDBRequest::onSuccess): |
+ (WebCore::IDBRequest::dispatchEvent): |
+ (WebCore::IDBRequest::enqueueEvent): |
+ (WebCore::IDBRequest::eventTargetData): |
+ (WebCore::IDBRequest::ensureEventTargetData): |
+ * storage/IDBRequest.h: |
+ (WebCore::IDBRequest::dispatchEvent): |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::create): |
+ (WebCore::IDBTransaction::IDBTransaction): |
+ (WebCore::IDBTransaction::objectStore): |
+ (WebCore::IDBTransaction::abort): |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ (WebCore::IDBTransaction::onTimeout): |
+ (WebCore::IDBTransaction::canSuspend): |
+ (WebCore::IDBTransaction::stop): |
+ (WebCore::IDBTransaction::enqueueEvent): |
+ (WebCore::IDBTransaction::eventTargetData): |
+ (WebCore::IDBTransaction::ensureEventTargetData): |
+ * storage/IDBTransaction.h: |
+ |
+2011-02-01 Jeremy Orlow <jorlow@chromium.org> |
+ |
+ Reviewed by Nate Chapin. |
+ |
+ Remove the timeout event from IndexedDB |
+ https://bugs.webkit.org/show_bug.cgi?id=53521 |
+ |
+ Remove timeout and ontimeout from IDBTransaction per the spec. |
+ |
+ * WebCore.gypi: |
+ * storage/IDBDatabase.cpp: |
+ (WebCore::IDBDatabase::transaction): |
+ * storage/IDBDatabase.h: |
+ (WebCore::IDBDatabase::transaction): |
+ * storage/IDBDatabase.idl: |
+ * storage/IDBDatabaseBackendImpl.cpp: |
+ (WebCore::IDBDatabaseBackendImpl::setVersion): |
+ (WebCore::IDBDatabaseBackendImpl::transaction): |
+ * storage/IDBDatabaseBackendImpl.h: |
+ * storage/IDBDatabaseBackendInterface.h: |
+ * storage/IDBTimeoutEvent.cpp: Removed. |
+ * storage/IDBTimeoutEvent.h: Removed. |
+ * storage/IDBTransaction.cpp: |
+ (WebCore::IDBTransaction::IDBTransaction): |
+ (WebCore::IDBTransaction::onAbort): |
+ (WebCore::IDBTransaction::onComplete): |
+ * storage/IDBTransaction.h: |
+ * storage/IDBTransaction.idl: |
+ * storage/IDBTransactionBackendImpl.cpp: |
+ (WebCore::IDBTransactionBackendImpl::create): |
+ (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): |
+ * storage/IDBTransactionBackendImpl.h: |
+ * storage/IDBTransactionCallbacks.h: |
+ |
+2011-02-04 Chris Fleizach <cfleizach@apple.com> |
+ |
+ Reviewed by Darin Adler. |
+ |
+ AX: Can't set accessibility overridden attributes on web objects |
+ https://bugs.webkit.org/show_bug.cgi?id=53725 |
+ |
+ accessibilitySetOverriddenValue does not work on AX objects from WebCore because |
+ the right method needed to be overridden (accessibilitySupportsOverriddenAttributes). |
+ Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden |
+ attribute only when an AX client asks for it through the AX frameworks. |
+ |
+ * accessibility/mac/AccessibilityObjectWrapper.mm: |
+ (-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]): |
+ |
+2011-02-03 Dimitri Glazkov <dglazkov@chromium.org> |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track. |
+ https://bugs.webkit.org/show_bug.cgi?id=53691 |
+ |
+ Test: fast/repaint/slider-thumb-drag-release.html |
+ |
+ * html/shadow/SliderThumbElement.cpp: |
+ (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure |
+ that the thumb is repainted. |
+ |
+2011-02-04 Mikhail Naganov <mnaganov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: Add "show more" data grid node and waiting message UI components. |
+ https://bugs.webkit.org/show_bug.cgi?id=53763 |
+ |
+ - "show more" data grid node is used for on-demand population of |
+ data grid contents (similar to DOM tree capability for limiting |
+ displayed nodes count); |
+ |
+ - waiting message is used for informing user about long lasting |
+ operations (with a possibility to cancel them). |
+ |
+ * English.lproj/localizedStrings.js: |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * inspector/front-end/PleaseWaitMessage.js: Added. |
+ (WebInspector.PleaseWaitMessage): |
+ * inspector/front-end/ShowMoreDataGridNode.js: Added. |
+ (WebInspector.ShowMoreDataGridNode): |
+ * inspector/front-end/WebKit.qrc: |
+ * inspector/front-end/inspector.css: |
+ (.data-grid button): |
+ (.please-wait-msg): |
+ * inspector/front-end/inspector.html: |
+ |
+2011-02-04 Adele Peterson <adele@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Fix for https://bugs.webkit.org/show_bug.cgi?id=53740 |
+ <rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused |
+ |
+ Tests: |
+ fast/forms/textarea-placeholder-visibility-1.html |
+ fast/forms/textarea-placeholder-visibility-2.html |
+ fast/forms/input-placeholder-visibility-1.html |
+ fast/forms/input-placeholder-visibility-2.html |
+ fast/forms/input-placeholder-visibility-3.html |
+ |
+ * html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible): |
+ Add a check for shouldShowPlaceholderWhenFocused. |
+ * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue): |
+ Whenever the value is updated, we should also update placeholder visibility. |
+ * rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): |
+ Make the default the same as the existing behavior. |
+ * rendering/RenderThemeMac.h: |
+ * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): |
+ Show placeholder when appropriate. |
+ |
+2011-02-04 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: evaluate on hover does not work on a breakpoint. |
+ https://bugs.webkit.org/show_bug.cgi?id=53768 |
+ |
+ * inspector/front-end/SourceFrame.js: |
+ (WebInspector.SourceFrame.prototype._mouseHover): |
+ |
+2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r77625 and r77626. |
+ http://trac.webkit.org/changeset/77625 |
+ http://trac.webkit.org/changeset/77626 |
+ https://bugs.webkit.org/show_bug.cgi?id=53765 |
+ |
+ It broke Windows builds (Requested by Ossy_ on #webkit). |
+ |
+ * Android.jscbindings.mk: |
+ * CMakeLists.txt: |
+ * ForwardingHeaders/pcre/pcre.h: Added. |
+ * ForwardingHeaders/yarr/Yarr.h: Removed. |
+ * ForwardingHeaders/yarr/YarrInterpreter.h: Removed. |
+ * ForwardingHeaders/yarr/YarrPattern.h: Removed. |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.vcproj/copyForwardingHeaders.cmd: |
+ * platform/text/RegularExpression.cpp: |
+ (WebCore::RegularExpression::Private::regexp): |
+ (WebCore::RegularExpression::Private::compile): |
+ (WebCore::RegularExpression::Private::Private): |
+ (WebCore::RegularExpression::Private::create): |
+ (WebCore::RegularExpression::Private::~Private): |
+ (WebCore::RegularExpression::match): |
+ |
+2011-02-04 Peter Varga <pvarga@webkit.org> |
+ |
+ Rubber-stamped by Csaba Osztrogonác. |
+ |
+ Replace PCRE with Yarr in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=53496 |
+ |
+ Speculative windows build fix. |
+ |
+ No new tests needed. |
+ |
+ * platform/text/RegularExpression.cpp: |
+ |
+2011-02-04 Peter Varga <pvarga@webkit.org> |
+ |
+ |
+ Reviewed by Gavin Barraclough. |
+ |
+ Replace PCRE with Yarr in WebCore |
+ https://bugs.webkit.org/show_bug.cgi?id=53496 |
+ |
+ No new tests needed. |
+ |
+ * Android.jscbindings.mk: |
+ * CMakeLists.txt: |
+ * ForwardingHeaders/pcre/pcre.h: Removed. |
+ * ForwardingHeaders/yarr/Yarr.h: Added. |
+ * ForwardingHeaders/yarr/YarrInterpreter.h: Added. |
+ * ForwardingHeaders/yarr/YarrPattern.h: Added. |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.pro: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.vcproj/copyForwardingHeaders.cmd: |
+ * platform/text/RegularExpression.cpp: |
+ (WebCore::RegularExpression::Private::create): |
+ (WebCore::RegularExpression::Private::Private): |
+ (WebCore::RegularExpression::Private::compile): |
+ (WebCore::RegularExpression::match): |
+ |
+2011-02-04 Pavel Feldman <pfeldman@chromium.org> |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Web Inspector: Network panel filtering is broken. |
+ https://bugs.webkit.org/show_bug.cgi?id=53764 |
+ |
+ * inspector/front-end/NetworkPanel.js: |
+ (WebInspector.NetworkPanel.prototype._sortItems): |
+ (WebInspector.NetworkPanel.prototype._sortByTimeline): |
+ (WebInspector.NetworkPanel.prototype._filter): |
+ (WebInspector.NetworkPanel.prototype._updateOffscreenRows): |
+ (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): |
+ (WebInspector.NetworkDataGridNode.prototype.get selectable): |
+ (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): |
+ (WebInspector.NetworkTotalGridNode.prototype.get selectable): |
+ |
+2011-02-04 Andrey Kosyakov <caseq@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: support overriding user agent strings |
+ https://bugs.webkit.org/show_bug.cgi?id=51485 |
+ |
+ Test: http/tests/inspector/extensions-useragent.html |
+ |
+ * inspector/Inspector.idl: |
+ * inspector/InspectorController.cpp: |
+ (WebCore::InspectorController::disconnectFrontend): |
+ (WebCore::InspectorController::setUserAgentOverride): |
+ (WebCore::InspectorController::userAgentOverride): |
+ * inspector/InspectorController.h: |
+ * inspector/front-end/ExtensionAPI.js: |
+ (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload): |
+ * inspector/front-end/ExtensionServer.js: |
+ (WebInspector.ExtensionServer.prototype._onReload): |
+ * loader/FrameLoader.cpp: |
+ (WebCore::FrameLoader::userAgent): |
+ (WebCore::FrameLoader::applyUserAgent): |
+ |
+2011-02-04 Pavel Podivilov <podivilov@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: scripts panel displays wrong file name after reload. |
+ https://bugs.webkit.org/show_bug.cgi?id=53761 |
+ |
+ * inspector/front-end/ScriptsPanel.js: |
+ (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): |
+ |
+2011-02-03 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Web Inspector: remove settings related methods from InspectorClient |
+ https://bugs.webkit.org/show_bug.cgi?id=53686 |
+ |
+ * WebCore.exp.in: |
+ * inspector/CodeGeneratorInspector.pm: |
+ * inspector/InspectorClient.h: |
+ * inspector/InspectorFrontendClientLocal.cpp: |
+ (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): |
+ (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): |
+ (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight): |
+ * inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can |
+ provide platform-specific settings accessor. |
+ (WebCore::InspectorFrontendClientLocal::Settings::Settings): |
+ (WebCore::InspectorFrontendClientLocal::Settings::~Settings): |
+ (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): |
+ (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight): |
+ * loader/EmptyClients.h: |
+ |
+2011-02-03 Anton Muhin <antonm@chromium.org> |
+ |
+ Reviewed by Adam Barth. |
+ |
+ [v8] frame several more JS code invocations into v8::TryCatch |
+ https://bugs.webkit.org/show_bug.cgi?id=53594 |
+ |
+ This patch is preemptive and adjusts v8 bindings code to forthcoming small change |
+ in v8::ThrowException---currently sometimes exceptions thrown by this method |
+ do not reach surrounding v8::TryCatch handler (see |
+ http://code.google.com/p/v8/issues/detail?id=1072 and |
+ http://codereview.chromium.org/6397011/). Therefore the goal of this patch |
+ is to make forthcoming v8 roll as smooth as possible (alas, we'll still need |
+ one rebaseline as of now.) |
+ |
+ * bindings/v8/V8Proxy.cpp: |
+ (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead |
+ * bindings/v8/V8WindowErrorHandler.cpp: |
+ (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto |
+ |
+2011-02-03 Maciej Stachowiak <mjs@apple.com> |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle |
+ https://bugs.webkit.org/show_bug.cgi?id=52897 |
+ <rdar://problem/8898294> |
+ |
+ * WebCore.exp.in: Add export now needed by WebKit2 |
+ |
2011-02-03 Victoria Kirst <vrk@google.com> |
Reviewed by James Robinson. |