Issue 6466001: Add ability to pass a private_key when generating a payload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6466001: Add ability to pass a private_key when generating a payload. (Closed)

Created:
9 years, 10 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
dgarrett

CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis

Base URL:
http://git.chromium.org/git/dev-util.git@master

Visibility:
Public.

Description

Add ability to pass a private_key when generating a payload. Also fix bug in symlink detection to use lexists rather than exists. BUG=chromium-os:8212 TEST=Ran it with valid and invalid files and saw them get passed to generate using ./start_dev_server Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0f1ec84

Patch Set 1 #

Patch Set 2 : Use "%s" #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	autoupdate.py	View	1	3 chunks	+17 lines, -13 lines	0 comments	Download
	M	devserver.py	View		3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

Also refactored GenerateUpdateFile to use array logic rather than strings to make it cleaner.

9 years, 10 months ago (2011-02-09 01:06:56 UTC) #1

dgarrett

I'm assuming this one is dead now and should be closed?

9 years, 10 months ago (2011-02-10 19:23:24 UTC) #3

sosa

9 years, 10 months ago (2011-02-10 19:25:03 UTC) #4

No I just haven't committed it yet :)

On Thu, Feb 10, 2011 at 11:23 AM,  <dgarrett@chromium.org> wrote:
> I'm assuming this one is dead now and should be closed?
>
> http://codereview.chromium.org/6466001/
>

Expand Messages | Collapse Messages