Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 6465023: Fix an assertion failure in stack trace construction. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix an assertion failure in stack trace construction. When constructing stack traces we interpret the deoptimization data for optimized frames to find the receiver value. This value could sometimes be eliminated from the deoptimization data if we though it was unused. BUG=v8:1118 Committed: http://code.google.com/p/v8/source/detail?r=6694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -19 lines) Patch
M src/hydrogen.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -11 lines 0 comments Download
A test/mjsunit/regress/regress-1118.js View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-09 11:17:36 UTC) #1
fschneider
9 years, 10 months ago (2011-02-09 11:36:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698