Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: bin/ctest.py

Issue 6465014: Switch ctest to array/appends for cros_au_test_harness call (Closed) Base URL: http://git.chromium.org/git/crosutils.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/ctest.py
diff --git a/bin/ctest.py b/bin/ctest.py
index f675dfd2c156c57f5ebba7022765d244a874f413..9388eaa225bc44cdd3be4d9d968e111209261578 100755
--- a/bin/ctest.py
+++ b/bin/ctest.py
@@ -257,24 +257,23 @@ def RunAUTestHarness(board, channel, latest_url_base, zip_server_base,
zip_url = GetLatestZipUrl(board, channel, latest_url_base, zip_server_base)
GrabZipAndExtractImage(zip_url, download_folder, _IMAGE_TO_EXTRACT)
- no_graphics_flag = ''
- if no_graphics: no_graphics_flag = '--no_graphics'
-
# Tests go here.
latest_image = RunCommand(['./get_latest_image.sh', '--board=%s' % board],
cwd=crosutils_root, redirect_stdout=True,
print_cmd=True).strip()
- RunCommand(['bin/cros_au_test_harness',
- '--base_image=%s' % os.path.join(download_folder,
- _IMAGE_TO_EXTRACT),
- '--target_image=%s' % os.path.join(latest_image,
- _IMAGE_TO_EXTRACT),
- no_graphics_flag,
- '--board=%s' % board,
- '--type=%s' % type,
- '--remote=%s' % remote,
- ], cwd=crosutils_root)
+ cmd = ['bin/cros_au_test_harness',
+ '--base_image=%s' % os.path.join(download_folder,
+ _IMAGE_TO_EXTRACT),
+ '--target_image=%s' % os.path.join(latest_image,
+ _IMAGE_TO_EXTRACT),
+ '--board=%s' % board,
+ '--type=%s' % type,
+ '--remote=%s' % remote,
+ ]
+ if no_graphics: cmd.append('--no_graphics')
+
+ RunCommand(cmd, cwd=crosutils_root)
def main():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698