[Sync] Initial support for encrypting any datatype (no UI hookup yet).

chrome/browser/sync/profile_sync_service_harness.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/message_loop.h"
@@ skipping 270 matching lines @@
     case FULLY_SYNCED: {
       // The client is online and fully synced. There is nothing to do.
       LogClientInfo("FULLY_SYNCED");
       break;
     }
     case SYNC_DISABLED: {
       // Syncing is disabled for the client. There is nothing to do.
       LogClientInfo("SYNC_DISABLED");
       break;
     }
+    case WAITING_FOR_ENCRYPTION: {
+      // Sync has finished encrypting the datatypes. There is nothing to do.

[Raghu Simha, 2011/02/14 05:29:52]

This seems wrong. Just because you're in RunStateChangeMachine() in the
WAITING_FOR_ENCRYPTION state doesn't necessarily mean that encryption is
complete. I'd imagine this state would be implemented similar to
WAITING_FOR_INITIAL_SYNC, where you check if a condition is satisfied before
calling SignalStateCompleteWithNextState. In this case, I'd imagine the
condition to be IsTypeEncrypted(), although you'd need to devise a way of
knowing which type you're waiting on.

[Nicolas Zea, 2011/02/14 21:18:41]

Done.

+      LogClientInfo("WAITING_FOR_ENCRYPTION");
+      SignalStateCompleteWithNextState(FULLY_SYNCED);
+      break;
+    }
     default:
       // Invalid state during observer callback which may be triggered by other
       // classes using the the UI message loop.  Defer to their handling.
       break;
   }
   return original_wait_state != wait_state_;
 }
 
 void ProfileSyncServiceHarness::OnStateChanged() {
   RunStateChangeMachine();
@@ skipping 289 matching lines @@
               << ", service_is_pushing_changes: " << ServiceIsPushingChanges();
     } else {
       VLOG(1) << "Client " << id_ << ": " << message
               << ": Sync session snapshot not available.";
     }
   } else {
     VLOG(1) << "Client " << id_ << ": " << message
             << ": Sync service not available.";
   }
 }
+
+bool ProfileSyncServiceHarness::EnableEncryptionForType(
+    syncable::ModelType type) {
+  syncable::ModelTypeSet encrypted_types;
+  service_->GetEncryptedDataTypes(&encrypted_types);
+  encrypted_types.insert(type);
+  service_->EncryptDataTypes(encrypted_types);
+
+  // Wait some time to let the enryption finish.
+  std::string reason = "Waiting for encryption.";
+  wait_state_ = WAITING_FOR_ENCRYPTION;
+  if (!AwaitStatusChangeWithTimeout(kLiveSyncOperationTimeoutMs, reason)) {
+    LOG(ERROR) << "Did not receive EncryptionComplete notification after"
+               << kLiveSyncOperationTimeoutMs / 1000
+               << " seconds.";
+    return false;
+  }
+
+  syncable::ModelTypeSet newly_encrypted_types;
+  service_->GetEncryptedDataTypes(&newly_encrypted_types);
+  if (newly_encrypted_types != encrypted_types) {
+    return false;
+  }

[Raghu Simha, 2011/02/14 05:29:52]

The above block seems to be doing the same as IsTypeEncrypted(). Why not replace
it with a call to the method?

[Nicolas Zea, 2011/02/14 21:18:41]

Done.

+
+  return true;
+}
+
+bool ProfileSyncServiceHarness::IsTypeEncrypted(syncable::ModelType type) {
+  syncable::ModelTypeSet encrypted_types;
+  service_->GetEncryptedDataTypes(&encrypted_types);
+  if (encrypted_types.count(type) == 0) {
+    return false;
+  }
+  return true;
+}