Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 6463025: Make optimized Function.prototype.apply safe for non-JSObject first arguments. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make optimized Function.prototype.apply safe for non-JSObject first arguments. If we have a property access of the form this.x, where the access site sees the global object, we can specialize the IC stub so that it performs a map check without first performing a heap object check. Ensure that we do not get in JS code with a non-JSObject this value by deoptimizing at Function.prototype.apply if the first argument is not a JSObject. BUG=v8:1128 Committed: http://code.google.com/p/v8/source/detail?r=6707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/compiler/regress-arguments.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-09 16:23:42 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-09 16:39:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698