Add support for base::Closure in the MessageLoop.

chrome/renderer/renderer_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if defined(OS_MACOSX)
 #include <signal.h>
 #include <unistd.h>
 #endif  // OS_MACOSX
 
 #include "base/command_line.h"
@@ skipping 200 matching lines @@
 // This is a simplified version of the browser Jankometer, which measures
 // the processing time of tasks on the render thread.
 class RendererMessageLoopObserver : public MessageLoop::TaskObserver {
  public:
   RendererMessageLoopObserver()
       : process_times_(base::Histogram::FactoryGet(
             "Chrome.ProcMsgL RenderThread",
             1, 3600000, 50, base::Histogram::kUmaTargetedHistogramFlag)) {}
   virtual ~RendererMessageLoopObserver() {}
 
-  virtual void WillProcessTask(const Task* task) {
+  virtual void WillProcessTask(base::TimeTicks time_posted) {
     begin_process_message_ = base::TimeTicks::Now();
   }
 
-  virtual void DidProcessTask(const Task* task) {
+  virtual void DidProcessTask(base::TimeTicks time_posted) {
     if (begin_process_message_ != base::TimeTicks())

[joth, 2011/04/16 15:11:57]

suggest
if (begin_process_message_.is_null())

(also, it looks odd to me passing class TimeTicks by value rather than const
ref, but it seems to be standard practice)

[awong, 2011/04/17 00:34:57]

Ooh...good catch.

As for TimeTicks being passed by value, it's designed to be done that way. The
data member is just one int64, so pass by value ends up more efficient than by
const ref.

On 2011/04/16 15:11:57, joth wrote:

       process_times_->AddTime(base::TimeTicks::Now() - begin_process_message_);
   }
 
  private:
   base::TimeTicks begin_process_message_;
   base::Histogram* const process_times_;
   DISALLOW_COPY_AND_ASSIGN(RendererMessageLoopObserver);
 };
 
 // mainline routine for running as the Renderer process
@@ skipping 126 matching lines @@
         pool->Recycle();
       TRACE_EVENT_BEGIN("RendererMain.START_MSG_LOOP", 0, 0);
       MessageLoop::current()->Run();
       TRACE_EVENT_END("RendererMain.START_MSG_LOOP", 0, 0);
     }
   }
   platform.PlatformUninitialize();
   TRACE_EVENT_END("RendererMain", 0, "");
   return 0;
 }