Use GC-safe version when setting elements.

Use GC-safe version when setting elements.

BUG=1125
TEST=test/mjsunit/regress/regress-1125.js

Committed: http://code.google.com/p/v8/source/detail?r=6693

[antonm, 2011-02-08 20:46:22]

Mads,

may you have a look?

[Mads Ager (chromium), 2011-02-09 07:03:36]

LGTM!

http://codereview.chromium.org/6463001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6463001/diff/1/src/runtime.cc#newcode7394
src/runtime.cc:7394: Handle<Context>::cast(holder)->set(index, *value);
Do you know that this one cannot fail? Code that is a handle non-handle mix is
always scary. Let's do this one in a GC safe way as well.

[antonm, 2011-02-09 11:38:09]

http://codereview.chromium.org/6463001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6463001/diff/1/src/runtime.cc#newcode7394
src/runtime.cc:7394: Handle<Context>::cast(holder)->set(index, *value);
Agree, but in this case I am afraid we cannot use SetElement as a context is a
fixed array actually.  Good news is set should be GC safe.  I slightly reworked
this line (to have lesser mixture of handles and non-handles stuff) and added a
comment explaining why it's safe.

On 2011/02/09 07:03:36, Mads Ager wrote:
> Do you know that this one cannot fail? Code that is a handle non-handle mix is
> always scary. Let's do this one in a GC safe way as well.