Chromium Code Reviews| Index: src/assembler.h |
| =================================================================== |
| --- src/assembler.h (revision 6680) |
| +++ src/assembler.h (working copy) |
| @@ -467,21 +467,22 @@ |
| class ExternalReference BASE_EMBEDDED { |
| public: |
| // Used in the simulator to support different native api calls. |
| - // |
| - // BUILTIN_CALL - builtin call. |
| - // MaybeObject* f(v8::internal::Arguments). |
| - // |
| - // FP_RETURN_CALL - builtin call that returns floating point. |
| - // double f(double, double). |
| - // |
| - // DIRECT_CALL - direct call to API function native callback |
| - // from generated code. |
| - // Handle<Value> f(v8::Arguments&) |
| - // |
| enum Type { |
| + // Builtin call. |
| + // MaybeObject* f(v8::internal::Arguments). |
| BUILTIN_CALL, // default |
| + |
| + // Builtin call that returns floating point. |
| + // double f(double, double). |
| FP_RETURN_CALL, |
| - DIRECT_CALL |
| + |
| + // Direct call to API function callback. |
| + // Handle<Value> f(v8::Arguments&) |
| + DIRECT_API_CALL, |
|
antonm
2011/02/17 16:13:44
again question about DIRECT, maybe just drop it, b
Zaheer
2011/02/21 10:25:35
keeping it for now to differentiate from builtin.
|
| + |
| + // Direct call to accessor getter callback. |
| + // Handle<value> f(Local<String> property, AccessorInfo& info) |
| + DIRECT_LOAD_CALL |
|
antonm
2011/02/17 16:13:44
Please, do not use load and use getter or callback
Zaheer
2011/02/21 10:25:35
Done.
|
| }; |
| typedef void* ExternalReferenceRedirector(void* original, Type type); |