Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 6462019: Port wpo.patch to ICU 4.6 ... (Closed)

Created:
9 years, 10 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Port wpo.patch to ICU 4.6 udata.c is replaced by udata.cpp. Besides, I'm just adding eol styles to a few patch files. See also: http://bugs.icu-project.org/trac/ticket/8043 http://bugs.icu-project.org/trac/ticket/5701 BUG==61514 TEST=Build an official build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -49 lines) Patch
M icu46/patches/locale2.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
M icu46/patches/locale3.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
M icu46/patches/unihan.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
A + icu46/patches/wpo.patch View 2 chunks +27 lines, -18 lines 0 comments Download
M icu46/source/common/ucmndata.h View 1 chunk +14 lines, -0 lines 0 comments Download
M icu46/source/common/udata.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M icu46/source/stubdata/stubdata.c View 1 chunk +20 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
9 years, 10 months ago (2011-02-09 01:39:19 UTC) #1
jungshik at Google
9 years, 10 months ago (2011-02-09 01:55:10 UTC) #2
M-A Ruel
I'm not sure I'm the one the most qualified to review this change. I can ...
9 years, 10 months ago (2011-02-09 02:56:16 UTC) #3
jungshik at Google
On 2011/02/09 02:56:16, Marc-Antoine Ruel wrote: > I'm not sure I'm the one the most ...
9 years, 10 months ago (2011-02-09 18:33:16 UTC) #4
jungshik at Google
9 years, 10 months ago (2011-02-10 23:18:36 UTC) #5
Andy said that it looks good to me. 

The previous version of this patch was uploaded to
http://bugs.icu-project.org/trac/ticket/8043
That bug was duped to http://bugs.icu-project.org/trac/ticket/5701 
Once ICU bug 5701 is resolved, we can revisit the issue. 


On 2011/02/09 18:33:16, Jungshik Shin wrote:
> On 2011/02/09 02:56:16, Marc-Antoine Ruel wrote:
> > I'm not sure I'm the one the most qualified to review this change. I can
> > rubberstamp it if you want but that's mostly it.
> 
> I thought you're qualified because you  made wpo.patch. I'll also check with
> Andy (who you discussed the issue with in the past).

Powered by Google App Engine
This is Rietveld 408576698