Run TPM timing test to completion instead of stopping at the first error.

Run TPM timing test to completion instead of stopping at the first error.

Change-Id: Iae764bfeb2c766abb550f338db3d35d1d7eebf1d

BUG=433
TEST=compiled and ran.  (QA NOTE: no testing required)

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0d2d139

[Luigi Semenzato, 2011-02-08 22:54:09]

I needed to make this test more useful.  Thanks!

[Randall Spangler, 2011-02-08 23:03:44]

http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c
File tests/tpm_lite/timing.c (right):

http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c#newcode31
tests/tpm_lite/timing.c:31: printf(#op ": error 0x%x\n", __result);             
             \
Suggest incrementing an errors count here.

errors++;

http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c#newcode47
tests/tpm_lite/timing.c:47: 
int errors = 0;

http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c#newcode59
tests/tpm_lite/timing.c:59: if (time_limit_exceeded) {
if (time_limit_exceeded || errors > 0)

This way you won't say "test succeeded" if there were indeed errors.

[Luigi Semenzato, 2011-02-10 00:04:59]

Thanks for the suggestions, PTAL.

On 2011/02/08 23:03:44, Randall Spangler wrote:
> http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c
> File tests/tpm_lite/timing.c (right):
> 
>
http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c#newcode31
> tests/tpm_lite/timing.c:31: printf(#op ": error 0x%x\n", __result);           
 
>              \
> Suggest incrementing an errors count here.
> 
> errors++;
> 
>
http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c#newcode47
> tests/tpm_lite/timing.c:47: 
> int errors = 0;
> 
>
http://codereview.chromium.org/6462013/diff/1/tests/tpm_lite/timing.c#newcode59
> tests/tpm_lite/timing.c:59: if (time_limit_exceeded) {
> if (time_limit_exceeded || errors > 0)
> 
> This way you won't say "test succeeded" if there were indeed errors.

[Luigi Semenzato, 2011-02-10 18:12:05]

Ping.  Sorry for the bother, Infineon would like this and I prefer to have it in
the repo rather than sending them a drop.

[Randall Spangler, 2011-02-10 19:28:05]

LGTM assuming you fix the typo :)

http://codereview.chromium.org/6462013/diff/5001/tests/tpm_lite/timing.c
File tests/tpm_lite/timing.c (right):

http://codereview.chromium.org/6462013/diff/5001/tests/tpm_lite/timing.c#newc...
tests/tpm_lite/timing.c:32: error++;                                            
             \
errors++