Issue 6462010: Support dev vs consumer firmware in vboot_reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6462010: Support dev vs consumer firmware in vboot_reference (Closed)

Created:
9 years, 10 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Support dev vs consumer firmware in vboot_reference Change-Id: I5a42ba017974b3d591abc574ef7b9b7c9ac579e8 BUG=chrome-os-partner:1824 TEST=make && make runtests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8e0f94

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -7 lines)			Patch
M	firmware/include/load_kernel_fw.h	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	firmware/lib/vboot_firmware.c	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	firmware/lib/vboot_kernel.c	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	firmware/stub/load_firmware_stub.c	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	utility/load_kernel_test.c	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

gauravsh

9 years, 10 months ago (2011-02-09 20:28:26 UTC) #2

LGTM

(It would be nice to have a test which verifies that the boot paths are
correctly followed for different values of the flags)