Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 6461028: Reapply http://code.google.com/p/v8/source/detail?r=6555 (Closed)

Created:
9 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Reapply http://code.google.com/p/v8/source/detail?r=6555 Compare JSObjects by identity immediately. When invoking EQUALS JS builtin, 1st argument is passed as a receiver and if it's a global object, it gets overwritten with global proxy object and thus one gets incorrect results. BUG=v8:1082 TBR=ricow@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
TBRing to you, Rico.
9 years, 10 months ago (2011-02-09 19:12:16 UTC) #1
Rico
9 years, 10 months ago (2011-02-10 06:45:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698