Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 6461023: Fix up mac test client and simple host for remoting. (Closed)

Created:
9 years, 10 months ago by dmac
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, brettw-cc_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix up mac test client and simple host for remoting. Remoting's test client and simple host weren't initializing the NSApplication correctly which is required for MessageLoops to work on the Mac. These are just test apps that we use, so I felt it was ok to bring in code from base/test. Also added a check to message_pump_mac.mm to verify that NSApp is initialized before we attempt to use it. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M base/message_pump_mac.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M remoting/host/simple_host_process.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/protocol/protocol_test_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmac
Mark, could you take a look at the message_pump code. Sergey, could you eyeball the ...
9 years, 10 months ago (2011-02-09 16:41:43 UTC) #1
Mark Mentovai
LGTM
9 years, 10 months ago (2011-02-09 17:17:04 UTC) #2
dmac
added gary
9 years, 10 months ago (2011-02-09 18:02:03 UTC) #3
garykac
On 2011/02/09 18:02:03, dmac wrote: > added gary LGTM
9 years, 10 months ago (2011-02-09 18:05:52 UTC) #4
Sergey Ulanov
9 years, 10 months ago (2011-02-09 18:22:43 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698