Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 6461022: Merge a number of assertion failure fixes to the 3.0 branch. (Closed) Base URL: http://v8.googlecode.com/svn/branches/3.0/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 frame_->Exit(); 2185 frame_->Exit();
2186 2186
2187 // Here we use masm_-> instead of the __ macro to avoid the code coverage 2187 // Here we use masm_-> instead of the __ macro to avoid the code coverage
2188 // tool from instrumenting as we rely on the code size here. 2188 // tool from instrumenting as we rely on the code size here.
2189 int32_t sp_delta = (scope()->num_parameters() + 1) * kPointerSize; 2189 int32_t sp_delta = (scope()->num_parameters() + 1) * kPointerSize;
2190 masm_->add(sp, sp, Operand(sp_delta)); 2190 masm_->add(sp, sp, Operand(sp_delta));
2191 masm_->Jump(lr); 2191 masm_->Jump(lr);
2192 DeleteFrame(); 2192 DeleteFrame();
2193 2193
2194 #ifdef DEBUG 2194 #ifdef DEBUG
2195 // Check that the size of the code used for returning matches what is 2195 // Check that the size of the code used for returning is large enough
2196 // expected by the debugger. If the sp_delts above cannot be encoded in 2196 // for the debugger's requirements.
2197 // the add instruction the add will generate two instructions. 2197 ASSERT(Assembler::kJSReturnSequenceInstructions <=
2198 int return_sequence_length = 2198 masm_->InstructionsGeneratedSince(&check_exit_codesize));
2199 masm_->InstructionsGeneratedSince(&check_exit_codesize);
2200 CHECK(return_sequence_length ==
2201 Assembler::kJSReturnSequenceInstructions ||
2202 return_sequence_length ==
2203 Assembler::kJSReturnSequenceInstructions + 1);
2204 #endif 2199 #endif
2205 } 2200 }
2206 } 2201 }
2207 2202
2208 2203
2209 void CodeGenerator::VisitWithEnterStatement(WithEnterStatement* node) { 2204 void CodeGenerator::VisitWithEnterStatement(WithEnterStatement* node) {
2210 #ifdef DEBUG 2205 #ifdef DEBUG
2211 int original_height = frame_->height(); 2206 int original_height = frame_->height();
2212 #endif 2207 #endif
2213 Comment cmnt(masm_, "[ WithEnterStatement"); 2208 Comment cmnt(masm_, "[ WithEnterStatement");
(...skipping 5155 matching lines...) Expand 10 before | Expand all | Expand 10 after
7369 BinaryOpIC::GetName(runtime_operands_type_)); 7364 BinaryOpIC::GetName(runtime_operands_type_));
7370 return name_; 7365 return name_;
7371 } 7366 }
7372 7367
7373 7368
7374 #undef __ 7369 #undef __
7375 7370
7376 } } // namespace v8::internal 7371 } } // namespace v8::internal
7377 7372
7378 #endif // V8_TARGET_ARCH_ARM 7373 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | src/ia32/macro-assembler-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698