Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6461022: Merge a number of assertion failure fixes to the 3.0 branch. (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge a number of assertion failure fixes to the 3.0 branch. Committed: http://code.google.com/p/v8/source/detail?r=6710

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -117 lines) Patch
M src/api.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/builtins.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/handles.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +22 lines, -13 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 3 chunks +13 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 4 chunks +25 lines, -5 lines 1 comment Download
M src/messages.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 5 chunks +25 lines, -12 lines 0 comments Download
M src/parser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parser.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M src/runtime.cc View 9 chunks +50 lines, -12 lines 0 comments Download
M src/scanner.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +23 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/regress-arguments.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/mjsunit/getter-in-prototype.js View 2 chunks +8 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-1103.js View 0 chunks +-1 lines, --1 lines 1 comment Download
A + test/mjsunit/regress/regress-1104.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1105.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1107.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1110.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1112.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1118.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1119.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1120.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1121.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1122.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1125.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/regress/regress-1126.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
Please carefully review this. The change looks bigger than it is. Mostly very simple assertion ...
9 years, 10 months ago (2011-02-09 16:58:57 UTC) #1
antonm
My part LGTM http://codereview.chromium.org/6461022/diff/5007/test/mjsunit/regress/regress-1103.js File test/mjsunit/regress/regress-1103.js (right): http://codereview.chromium.org/6461022/diff/5007/test/mjsunit/regress/regress-1103.js#newcode32 test/mjsunit/regress/regress-1103.js:32: obj = Object.freeze(obj); Hmm, codereview reports ...
9 years, 10 months ago (2011-02-09 17:09:31 UTC) #2
Vyacheslav Egorov (Chromium)
My part LGTM
9 years, 10 months ago (2011-02-09 17:21:03 UTC) #3
fschneider
LGTM from my side.
9 years, 10 months ago (2011-02-09 17:40:50 UTC) #4
Rico
9 years, 10 months ago (2011-02-10 06:58:20 UTC) #5 
LGTM

http://codereview.chromium.org/6461022/diff/5007/src/ia32/macro-assembler-ia3...
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/6461022/diff/5007/src/ia32/macro-assembler-ia3...
src/ia32/macro-assembler-ia32.cc:1591: 
Remove two blank lines

Powered by Google App Engine
This is Rietveld 408576698