Add a genuine unary minus instruction to Crankshaft....

src/ia32/lithium-codegen-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1003 matching lines @@
 }
 
 
 void LCodeGen::DoBitNotI(LBitNotI* instr) {
   LOperand* input = instr->InputAt(0);
   ASSERT(input->Equals(instr->result()));
   __ not_(ToRegister(input));
 }
 
 
+void LCodeGen::DoNegI(LNegI* instr) {
+  Register input = ToRegister(instr->InputAt(0));
+  if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
+    __ test(eax, Operand(eax));

[Kevin Millikin (Chromium), 2011/02/11 12:12:59]

eax ==> input?

[fschneider, 2011/02/11 12:44:12]

Thanks, of course. 

+    DeoptimizeIf(zero, instr->environment());
+  }
+  __ neg(input);
+  if (instr->hydrogen()->CheckFlag(HValue::kCanOverflow)) {
+    DeoptimizeIf(overflow, instr->environment());
+  }
+}
+
+
+void LCodeGen::DoNegD(LNegD* instr) {
+  XMMRegister reg = ToDoubleRegister(instr->InputAt(0));
+  Register temp = ToRegister(instr->TempAt(0));
+  __ Set(temp, Immediate(0x80000000));
+  __ movd(xmm0, Operand(temp));
+  __ psllq(xmm0, 32);

[Kevin Millikin (Chromium), 2011/02/11 12:12:59]

Gesundheit.

[Vitaly Repeshko, 2011/02/11 17:17:56]

It might be faster to load the minus zero constant instead (we already have it:
ExternalReference::address_of_minus_zero) because it doesn't need an extra
general purpose register.

+  __ xorpd(reg, xmm0);
+}
+
+
+void LCodeGen::DoNegT(LNegT* instr) {
+  UnaryOverwriteMode overwrite = UNARY_NO_OVERWRITE;
+  GenericUnaryOpStub stub(Token::SUB, overwrite, NO_UNARY_FLAGS);
+  CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
+}
+
+
 void LCodeGen::DoThrow(LThrow* instr) {
   __ push(ToOperand(instr->InputAt(0)));
   CallRuntime(Runtime::kThrow, 1, instr);
 
   if (FLAG_debug_code) {
     Comment("Unreachable code.");
     __ int3();
   }
 }
 
@@ skipping 2672 matching lines @@
   ASSERT(osr_pc_offset_ == -1);
   osr_pc_offset_ = masm()->pc_offset();
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32