Fixed chromite shell to report python errors

Fixed chromite shell to report python errors

Errors in imported modules (where they are found but are broken) were being
reported as import errors. This fixes that behavior.

BUG=chromium-os:11785
TEST=try outside environment and make sure it detects error
try with a python error in main.py and check that it raises properly

Change-Id: Ic8a9fe75399832ed7c2faeb39360d5f9dc45e944

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1c6020f

[sjg, 2011-02-09 00:55:08]

I have split this CL off as suggested by Doug

[diandersAtChromium, 2011-02-09 19:46:01]

Simon: thanks for splitting out!  :)

I'm still not understanding why the [-10:] is important.  Can you give me an
example?

http://codereview.chromium.org/6461009/diff/1/bin/chromite
File bin/chromite (right):

http://codereview.chromium.org/6461009/diff/1/bin/chromite#newcode61
bin/chromite:61: # The full error is 'No module named (chromite.)shell.main'
Simon: can you give me an example of the error string where the [-10:] would
matter?  In other words: what is the error message that inspired the check only
for the last 10 characters?

[sjg, 2011-02-09 21:31:46]

Hi,

If I put an error in operation.py and run chromite, printing out the
exceptions it sees, I get:

sjg@kiwi:~/cosarm/src/scripts$ ../../chromite/bin/chromite
No module named shell.main
No module named chromite.shell.main
cannot import name Colord
No module named chromite.shell.main
No module named chromite.shell.main
No module named chromite.shell.main
No module named chromite.shell.main
No module named chromite.shell.main
No module named chromite.shell.main
ERROR: Couldn't find the chromite tool.

It is the top one that I wanted to guard against.

Regards,
Simon

On Wed, Feb 9, 2011 at 11:46 AM,  <dianders@chromium.org> wrote:
> Simon: thanks for splitting out!  :)
>
> I'm still not understanding why the [-10:] is important.  Can you give me an
> example?
>
>
> http://codereview.chromium.org/6461009/diff/1/bin/chromite
> File bin/chromite (right):
>
> http://codereview.chromium.org/6461009/diff/1/bin/chromite#newcode61
> bin/chromite:61: # The full error is 'No module named
> (chromite.)shell.main'
> Simon: can you give me an example of the error string where the [-10:]
> would matter?  In other words: what is the error message that inspired
> the check only for the last 10 characters?
>
> http://codereview.chromium.org/6461009/
>

[diandersAtChromium, 2011-02-09 22:14:34]

Ah, makes sense.  Didn't realize that we were getting a slightly different
error when in src/scripts.  Ick.

Can you put the example failure in the comment?  ...also, can you use
"endswith" instead of [-10:]?

...other than those two nits, LGTM.  Thanks for all your work on this!  :)
:) :)

-Doug

---

On Wed, Feb 9, 2011 at 1:31 PM, Simon Glass <sjg@chromium.org> wrote:

> Hi,
>
> If I put an error in operation.py and run chromite, printing out the
> exceptions it sees, I get:
>
> sjg@kiwi:~/cosarm/src/scripts$ ../../chromite/bin/chromite
> No module named shell.main
> No module named chromite.shell.main
> cannot import name Colord
> No module named chromite.shell.main
> No module named chromite.shell.main
> No module named chromite.shell.main
> No module named chromite.shell.main
> No module named chromite.shell.main
> No module named chromite.shell.main
> ERROR: Couldn't find the chromite tool.
>
> It is the top one that I wanted to guard against.
>
> Regards,
> Simon
>
> On Wed, Feb 9, 2011 at 11:46 AM,  <dianders@chromium.org> wrote:
> > Simon: thanks for splitting out!  :)
> >
> > I'm still not understanding why the [-10:] is important.  Can you give me
> an
> > example?
> >
> >
> > http://codereview.chromium.org/6461009/diff/1/bin/chromite
> > File bin/chromite (right):
> >
> > http://codereview.chromium.org/6461009/diff/1/bin/chromite#newcode61
> > bin/chromite:61: # The full error is 'No module named
> > (chromite.)shell.main'
> > Simon: can you give me an example of the error string where the [-10:]
> > would matter?  In other words: what is the error message that inspired
> > the check only for the last 10 characters?
> >
> > http://codereview.chromium.org/6461009/
> >
>

[sjg, 2011-02-09 22:23:08]

PTAL to check - thanks, Simon

[diandersAtChromium, 2011-02-10 00:31:21]

LGTM!