Issue 6461001: Revert 73222 - Make target running GLES2 autogen script....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6461001: Revert 73222 - Make target running GLES2 autogen script.... (Closed)

Created:
9 years, 10 months ago by gavinp

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, neb

CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 73222 - Make target running GLES2 autogen script. Also lays groundwork for rebuilding Pepper OpenGL ES bindings as part of the build. BUG=none TEST=run "make ppapi_gles_bindings" or "make ppapi_gles_implementation". Review URL: http://codereview.chromium.org/5212006 TBR=neb@chromium.org This change was causing just building to create merge conflicts in clean repos. Either these targets shouldn't be part of standard build targets like "chrome" or "unit_tests", or we shouldn't have build targets which generate output into the working tree... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74161

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -71 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	2 chunks	+2 lines, -17 lines	0 comments	Download
M	ppapi/ppapi_gl.gypi	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gavinp

This change was causing me merge conflicts many times a day.

9 years, 10 months ago (2011-02-08 20:11:38 UTC) #2

Mark Mentovai

LGTM. Ref. http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/64c8463af123c9d3

9 years, 10 months ago (2011-02-08 20:18:22 UTC) #3

neb

9 years, 10 months ago (2011-02-08 20:40:25 UTC) #4

LGTM

On 2011/02/08 20:18:22, Mark Mentovai wrote:
> LGTM.
> 
> Ref.
>
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

Expand Messages | Collapse Messages