Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 646076: Bookmark manager drag and drop frontend (Closed)

Created:
10 years, 10 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
Reviewers:
feldstein
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Bookmark manager drag and drop. This is the HTML part of http://codereview.chromium.org/596105 BUG=4890 TEST=Try the following: Dragging and dropping within the bookmark manager Dragging and dropping from/to the bookmark bar Dragging and dropping from/to the old bookmark manager Dragging and dropping from/to the bookmark manager from another instance of Chrome. This should copy the items instead of moving them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39631

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -159 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm/bookmarklist.js View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/main.html View 1 2 3 22 chunks +156 lines, -158 lines 2 comments Download
M chrome/browser/resources/bookmark_manager/manifest.json View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
Mike, I think this is ready for review. I'll submit the backend today so this ...
10 years, 10 months ago (2010-02-20 01:04:15 UTC) #1
feldstein
LGTM with one small question http://codereview.chromium.org/646076/diff/3002/3003 File chrome/browser/resources/bookmark_manager/main.html (right): http://codereview.chromium.org/646076/diff/3002/3003#newcode710 chrome/browser/resources/bookmark_manager/main.html:710: return true; Will this ...
10 years, 10 months ago (2010-02-22 19:13:58 UTC) #2
arv (Not doing code reviews)
10 years, 10 months ago (2010-02-22 19:42:09 UTC) #3
http://codereview.chromium.org/646076/diff/3002/3003
File chrome/browser/resources/bookmark_manager/main.html (right):

http://codereview.chromium.org/646076/diff/3002/3003#newcode710
chrome/browser/resources/bookmark_manager/main.html:710: return true;
On 2010/02/22 19:13:58, feldstein wrote:
> Will this allow the user to drop from a different profile onto the
recent/search
> folders since the recent/search is checked below?

canDrop is a first pass. If it returns true we call canDropOn, canDropAbove and
canDropBelow. If it returns false we can return early.

However, I'll move the isOverRecentOrSearch before the checkEvery_ since it does
not depend on the drag data.

Powered by Google App Engine
This is Rietveld 408576698