Temporarily move the ia32 fast code generator into the platform-specific dire...

Temporarily move the ia32 fast code generator into the platform-specific directory.

This allows us to make changes to one platform without affecting the others.



Committed: http://code.google.com/p/v8/source/detail?r=3907

[fschneider, 2010-02-18 18:57:20]

This seemed to me to be the least intrusive way of doing this. Please review.

[Kevin Millikin (Chromium), 2010-02-18 19:30:24]

There are VS project files for arm simulator and x64 too.

I prefer to have the Visit methods of the code generator more or less ordered as
they are in ast.h, at least with expressions all together and statements all
together.

LGTM as a temporary solution.

http://codereview.chromium.org/646019/diff/1/4
File src/fast-codegen.h (right):

http://codereview.chromium.org/646019/diff/1/4#newcode33
src/fast-codegen.h:33: #include "ast.h"
Unless you think these includes will not diverge for the different platforms, I
think they should go in fast-codegen-ia32.h and below the #else.

ia32 shouldn't get anything from this file.

http://codereview.chromium.org/646019/diff/1/4#newcode36
src/fast-codegen.h:36: #if V8_TARGET_ARCH_IA32
#ifdef

[fschneider, 2010-02-19 09:18:21]

The arm and x64 VS project files should be the same (no new files there).

http://codereview.chromium.org/646019/diff/1/4
File src/fast-codegen.h (right):

http://codereview.chromium.org/646019/diff/1/4#newcode33
src/fast-codegen.h:33: #include "ast.h"
On 2010/02/18 19:30:24, Kevin Millikin wrote:
> Unless you think these includes will not diverge for the different platforms,
I
> think they should go in fast-codegen-ia32.h and below the #else.
> 
> ia32 shouldn't get anything from this file.

Done.

http://codereview.chromium.org/646019/diff/1/4#newcode36
src/fast-codegen.h:36: #if V8_TARGET_ARCH_IA32
On 2010/02/18 19:30:24, Kevin Millikin wrote:
> #ifdef

Does it make a difference? I just copied this preprocessor-directives from
frames-inl.h