Make sync_build_test work with portage build.

Make sync_build_test work with portage build.

Remove make_local_repo stage as it's not used by either build process.
Make portage build the default (--noportage still builds the old way).
Also add total time to build.  A run of sync_build_test without args
on my machine takes 2:20min.  Defaulting to --jobs=1 due to
instability reports.

[kdlucas, 2010-02-18 22:29:14]

LGTM

Just one small comment, as I think our build defaults to "x86-generic"

http://codereview.chromium.org/646015/diff/3/1002
File src/scripts/sync_build_test.sh (right):

http://codereview.chromium.org/646015/diff/3/1002#newcode78
src/scripts/sync_build_test.sh:78: DEFINE_string board "x86_generic" "Board
setting (portage)"
Should this be x86-generic, to match what our build defaults to?

[kmixter1, 2010-02-18 22:55:58]

Removed deprecated --target flag and made the default x86-generic.

[seano, 2010-02-18 23:13:54]

LGTM if you can explain/fix my comment.

Have you tried the major options/flags, e.g. build_autotest?

http://codereview.chromium.org/646015/diff/7/8
File src/scripts/sync_build_test.sh (right):

http://codereview.chromium.org/646015/diff/7/8#newcode199
src/scripts/sync_build_test.sh:199: if [[ ${FLAGS_sync} -eq ${FLAGS_true} ]];
then
FLAGS_TRUE or FLAGS_true? Looks like this should be the former... Ditto on #205

[kmixter1, 2010-02-19 00:59:09]

http://codereview.chromium.org/646015/diff/7/8
File src/scripts/sync_build_test.sh (right):

http://codereview.chromium.org/646015/diff/7/8#newcode199
src/scripts/sync_build_test.sh:199: if [[ ${FLAGS_sync} -eq ${FLAGS_true} ]];
then
On 2010/02/18 23:13:54, seano wrote:
> FLAGS_TRUE or FLAGS_true? Looks like this should be the former... Ditto on
#205

Done.

[seano, 2010-02-19 01:17:57]

LGTM