Issue 646009: Fix error in compound assignment to keyed load by making platform-independent...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 646009: Fix error in compound assignment to keyed load by making platform-independent... (Closed)

Created:
10 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix error in compound assignment to keyed load by making platform-independent full compiler code platform dependent, add test of compound assignments. Committed: http://code.google.com/p/v8/source/detail?r=3897

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+529 lines, -86 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2 3	1 chunk	+86 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View	1 2 3	1 chunk	+0 lines, -86 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2 3	1 chunk	+93 lines, -0 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2 3	1 chunk	+86 lines, -0 lines	0 comments	Download
A	test/mjsunit/compiler/assignment.js	View	1 2	1 chunk	+264 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM with the tests fixed.

Expand Messages | Collapse Messages