Issue 6460034: ARM: Implement OSR infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6460034: ARM: Implement OSR infrastructure. (Closed)

Created:
9 years, 10 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Implement OSR infrastructure.

Patch Set 1 #

Patch Set 2 : Undo accidential edit. #

Patch Set 3 : Move line. #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+201 lines, -19 lines)			Patch
M	src/arm/builtins-arm.cc	View		1 chunk	+38 lines, -2 lines	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View		6 chunks	+143 lines, -9 lines	2 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	1 chunk	+13 lines, -1 line	0 comments	Download
M	src/deoptimizer.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-09 15:12:55 UTC) #2

LGTM

http://codereview.chromium.org/6460034/diff/4002/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

http://codereview.chromium.org/6460034/diff/4002/src/arm/deoptimizer-arm.cc#n...
src/arm/deoptimizer-arm.cc:170: int count = iterator.Next();
count -> frame_count for clarity?

http://codereview.chromium.org/6460034/diff/4002/src/arm/deoptimizer-arm.cc#n...
src/arm/deoptimizer-arm.cc:498: // Correct two words for bailout id and return
address.
Looking at TableEntryGenerator::GeneratePrologue do we actually have to do
push(lr)/nop() there after all? Maybe just pushing the bailout id (and adjusting
Deoptimizer::table_entry_size_) should be enough. You don't have to try that in
this CL.

Expand Messages | Collapse Messages