Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 6460015: Move rietveld local server setup in a separate file. (Closed)

Created:
9 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move rietveld local server setup in a separate file. This makes the code more comprehensible and reusable. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74623

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -84 lines) Patch
M git_cl/PRESUBMIT.py View 1 1 chunk +31 lines, -85 lines 0 comments Download
A git_cl/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A git_cl/test/local_rietveld.py View 1 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
9 years, 10 months ago (2011-02-09 00:54:30 UTC) #1
Evan Martin
http://codereview.chromium.org/6460015/diff/1/git_cl/test/setup_mock.py File git_cl/test/setup_mock.py (right): http://codereview.chromium.org/6460015/diff/1/git_cl/test/setup_mock.py#newcode4 git_cl/test/setup_mock.py:4: Can you add a file-level comment describing what this ...
9 years, 10 months ago (2011-02-09 00:57:23 UTC) #2
M-A Ruel
Reformatted against http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
9 years, 10 months ago (2011-02-09 03:39:23 UTC) #3
Evan Martin
On 2011/02/09 03:39:23, Marc-Antoine Ruel wrote: > Reformatted against > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html Wow, we allow normal ...
9 years, 10 months ago (2011-02-09 22:28:44 UTC) #4
Evan Martin
LGTM
9 years, 10 months ago (2011-02-09 22:29:27 UTC) #5
M-A Ruel
On 2011/02/09 22:28:44, Evan Martin wrote: > Wow, we allow normal Python style now? Hooray! ...
9 years, 10 months ago (2011-02-09 23:44:54 UTC) #6
commit-bot: I haz the power
Can't process patch: Can't patch empty file (svn) at line 144
9 years, 10 months ago (2011-02-09 23:45:01 UTC) #7
commit-bot: I haz the power
9 years, 10 months ago (2011-02-11 17:27:22 UTC) #8
Change committed as 74623

Powered by Google App Engine
This is Rietveld 408576698