Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 6459017: Change pack_firmware_image::EntryBlob behavior (Closed)

Created:
9 years, 10 months ago by Che-Liang Chiou
Modified:
9 years ago
Reviewers:
Tom Wai-Hong Tam
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Change pack_firmware_image::EntryBlob behavior Old: Trim input file when it is larger than specified firmware section length New: Raise exception when such thing happens BUG=none TEST=manual $ cat > config <<EOF OUTPUT='/dev/null' SIZE=1024 ENTRIES = [ EntryBlob(offset=0, length=1, name='', flags=0, path='../LICENSE') ] EOF $ ./pack_firmware_image config Traceback (most recent call last): File "./pack_firmware_image", line 266, in <module> main() File "./pack_firmware_image", line 260, in main pack_firmware_image(env['ENTRIES'], env['OUTPUT'], env['SIZE']) File "./pack_firmware_image", line 227, in pack_firmware_image entry.Pack(firmware_image, entries) File "./pack_firmware_image", line 133, in Pack raise PackError('blob too large: %d > %d' % (size, self.length)) __main__.PackError: blob too large: 1566 > 1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=31b206f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M utility/pack_firmware_image View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Che-Liang Chiou
9 years, 10 months ago (2011-02-09 07:06:59 UTC) #1
Tom Wai-Hong Tam
9 years, 10 months ago (2011-02-10 03:20:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698