Chromium Code Reviews
DescriptionChange pack_firmware_image::EntryBlob behavior
Old: Trim input file when it is larger than specified firmware section length
New: Raise exception when such thing happens
BUG=none
TEST=manual
$ cat > config <<EOF
OUTPUT='/dev/null'
SIZE=1024
ENTRIES = [
EntryBlob(offset=0, length=1, name='', flags=0, path='../LICENSE')
]
EOF
$ ./pack_firmware_image config
Traceback (most recent call last):
File "./pack_firmware_image", line 266, in <module>
main()
File "./pack_firmware_image", line 260, in main
pack_firmware_image(env['ENTRIES'], env['OUTPUT'], env['SIZE'])
File "./pack_firmware_image", line 227, in pack_firmware_image
entry.Pack(firmware_image, entries)
File "./pack_firmware_image", line 133, in Pack
raise PackError('blob too large: %d > %d' % (size, self.length))
__main__.PackError: blob too large: 1566 > 1
Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=31b206f
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||