Issue 6459014: Call ProfileSyncService::ShowErrorUI for post login sync errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6459014: Call ProfileSyncService::ShowErrorUI for post login sync errors (Closed)

Created:
9 years, 10 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
John Gregg, johnnyg, jhawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Call ProfileSyncService::ShowErrorUI for post login sync errors BUG=chromium-os:11857 TEST=See issue Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74224

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	chrome/browser/dom_ui/options/personal_options_handler.cc	View	1	1 chunk	+14 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

stevenjb

This is a R10 blocker, please review as soon as you can. Thanks!

9 years, 10 months ago (2011-02-09 01:49:32 UTC) #1

John Gregg

9 years, 10 months ago (2011-02-09 01:51:12 UTC) #2

On 2011/02/09 01:49:32, Steven Bennetts wrote:
> This is a R10 blocker, please review as soon as you can. Thanks!

LGTM