Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 6459010: Improve presubmit_support.py handling of git checkout. (Closed)

Created:
9 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Improve presubmit_support.py handling of git checkout. It would fail otherwise when called directly from a git checkout subdirectory. Updated unit test. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M presubmit_support.py View 3 chunks +24 lines, -12 lines 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
9 years, 10 months ago (2011-02-09 00:49:15 UTC) #1
bradn
LGTM
9 years, 10 months ago (2011-02-09 04:26:33 UTC) #2
commit-bot: I haz the power
9 years, 10 months ago (2011-02-09 14:02:17 UTC) #3
Change committed as 74281

Powered by Google App Engine
This is Rietveld 408576698