Cancel prerender when we discover a download starting from a page we are prer...

chrome/browser/renderer_host/download_throttling_resource_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_DOWNLOAD_THROTTLING_RESOURCE_HANDLER_H_
 #define CHROME_BROWSER_RENDERER_HOST_DOWNLOAD_THROTTLING_RESOURCE_HANDLER_H_
 #pragma once
 
 #include <string>
 
 #include "chrome/browser/download/download_request_limiter.h"
 #include "chrome/browser/renderer_host/resource_handler.h"
+#include "chrome/common/notification_type.h"
 #include "googleurl/src/gurl.h"
 
 class DownloadResourceHandler;
 class ResourceDispatcherHost;
+class ResourceRequestDetails;
 
 namespace net {
 class URLRequest;
 }  // namespace net
 
 // DownloadThrottlingResourceHandler is used to determine if a download should
 // be allowed. When a DownloadThrottlingResourceHandler is created it pauses the
 // download and asks the DownloadRequestLimiter if the download should be
 // allowed. The DownloadRequestLimiter notifies us asynchronously as to whether
 // the download is allowed or not. If the download is allowed the request is
@@ skipping 31 matching lines @@
   // DownloadRequestLimiter::Callback implementation:
   virtual void CancelDownload();
   virtual void ContinueDownload();
   virtual int GetRequestId();
 
  private:
   virtual ~DownloadThrottlingResourceHandler();
 
   void CopyTmpBufferToDownloadHandler();
 
+  ResourceRequestDetails* GetResourceRequestDetails();
+
+  template<NotificationType::Type T>

[cbentzel, 2011/02/09 12:11:14]

Move this into .cc file and put in anonymous namespace. It's only being used by
internal methods.

It also doesn't look like there are substantial gains templating it on
NotificationType::Type - why not pass it in as an argument?

[dominich, 2011/02/09 22:33:30]

I was following the pattern established in the ResourceDispatcherHost to be
consistent, but yes I'd rather this was a parameter too. 

[dominich, 2011/02/09 22:33:30]

Done.

+  static void NotifyOnUI(int process_id, int view_id,
+                         ResourceRequestDetails* details);
+
   ResourceDispatcherHost* host_;
   net::URLRequest* request_;
   GURL url_;
   int render_process_host_id_;
   int render_view_id_;
   int request_id_;
 
   // Handles the actual download. This is only created if the download is
   // allowed to continue.
   scoped_refptr<DownloadResourceHandler> download_handler_;
@@ skipping 10 matching lines @@
   // If true the next call to OnReadCompleted is ignored. This is used if we're
   // paused during a call to OnReadCompleted. Pausing during OnReadCompleted
   // results in two calls to OnReadCompleted for the same data. This make sure
   // we ignore one of them.
   bool ignore_on_read_complete_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadThrottlingResourceHandler);
 };
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_DOWNLOAD_THROTTLING_RESOURCE_HANDLER_H_