Cancel prerender when we discover a download starting from a page we are prer...

chrome/browser/download/download_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download utility implementation
 
 #include "chrome/browser/download/download_util.h"
 
 #if defined(OS_WIN)
 #include <shobjidl.h>
@@ skipping 18 matching lines @@
 #include "chrome/browser/download/download_item.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/history/download_create_info.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
+#include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/time_format.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 #include "net/base/mime_util.h"
 #include "net/base/net_util.h"
@@ skipping 631 matching lines @@
     Browser* browser = *browser_iterator;
     BrowserWindow* window = browser->window();
     if (!window)
       continue;
     HWND frame = window->GetNativeHandle();
     if (download_count == 0 || progress == 1.0f)
       taskbar->SetProgressState(frame, TBPF_NOPROGRESS);
     else if (!progress_known)
       taskbar->SetProgressState(frame, TBPF_INDETERMINATE);
     else
-      taskbar->SetProgressValue(frame, (int)(progress * 100), 100);
+      taskbar->SetProgressValue(frame, static_cast<int>(progress * 100), 100);
   }
 #endif
 }
 #endif
 
 // Appends the passed the number between parenthesis the path before the
 // extension.
 void AppendNumberToPath(FilePath* path, int number) {
   *path = path->InsertBeforeExtensionASCII(StringPrintf(" (%d)", number));
 }
@@ skipping 32 matching lines @@
       request_context_getter->GetURLRequestContext();
   context->set_referrer_charset(referrer_charset);
 
   rdh->BeginDownload(url,
                      referrer,
                      save_info,
                      true,  // Show "Save as" UI.
                      render_process_host_id,
                      render_view_id,
                      context);
+
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      NewRunnableFunction(&NotifyDownloadInitiated,
+                          render_process_host_id, render_view_id));

[Randy Smith (Not in Mondays), 2011/02/14 19:20:51]

See notes elsewhere; this either needs to be moved to ResourceDispatcherHost or
we need another notification point in ResourceMessageFilter::OnDownloadUrl, and
I'd vote for choice #1.

[dominich, 2011/02/15 19:09:19]

Done.

 }
 
 void CancelDownloadRequest(ResourceDispatcherHost* rdh,
                            int render_process_id,
                            int request_id) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   rdh->CancelRequest(render_process_id, request_id, false);
 }
 
+void NotifyDownloadInitiated(int render_process_id, int render_view_id) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  RenderViewHost* rvh = RenderViewHost::FromID(render_process_id,
+                                               render_view_id);
+  if (!rvh)
+    return;
+
+  NotificationService::current()->Notify(NotificationType::DOWNLOAD_INITIATED,
+                                         Source<RenderViewHost>(rvh),
+                                         NotificationService::NoDetails());

[Randy Smith (Not in Mondays), 2011/02/14 19:20:51]

I'm happy with this location and structure.

[dominich, 2011/02/15 19:09:19]

Done.

+}
+
 int GetUniquePathNumberWithCrDownload(const FilePath& path) {
   if (!file_util::PathExists(path) &&
       !file_util::PathExists(GetCrDownloadPath(path)))
     return 0;
 
   FilePath new_path;
   for (int count = 1; count <= kMaxUniqueFiles; ++count) {
     new_path = FilePath(path);
     AppendNumberToPath(&new_path, count);
 
@@ skipping 51 matching lines @@
         !service->IsDownloadFromGallery(info->url, info->referrer_url)) {
       // Extensions that are not from the gallery are considered dangerous.
       ret = true;
     }
   }
 
   return ret;
 }
 
 }  // namespace download_util