Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 6458015: Add support for grabbing Packages files using external programs. (Closed)

Created:
9 years, 10 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
zmedico, zmedico, anush
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add support for grabbing Packages files using external programs. If the user specifies FETCHCOMMAND_*, Portage should honor this when grabbing Packages files. This allows users to setup support for grabbing Packages files from other protocols. BUG=chrome-os-partner:2026 TEST=Try downloading prebuilts from gs:// when FETCHCOMMAND_GS is setup in make.conf Change-Id: I96b239819351633dd02d608954e81a1c363a4687 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=719f524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M pym/portage/dbapi/bintree.py View 2 chunks +14 lines, -2 lines 0 comments Download
M pym/portage/getbinpkg.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
davidjames
Portage already supports downloading the actual tarballs via an external program, but it restricts the ...
9 years, 10 months ago (2011-02-09 00:30:24 UTC) #1
anush
LGTM. Zac may have better suggestions on how to preserve the file_get() api. On 2011/02/09 ...
9 years, 10 months ago (2011-02-10 01:52:44 UTC) #2
zmedico
9 years, 10 months ago (2011-02-14 04:05:38 UTC) #3
The patch looks good, so I've merged it upstream:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=53f096c5...

Also, I've changed the FileNotFound to EnvironmentError so that it's caught:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=334af57e...

Powered by Google App Engine
This is Rietveld 408576698