Remove no-op oobe_completed touch

Remove no-op oobe_completed touch

The original intent of this code was to prevent mounting
of the OEM partition. However, chromeos_startup mounts
/mnt/stateful_partition/home to /home and this file gets
hidden. Given that we might mount the OEM partition always
soon, removing this code.

BUG=chromium-os:11661
TEST=build_packages, build_image, ran suite_Smoke

Change-Id: I7ef4dd5c78484664cbdeb4ffaff26e2fcf8d2507

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3cb5eb0

[jrbarnette, 2011-02-09 01:28:40]

There's a pre-existing bug here that should get fixed rather than
perpetuated.  The issue is that this creates /home/chronos, but at
boot time, /home is mounted from /mnt/stateful_partition/home,
covering up the earlier contents of /home.

I believe the correct code should create the /home/chronos files
in the stateful partition.

[petkov, 2011-02-09 17:56:18]

OK, so this seems broken to start with. What would you like to see:

1. Remove touching of /home/chronos/.oobe_completed from mod_image_for_tests.sh
-- it's basically a no-op currently anyway.

2. Create /mnt/stateful/home/chronos/.oobe_completed.

I'd rather do 1 since the oobe_completed thing is a separate issue from what I'm
trying to address right now but 2 is also fine.

On 2011/02/09 01:28:40, jrbarnette wrote:
> There's a pre-existing bug here that should get fixed rather than
> perpetuated.  The issue is that this creates /home/chronos, but at
> boot time, /home is mounted from /mnt/stateful_partition/home,
> covering up the earlier contents of /home.
> 
> I believe the correct code should create the /home/chronos files
> in the stateful partition.

[sosa, 2011-02-09 18:49:36]

If this is a no-op we should just remove it.

On Wed, Feb 9, 2011 at 9:56 AM,  <petkov@chromium.org> wrote:
> OK, so this seems broken to start with. What would you like to see:
>
> 1. Remove touching of /home/chronos/.oobe_completed from
> mod_image_for_tests.sh
> -- it's basically a no-op currently anyway.
>
> 2. Create /mnt/stateful/home/chronos/.oobe_completed.
>
> I'd rather do 1 since the oobe_completed thing is a separate issue from what
> I'm
> trying to address right now but 2 is also fine.
>
> On 2011/02/09 01:28:40, jrbarnette wrote:
>>
>> There's a pre-existing bug here that should get fixed rather than
>> perpetuated.  The issue is that this creates /home/chronos, but at
>> boot time, /home is mounted from /mnt/stateful_partition/home,
>> covering up the earlier contents of /home.
>
>> I believe the correct code should create the /home/chronos files
>> in the stateful partition.
>
>
>
> http://codereview.chromium.org/6458007/
>

[Will Drewry, 2011-02-09 19:03:14]

Yea - it may make more sense just to remove the oobe_complete line since it'll
be hidden by the mount point anyway.  Then customize_rootfs can be happy not
creating /home/chronos on the rootfs.

[The only time I could think it'd be useful to have a ${ROOTFS}/home/chronos is
if we expect to debug a bad stateful partition, but we really can't do that
now.]

[jrbarnette, 2011-02-09 20:54:19]

On 2011/02/09 19:03:14, Will Drewry wrote:
> Yea - it may make more sense just to remove the oobe_complete line since it'll
> be hidden by the mount point anyway.  Then customize_rootfs can be happy not
> creating /home/chronos on the rootfs.
> 
It should be noted that this code wasn't *meant* to be a no-op.  It's
supposed to prevent the OEM partition from being mounted unnecessarily
during boot, in order to save time.  It's just that it was implemented wrong.

That said, there's been separate e-mail suggesting that there could
be changes that require the OEM partition to be mounted in all cases,
not just during OOBE.  In that case, removing this code is reasonable.

> [The only time I could think it'd be useful to have a ${ROOTFS}/home/chronos
is
> if we expect to debug a bad stateful partition, but we really can't do that
> now.]

[petkov, 2011-02-09 21:44:22]

PTAL -- changed the CL to remove touching of .oobe_completed.

[jrbarnette, 2011-02-09 22:02:52]

On 2011/02/09 21:44:22, petkov wrote:
> PTAL -- changed the CL to remove touching of .oobe_completed.

Good enough.  If we really need the fix to avoid mounting the file system,
we can fix it correctly later.

LGTM!