Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

Issue 6458004: Remove includes of message headers in headers. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
===================================================================
--- chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc (revision 73994)
+++ chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc (working copy)
@@ -9,6 +9,7 @@
#include "base/logging.h"
#include "base/message_loop.h"
#include "base/metrics/histogram.h"
+#include "base/string_util.h"
#include "base/time.h"
#include "chrome/renderer/render_view.h"
#include "chrome/renderer/safe_browsing/feature_extractor_clock.h"
@@ -146,10 +147,7 @@
if (!cur_frame_) {
WebKit::WebView* web_view = render_view_->webview();
if (!web_view) {
- // When the WebView is going away, the render view should have called
- // CancelPendingExtraction() which should have stopped any pending work,
- // so this case should not happen.
- NOTREACHED();
+ // RenderView might be closing.
Tom Sepez 2011/02/08 21:21:21 Did we loose a comment here during a sync?
jam 2011/02/08 21:38:39 this was actually from an earlier change, but I fo
RunCallback(false);
return;
}

Powered by Google App Engine
This is Rietveld 408576698