Chromium Code Reviews| Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc |
| =================================================================== |
| --- chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc (revision 73994) |
| +++ chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc (working copy) |
| @@ -9,6 +9,7 @@ |
| #include "base/logging.h" |
| #include "base/message_loop.h" |
| #include "base/metrics/histogram.h" |
| +#include "base/string_util.h" |
| #include "base/time.h" |
| #include "chrome/renderer/render_view.h" |
| #include "chrome/renderer/safe_browsing/feature_extractor_clock.h" |
| @@ -146,10 +147,7 @@ |
| if (!cur_frame_) { |
| WebKit::WebView* web_view = render_view_->webview(); |
| if (!web_view) { |
| - // When the WebView is going away, the render view should have called |
| - // CancelPendingExtraction() which should have stopped any pending work, |
| - // so this case should not happen. |
| - NOTREACHED(); |
| + // RenderView might be closing. |
|
Tom Sepez
2011/02/08 21:21:21
Did we loose a comment here during a sync?
jam
2011/02/08 21:38:39
this was actually from an earlier change, but I fo
|
| RunCallback(false); |
| return; |
| } |