Issue 6456022: Change our zap values from hex numbers tagged as a heap object to hex numbers...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6456022: Change our zap values from hex numbers tagged as a heap object to hex numbers... (Closed)

Created:
9 years, 10 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change our zap values from hex numbers tagged as a heap object to hex numbers tagged as a failure. Since our zap values are valid heap object addreses we might hit asserts if a heap object gets the value of a zap constant as its address. Committed: http://code.google.com/p/v8/source/detail?r=6695

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/v8globals.h	View		1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

This fixes the win32 debug check failures in the threaded cctests

9 years, 10 months ago (2011-02-09 10:08:11 UTC) #2

LGTM

Expand Messages | Collapse Messages