Issue 6456010: Improve tests to support more git versions and different outputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6456010: Improve tests to support more git versions and different outputs. (Closed)

Created:
9 years, 10 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Improve tests to support more git versions and different outputs. Disable warning W0404 in pylint. BUG=none TEST=should now work on googlers workstations Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74242

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comment #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -13 lines)			Patch
	M	pylintrc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/gclient_scm_test.py	View	1	4 chunks	+36 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bradn

Otherwise LGTM http://codereview.chromium.org/6456010/diff/1/tests/gclient_scm_test.py File tests/gclient_scm_test.py (right): http://codereview.chromium.org/6456010/diff/1/tests/gclient_scm_test.py#newcode858 tests/gclient_scm_test.py:858: format=("%(asctime).19s %(levelname)s %(filename)s:" " -> ', to ...

9 years, 10 months ago (2011-02-09 04:24:30 UTC) #2

Change committed as 74242

Expand Messages | Collapse Messages