Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 6454011: 1) Return failure if any of property sets failed; (Closed)

Created:
9 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

1) Return failure if any of property sets failed; 2) We cannot assert the declared property will go to the extension in the presence of callbacks and interceptors. BUG=1119 TEST=test/mjsunit/regress/regress-1119.js Committed: http://code.google.com/p/v8/source/detail?r=6687

Patch Set 1 #

Patch Set 2 : Cleaning up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M src/runtime.cc View 2 chunks +7 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-1119.js View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, may you have a look? I've added three bailout checks, but managed to test ...
9 years, 10 months ago (2011-02-08 18:39:01 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-08 18:44:37 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698