Issue 6454001: Make sure that we never call prevent extension on the global proxy,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6454001: Make sure that we never call prevent extension on the global proxy,... (Closed)

Created:
9 years, 10 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make sure that we never call prevent extension on the global proxy, but instead call this on the global object. BUG: 1103 Committed: http://code.google.com/p/v8/source/detail?r=6675

Patch Set 3 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	src/objects.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-1103.js	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6454001/diff/2001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/6454001/diff/2001/src/objects.cc#newcode2784 src/objects.cc:2784: if (proto->IsNull()) return proto; I don't think you ...

9 years, 10 months ago (2011-02-08 12:25:34 UTC) #2

Rico

9 years, 10 months ago (2011-02-08 12:39:04 UTC) #3

http://codereview.chromium.org/6454001/diff/2001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/6454001/diff/2001/src/objects.cc#newcode2784
src/objects.cc:2784: if (proto->IsNull()) return proto;
On 2011/02/08 12:25:35, Mads Ager wrote:
> I don't think you should return the null prototype here? Shouldn't you return
> this instead?

Done.

Expand Messages | Collapse Messages

Issue 6454001: Make sure that we never call prevent extension on the global proxy,... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages