Issue 6453005: Check for overflow when bumping new space's top in inlined allocation....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6453005: Check for overflow when bumping new space's top in inlined allocation.... (Closed)

Created:
9 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Rodolph Perfetta, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Check for overflow when bumping new space's top in inlined allocation. BUG=v8:1109 TEST=test/mjsunit/regress/regress-1109.js Committed: http://code.google.com/p/v8/source/detail?r=6684

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -10 lines)			Patch
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+2 lines, -0 lines	2 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	3 chunks	+11 lines, -5 lines	0 comments	Download
A	test/mjsunit/regress/regress-1109.js	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rodolph Perfetta

9 years, 10 months ago (2011-02-08 16:53:16 UTC) #3

drive by comments

http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc#...
src/arm/macro-assembler-arm.cc:1154: b(cs, gc_required);
You need to set the flags in the add instruction above (SetCC parameter).

http://codereview.chromium.org/6453005/diff/1/src/arm/macro-assembler-arm.cc#...
src/arm/macro-assembler-arm.cc:1237: b(cs, gc_required);
ditto.

Expand Messages | Collapse Messages