chrome/browser/ui/views/info_bubble.cc - Issue 6452011: Rework tree APIs to reflect Google style and more const-correctness....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/info_bubble.cc

Issue 6452011: Rework tree APIs to reflect Google style and more const-correctness.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.cc ('k') | chrome/browser/ui/views/infobars/infobar_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/info_bubble.cc

===================================================================

--- chrome/browser/ui/views/info_bubble.cc (revision 74231)

+++ chrome/browser/ui/views/info_bubble.cc (working copy)

@@ -438,7 +438,7 @@

arrow_location, false, contents->GetPreferredSize(),

&contents_bounds, &window_bounds);

// This new view must be added before |contents| so it will paint under it.

- contents_view->AddChildView(0, border_contents_);

+ contents_view->AddChildViewAt(border_contents_, 0);

// |contents_view| has no layout manager, so we have to explicitly position

// its children.

@@ -500,7 +500,7 @@

if (action == WA_INACTIVE) {

Close();

} else if (action == WA_ACTIVE) {

- DCHECK_GT(GetRootView()->GetChildViewCount(), 0);

+ DCHECK(GetRootView()->has_children());

GetRootView()->GetChildViewAt(0)->RequestFocus();

}