Rework tree APIs to reflect Google style and more const-correctness....

views/controls/textfield/native_textfield_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/textfield/native_textfield_win.h"
 
 #include <algorithm>
 
 #include "base/i18n/rtl.h"
 #include "base/string_util.h"
@@ skipping 418 matching lines @@
 
   VARIANT var;
 
   // Set the accessible role.
   var.vt = VT_I4;
   var.lVal = ROLE_SYSTEM_TEXT;
   hr = pAccPropServices->SetHwndProp(m_hWnd, OBJID_CLIENT,
       CHILDID_SELF, PROPID_ACC_ROLE, var);
 
   // Set the accessible name by getting the label text.
-  View* parent = textfield_->GetParent();
-  int label_index = parent->GetChildIndex(textfield_) - 1;
+  View* parent = textfield_->parent();
+  int label_index = parent->GetIndexOf(textfield_) - 1;

[sky, 2011/02/08 19:11:54]

Are you sure this is right if parent doesn't contain textfield_? If the code
ends up equivalent as:

static_cast<int>(parent->GetIndexOf(textfield_) - 1), then it can never be
negative.

PS I don't like size_t

   if (label_index >= 0) {
     // Try to find the name of this text field.
     // We expect it to be a Label preceeding this view (if it exists).
     string16 name;
     View* label_view = parent->GetChildViewAt(label_index);
     if (label_view->GetClassName() == Label::kViewClassName &&
         label_view->GetAccessibleName(&name)) {
       hr = pAccPropServices->SetHwndPropStr(m_hWnd, OBJID_CLIENT,
           CHILDID_SELF, PROPID_ACC_NAME, name.c_str());
     }
@@ skipping 711 matching lines @@
 NativeTextfieldWrapper* NativeTextfieldWrapper::CreateWrapper(
     Textfield* field) {
   if (NativeTextfieldViews::IsTextfieldViewsEnabled()) {
     return new NativeTextfieldViews(field);
   } else {
     return new NativeTextfieldWin(field);
   }
 }
 
 }  // namespace views