Issue 6452002: Change the code for materializing double constants on ia32....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6452002: Change the code for materializing double constants on ia32.... (Closed)

Created:
9 years, 10 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change the code for materializing double constants on ia32. Instead of using the stack, use a temporary integer register and avoid memory access. Committed: http://code.google.com/p/v8/source/detail?r=6696

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -15 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2	1 chunk	+24 lines, -12 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	test/cctest/test-disasm-ia32.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/6452002/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6452002/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode955 src/ia32/lithium-codegen-ia32.cc:955: __ Set(temp, Immediate(lower)); Have you considered using the ...

9 years, 10 months ago (2011-02-08 13:21:10 UTC) #2

fschneider

Added support for SSE4 pinsrd and check of lower dword is zero.

9 years, 10 months ago (2011-02-09 10:19:40 UTC) #3

William Hesse

9 years, 10 months ago (2011-02-09 12:30:51 UTC) #4

LGTM, with change.

http://codereview.chromium.org/6452002/diff/4001/src/ia32/lithium-codegen-ia3...
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6452002/diff/4001/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:959: __ pinsrd(res, Operand(temp), 0);
Use movsd, before pinsrd(upper), and eliminate the xor.

Expand Messages | Collapse Messages