src/handles.cc - Issue 6451004: Propagate exceptions thrown when setting elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.cc

Issue 6451004: Propagate exceptions thrown when setting elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Better way to communicate back absence of setter Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/handles.cc

diff --git a/src/handles.cc b/src/handles.cc

index 274c34ddebaf24283d1f0d1d21a5f9217dc469d2..795eda073c18e44244093ccc8a88785285d9015a 100644

--- a/src/handles.cc

+++ b/src/handles.cc

@@ -808,6 +808,7 @@ static bool CompileLazyHelper(CompilationInfo* info,

ClearExceptionFlag flag) {

// Compile the source information to a code object.

ASSERT(info->IsOptimizing() || !info->shared_info()->is_compiled());

+ ASSERT(!Top::has_pending_exception());

bool result = Compiler::CompileLazy(info);

ASSERT(result != Top::has_pending_exception());

if (!result && flag == CLEAR_EXCEPTION) Top::clear_pending_exception();

« no previous file with comments | « no previous file | src/messages.cc » ('j') | no next file with comments »