Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: net/proxy/proxy_server.h

Issue 6450006: Migrate Proxy Settings API to net::ProxyServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/out/Debug
Patch Set: Nits Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_server.h
diff --git a/net/proxy/proxy_server.h b/net/proxy/proxy_server.h
index 3786ddbe0a755f5790f53920a5437fd9a9f34e2c..7ac55927210637779897c50d5b5f532c60741bfd 100644
--- a/net/proxy/proxy_server.h
+++ b/net/proxy/proxy_server.h
@@ -128,6 +128,12 @@ class ProxyServer {
// scheme. Returns -1 if unknown.
static int GetDefaultPortForScheme(Scheme scheme);
+ // Parse the proxy scheme from a URL-like representation, to a
eroman 2011/02/09 05:12:46 nit: please use passive tense, as in "Parses"
battre 2011/02/09 10:04:38 Done.
+ // ProxyServer::Scheme. This corresponds with the values used in
+ // ProxyServer::ToURI(). If no type could be matched, returns SCHEME_INVALID.
+ // |scheme| can be one from http, https, socks, socks4, socks5, direct.
eroman 2011/02/09 05:12:46 nit: "from" ---> "of"
battre 2011/02/09 10:04:38 Done.
+ static Scheme GetSchemeFromURI(const std::string& scheme);
+
bool operator==(const ProxyServer& other) const {
return scheme_ == other.scheme_ &&
host_port_pair_.Equals(other.host_port_pair_);

Powered by Google App Engine
This is Rietveld 408576698