Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Unified Diff: chrome/browser/extensions/extension_proxy_apitest.cc

Issue 6450006: Migrate Proxy Settings API to net::ProxyServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/out/Debug
Patch Set: Fixed one more whitespace Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_proxy_apitest.cc
diff --git a/chrome/browser/extensions/extension_proxy_apitest.cc b/chrome/browser/extensions/extension_proxy_apitest.cc
index 44856dd12d2bfc7f587323dda3e986196ff1bb9f..b07e2cb9e7c784b7c323ee0210665f3d37ac5956 100644
--- a/chrome/browser/extensions/extension_proxy_apitest.cc
+++ b/chrome/browser/extensions/extension_proxy_apitest.cc
@@ -147,9 +147,9 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividual) {
PrefService* pref_service = browser()->profile()->GetPrefs();
ValidateSettings(ProxyPrefs::MODE_FIXED_SERVERS,
- "http=http://1.1.1.1;"
- "https=socks://2.2.2.2;"
- "ftp=http://3.3.3.3:9000;"
+ "http=1.1.1.1:80;" // http:// is pruned.
+ "https=2.2.2.2:80;" // http:// is pruned.
+ "ftp=3.3.3.3:9000;" // http:// is pruned.
"socks=socks4://4.4.4.4:9090",
kNoPac,
pref_service);
@@ -157,9 +157,9 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, ProxyFixedIndividual) {
// Now check the incognito preferences.
pref_service = browser()->profile()->GetOffTheRecordProfile()->GetPrefs();
ValidateSettings(ProxyPrefs::MODE_FIXED_SERVERS,
- "http=http://1.1.1.1;"
- "https=socks://2.2.2.2;"
- "ftp=http://3.3.3.3:9000;"
+ "http=1.1.1.1:80;"
+ "https=2.2.2.2:80;"
+ "ftp=3.3.3.3:9000;"
"socks=socks4://4.4.4.4:9090",
kNoPac,
pref_service);
@@ -181,9 +181,9 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
// Now check the incognito preferences.
pref_service = browser()->profile()->GetOffTheRecordProfile()->GetPrefs();
ValidateSettings(ProxyPrefs::MODE_FIXED_SERVERS,
- "http=http://1.1.1.1;"
- "https=socks://2.2.2.2;"
- "ftp=http://3.3.3.3:9000;"
+ "http=1.1.1.1:80;"
+ "https=socks5://2.2.2.2:1080;" // socks5 equals socks.
+ "ftp=3.3.3.3:9000;"
"socks=socks4://4.4.4.4:9090",
kNoPac,
pref_service);
@@ -201,9 +201,9 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
PrefService* pref_service = browser()->profile()->GetPrefs();
ValidateSettings(ProxyPrefs::MODE_FIXED_SERVERS,
- "http=http://1.1.1.1;"
- "https=socks://2.2.2.2;"
- "ftp=http://3.3.3.3:9000;"
+ "http=1.1.1.1:80;"
+ "https=socks5://2.2.2.2:1080;"
+ "ftp=3.3.3.3:9000;"
"socks=socks4://4.4.4.4:9090",
kNoPac,
pref_service);
@@ -211,9 +211,9 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,
// Now check the incognito preferences.
pref_service = browser()->profile()->GetOffTheRecordProfile()->GetPrefs();
ValidateSettings(ProxyPrefs::MODE_FIXED_SERVERS,
- "http=http://5.5.5.5;"
- "https=socks://6.6.6.6;"
- "ftp=http://7.7.7.7:9000;"
+ "http=5.5.5.5:80;"
+ "https=socks5://6.6.6.6:1080;"
+ "ftp=7.7.7.7:9000;"
"socks=socks4://8.8.8.8:9090",
kNoPac,
pref_service);
« no previous file with comments | « chrome/browser/extensions/extension_proxy_api.cc ('k') | chrome/test/data/extensions/api_test/proxy/individual/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698