Issue 6450004: Do sanity check of exception state when returning from native to JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6450004: Do sanity check of exception state when returning from native to JS. (Closed)

Created:
9 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Lasse Reichstein, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Do sanity check of exception state when returning from native to JS. If --debug-code is on, check that returned value and Top::has_pending_exception agree on exception state. Committed: http://code.google.com/p/v8/source/detail?r=6692

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Lasse and Mads, another tiny review. If you're fine with it, I'll bring to other ...

9 years, 10 months ago (2011-02-08 14:44:33 UTC) #1

Looks good to me.

Expand Messages | Collapse Messages