Issue 6447007: Fix a bug that occurs when functions are defined with more than 16,382 parame...

Issue 6447007: Fix a bug that occurs when functions are defined with more than 16,382 parame... (Closed)

Created:
9 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix a bug that occurs when functions are defined with more than 16,382 parameters. Committed: http://code.google.com/p/v8/source/detail?r=6697

Patch Set 6 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -24 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1 2 3 4	1 chunk	+6 lines, -5 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2 3 4	1 chunk	+7 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 2 3 4	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/messages.js	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.h	View	1 2 3 4 5	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/parser.cc	View	1 2 3	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2 3 4	1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2 3 4	1 chunk	+9 lines, -6 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-1122.js	View	1 2 3 4 5	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

William Hesse

ARM platform is OK, function calls are OK, ArgumentsAdapter is OK.

9 years, 10 months ago (2011-02-08 17:23:18 UTC) #1

Mads Ager (chromium)

Test please? http://codereview.chromium.org/6447007/diff/8/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/6447007/diff/8/src/x64/full-codegen-x64.cc#newcode302 src/x64/full-codegen-x64.cc:302: if (is_uint16(arguments_bytes)) { You could make this ...

9 years, 10 months ago (2011-02-08 17:34:36 UTC) #2

William Hesse

Test added. LargeRet(int, Register) added to macro assembler. Named constant made and used for maximum ...

9 years, 10 months ago (2011-02-09 11:49:28 UTC) #3

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6447007/diff/8001/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/6447007/diff/8001/src/ia32/codegen-ia32.cc#newcode3775 src/ia32/codegen-ia32.cc:3775: __ LargeRet(arguments_bytes, ecx); Just call it Ret? You ...

9 years, 10 months ago (2011-02-09 12:34:14 UTC) #4

William Hesse

9 years, 10 months ago (2011-02-09 12:42:55 UTC) #5

LargeRet changed to Ret.
On 2011/02/09 12:34:14, Mads Ager wrote:
> LGTM
> 
> http://codereview.chromium.org/6447007/diff/8001/src/ia32/codegen-ia32.cc
> File src/ia32/codegen-ia32.cc (right):
> 
>
http://codereview.chromium.org/6447007/diff/8001/src/ia32/codegen-ia32.cc#new...
> src/ia32/codegen-ia32.cc:3775: __ LargeRet(arguments_bytes, ecx);
> Just call it Ret? You don't know if it is large or not at this point.

Expand Messages | Collapse Messages