Issue 6447001: Adds "FAILS_" to failing tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6447001: Adds "FAILS_" to failing tests... (Closed)

Created:
9 years, 10 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato, rvargas (doing something else), dmazzoni

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds "FAILS_" to failing tests This change adds "FAILS_" prefix to NavBeforeNTPCommits, AboutHangInNTP, and NTPHasThumbnails on Linux and Mac since it started failing since around r74087. TBR=rvargas,dmazzoni,yusukes BUG=72286 TEST=make the debug bots green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74110

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/dom_ui/new_tab_ui_uitest.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

9 years, 10 months ago (2011-02-14 16:10:22 UTC) #2

FYI, it's better to use the MAYBE_ pattern when marking tests as failing on a
subset of platforms - see the docs here for the reasoning behind this:

http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/han...

Expand Messages | Collapse Messages